<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Mar 13, 2020, at 19:03, Ehud Katz via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><a href="https://github.com/llvm/llvm-project/commit/fcc2238b8bfb9498b46a48d219193de8c00a25a0" class="">rGfcc2238b8bfb</a> broke the sanitizer "annotate" tests - <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/26137/" class="gmail-remarkup-link" target="_blank" rel="noreferrer" style="text-decoration-line:none;color:rgb(19,108,178);margin-top:0px;font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/26137/</a>, which inherently, I think, seems like a good enough test case.<div class=""><a href="https://github.com/llvm/llvm-project/commit/18eae3312297cb197a3131f3ad9ca2bebb217415" class="">rG18eae3312297</a> fixes it.<br class=""></div></div></div></blockquote></div><br class=""><div class="">Usually the bots should not be the first line of defense, the unit tests in the repo should be. The bot might go away or some other changes in other parts of LLVM/Clang/Sanitizers may change and hide the failure.</div><div class=""><br class=""></div><div class="">If possible, please try to get a reduced IR test case for the failure. This will provide a more solid guard against the error in the future.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Florian</div></body></html>