<div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 21, 2020 at 6:29 PM Craig Topper <<a href="mailto:craig.topper@gmail.com">craig.topper@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Thanks! Which compiler caught it?<br clear="all"><div><div dir="ltr">~Craig</div></div></div></blockquote><div><br></div><div>Hey Craig,<br></div><div><br></div><div>This is on GCC 8.3 with release build.<br></div><div><br></div><div>Regards.<br></div><div>Nikita<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 21, 2020 at 9:26 AM Nikita Popov via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Nikita Popov<br>
Date: 2020-02-21T18:26:05+01:00<br>
New Revision: c90ea87cfd71f8da05f2e684d3cf139f9773c15d<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/c90ea87cfd71f8da05f2e684d3cf139f9773c15d" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/c90ea87cfd71f8da05f2e684d3cf139f9773c15d</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/c90ea87cfd71f8da05f2e684d3cf139f9773c15d.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/c90ea87cfd71f8da05f2e684d3cf139f9773c15d.diff</a><br>
<br>
LOG: [X86] Fix SDLoc initialization<br>
<br>
Fixes -Wparentheses warning, in this case indicating a genuine<br>
bug.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/lib/Target/X86/X86ISelLowering.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp<br>
index 7f6d36de7150..64cae53b0d40 100644<br>
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp<br>
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp<br>
@@ -28740,7 +28740,7 @@ SDValue X86TargetLowering::LowerF128Call(SDValue Op, SelectionDAG &DAG,<br>
<br>
 // Custom split CVTPS2PH with wide types.<br>
 static SDValue LowerCVTPS2PH(SDValue Op, SelectionDAG &DAG) {<br>
-  SDLoc(dl);<br>
+  SDLoc dl(Op);<br>
   EVT VT = Op.getValueType();<br>
   SDValue Lo, Hi;<br>
   std::tie(Lo, Hi) = DAG.SplitVectorOperand(Op.getNode(), 0);<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div></div>