<div dir="ltr">a4b590dd397a2798d4f83abe5a5fd9ddd3d31b4f - hopefully that addresses the issue.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 5, 2020 at 2:23 PM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Sorry for the delay - working on it now</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 5, 2020 at 2:19 PM Petr Hosek <<a href="mailto:phosek@chromium.org" target="_blank">phosek@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>We're seeing the same failure on our AArch64 bots: <a href="https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8889258727239787472/+/steps/clang/0/steps/test/0/stdout" target="_blank">https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8889258727239787472/+/steps/clang/0/steps/test/0/stdout</a></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 5, 2020 at 6:46 AM John Brawn via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Also, despite these tests now using the host triple they only get run when the<br>
X86 target is built (because test/DebugInfo/X86/lit.local.cfg makes them<br>
unsupported when it's not), so these failures aren't showing up in the AArch64<br>
buildbots (e.g. <a href="http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick</a>)<br>
because they don't build the X86 target.<br>
<br>
John<br>
<br>
> -----Original Message-----<br>
> From: llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a>] On<br>
> Behalf Of John Brawn via llvm-commits<br>
> Sent: 05 February 2020 14:28<br>
> To: David Blaikie<br>
> Cc: <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> Subject: RE: [llvm] cd9142e - DebugInfo: Generalize<br>
> test/DebugInfo/X86/convert-linked.ll to run with different architectures<br>
> <br>
> This test, and convert-debugloc test from commit<br>
> efcd3967a6bf6b66e04e40129104d0b65ba453d2,<br>
> are now failing on AArch64:<br>
> <br>
> llvm/test/DebugInfo/X86/convert-linked.ll:5:15: error: CHECK-NEXT:<br>
> expected string not found in input<br>
> ; CHECK-NEXT: DW_ATE_signed_8<br>
> ^<br>
> <stdin>:43:2: note: scanning from here<br>
> DW_AT_name ("signed char")<br>
> ^<br>
> <stdin>:44:18: note: possible intended match here<br>
> DW_AT_encoding (DW_ATE_signed_char)<br>
> ^<br>
> <br>
> I think this is due to AArch64 using GlobalISel at -O0: looking at the<br>
> llc debug<br>
> output, the location information in DBG_VALUE ends up being $noreg for<br>
> some reason<br>
> so no DW_AT_location is emitted. Changing to -O1 makes the failure go<br>
> away (though I<br>
> don’t know if that's the right way to fix the test).<br>
> <br>
> John<br>
> <br>
> > -----Original Message-----<br>
> > From: llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a>] On<br>
> > Behalf Of David Blaikie via llvm-commits<br>
> > Sent: 05 February 2020 02:03<br>
> > To: <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> > Subject: [llvm] cd9142e - DebugInfo: Generalize<br>
> > test/DebugInfo/X86/convert-linked.ll to run with different<br>
> architectures<br>
> ><br>
> ><br>
> > Author: David Blaikie<br>
> > Date: 2020-02-04T18:02:03-08:00<br>
> > New Revision: cd9142ed8a46e3ffa199176a5f447fc1a4e1c4d1<br>
> ><br>
> > URL: <a href="https://github.com/llvm/llvm-" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-</a><br>
> > project/commit/cd9142ed8a46e3ffa199176a5f447fc1a4e1c4d1<br>
> > DIFF: <a href="https://github.com/llvm/llvm-" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-</a><br>
> > project/commit/cd9142ed8a46e3ffa199176a5f447fc1a4e1c4d1.diff<br>
> ><br>
> > LOG: DebugInfo: Generalize test/DebugInfo/X86/convert-linked.ll to run<br>
> > with different architectures<br>
> ><br>
> > Added:<br>
> ><br>
> ><br>
> > Modified:<br>
> > llvm/test/DebugInfo/X86/convert-linked.ll<br>
> ><br>
> > Removed:<br>
> ><br>
> ><br>
> ><br>
> ><br>
> ########################################################################<br>
> > ########<br>
> > diff --git a/llvm/test/DebugInfo/X86/convert-linked.ll<br>
> > b/llvm/test/DebugInfo/X86/convert-linked.ll<br>
> > index 8d277d8649e1..1f27d3f74053 100644<br>
> > --- a/llvm/test/DebugInfo/X86/convert-linked.ll<br>
> > +++ b/llvm/test/DebugInfo/X86/convert-linked.ll<br>
> > @@ -1,4 +1,4 @@<br>
> > -; RUN: llc -filetype=obj -O0 < %s | llvm-dwarfdump - | FileCheck %s<br>
> > +; RUN: %llc_dwarf -filetype=obj -O0 < %s | llvm-dwarfdump - |<br>
> FileCheck<br>
> > %s<br>
> ><br>
> > ; CHECK: DW_TAG_compile_unit<br>
> > ; CHECK: [[CU0BT0:0x[0-9a-f]+]]: DW_TAG_base_type<br>
> > @@ -16,11 +16,6 @@<br>
> > ; CHECK: DW_TAG_variable<br>
> > ; CHECK: DW_OP_convert ([[CU1BT0]]) "DW_ATE_signed_8", DW_OP_convert<br>
> > ([[CU1BT1]]) "DW_ATE_signed_16"<br>
> ><br>
> > -; ModuleID = 'llvm-link'<br>
> > -source_filename = "llvm-link"<br>
> > -target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"<br>
> > -target triple = "x86_64-unknown-linux-gnu"<br>
> > -<br>
> > define dso_local signext i8 @foo(i8 signext %x) !dbg !9 {<br>
> > entry:<br>
> > call void @llvm.dbg.value(metadata i8 %x, metadata !13, metadata<br>
> > !DIExpression()), !dbg !14<br>
> ><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > llvm-commits mailing list<br>
> > <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> > <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>
</blockquote></div>
</blockquote></div>