<div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:9pt" ><div dir="ltr" >Done.</div>
<div dir="ltr" > </div>
<div dir="ltr" >Git hash: 61368c8</div>
<div dir="ltr" > </div>
<div dir="ltr" ><div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div dir="ltr" ><font face="Verdana,Arial,Helvetica,sans-serif" size="2" ><font face="Verdana,Arial,Helvetica,sans-serif" size="2" ><span style="font-family:Arial,Helvetica,sans-serif;" ><font size="2" ><span style="font-size:0.857em;" >Kit Barton, Ph.D.<br>STSM, Technical lead for LLVM on Power and XL Compilers<br>IBM Toronto Lab, C2/705/8200/MKM<br>8200 Warden Ave, Markham, L6G 1C7<br>(905) 413-3452<br>kbarton@ca.ibm.com</span></font></span></font></font></div></div></div></div></div></div>
<div dir="ltr" > </div>
<div dir="ltr" > </div>
<blockquote data-history-content-modified="1" dir="ltr" style="border-left:solid #aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr; margin-right:0px" >----- Original message -----<br>From: Philip Reames <listmail@philipreames.com><br>To: Kit Barton <kbarton@ca.ibm.com><br>Cc: llvm-commits@lists.llvm.org, llvm-commits@meinersbur.de, llvmlistbot@llvm.org<br>Subject: [EXTERNAL] Re: [llvm] 942c994 - [Loop] Add isRotated method to Loop class.<br>Date: Wed, Dec 11, 2019 8:03 PM<br> <br><!--Notes ACF
<meta http-equiv="Content-Type" content="text/html; charset=utf8" >-->
<p>Just land it.</p>
<p>Philip</p>
<div>On 12/11/19 1:07 PM, Kit Barton wrote:</div>
<blockquote cite="mid:OF98FB3EBE.8F40CF74-ON002584CD.0073C00B-002584CD.007412AE@notes.na.collabserv.com" type="cite" ><!--Notes ACF
<meta http-equiv="content-type" content="text/html; charset=utf8" >-->
<div dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:9pt" ><div dir="ltr" >Thanks Michael and Philip for the clarification. I was going to ask the same question.</div>
<div dir="ltr" ><br>Do either of you object if I commit a fix to change the name, with an appropriate comment block? Or would you prefer I post something on Phabricator for review?</div>
<div dir="ltr" > </div>
<div dir="ltr" ><div dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div dir="ltr" ><font face="Verdana,Arial,Helvetica,sans-serif" size="2" ><font face="Verdana,Arial,Helvetica,sans-serif" size="2" ><span style="font-family:Arial,Helvetica,sans-serif;" ><font size="2" ><span style="font-size:0.857em;" >Kit Barton, Ph.D.<br>STSM, Technical lead for LLVM on Power and XL Compilers<br>IBM Toronto Lab, C2/705/8200/MKM<br>8200 Warden Ave, Markham, L6G 1C7<br>(905) 413-3452<br><a href="mailto:kbarton@ca.ibm.com" target="_blank" >kbarton@ca.ibm.com</a></span></font></span></font></font></div></div></div></div></div></div>
<div dir="ltr" > </div>
<div dir="ltr" > </div>
<blockquote data-history-content-modified="1" dir="ltr" style="border-left:solid #aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr; margin-right:0px" >----- Original message -----<br>From: Philip Reames <a href="mailto:listmail@philipreames.com" target="_blank" ><listmail@philipreames.com></a><br>To: Michael Kruse <a href="mailto:llvm-commits@meinersbur.de" target="_blank" ><llvm-commits@meinersbur.de></a><br>Cc: Kit Barton <a href="mailto:kbarton@ca.ibm.com" target="_blank" ><kbarton@ca.ibm.com></a>, Kit Barton <a href="mailto:llvmlistbot@llvm.org" target="_blank" ><llvmlistbot@llvm.org></a>, llvm-commits <a href="mailto:llvm-commits@lists.llvm.org" target="_blank" ><llvm-commits@lists.llvm.org></a><br>Subject: [EXTERNAL] Re: [llvm] 942c994 - [Loop] Add isRotated method to Loop class.<br>Date: Wed, Dec 11, 2019 3:53 PM<br>
<div><font face="Default Monospace,Courier New,Courier,monospace" size="2" >On 12/11/19 12:45 PM, Michael Kruse wrote:<br>> Am Mi., 11. Dez. 2019 um 11:11 Uhr schrieb Philip Reames via<br>> llvm-commits <a href="mailto:llvm-commits@lists.llvm.org" target="_blank" ><llvm-commits@lists.llvm.org></a>:<br>>> Can you add a more detailed method comment as to what rotated means in<br>>> this context? In particular, it doesn't imply the loop has been<br>>> rotated, it checks the form of the loop structure.<br>> By "has been rotated", do you mean that LoopRotate transformed the<br>> loop, excluding that cases where LoopRotate did not do anything or did<br>> not run?<br>> Would calling the method "isRotatedForm()" disambiguate this?<br>Yes, and yes.<br>><br>> Michael</font><br> </div></blockquote>
<div dir="ltr" > </div></div></blockquote></blockquote>
<div dir="ltr" > </div></div><BR>