<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">Just a heads-up that the lldb / debuginfo-tests bot started failing when this landed:</div><div class=""><br class=""></div><div class=""><a href="http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/4676/" class="">http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/4676/</a></div><div class=""><br class=""></div><div class=""><pre style="box-sizing: border-box; white-space: pre-wrap; word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; caret-color: rgb(51, 51, 51); color: rgb(51, 51, 51); font-size: 13px;" class="">Stack dump:
0. Program arguments: /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/clang-10 -cc1 -triple x86_64-apple-macosx10.14.0 -Wdeprecated-objc-isa-usage -Werror=deprecated-objc-isa-usage -emit-obj -mrelax-all -disable-free -main-file-name foreach.m -mrelocation-model pic -pic-level 2 -mthread-model posix -mframe-pointer=all -fno-rounding-math -masm-verbose -munwind-tables -target-sdk-version=10.14 -target-cpu penryn -dwarf-column-info -debug-info-kind=standalone -dwarf-version=4 -debugger-tuning=lldb -target-linker-version 409.12 -resource-dir /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lib/clang/10.0.99 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -internal-isystem /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/local/include -internal-isystem /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lib/clang/10.0.99/include -internal-externc-isystem /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include -O0 -fdebug-compilation-dir /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/projects/debuginfo-tests/llgdb-tests -ferror-limit 19 -fmessage-length 0 -stack-protector 1 -fblocks -fencode-extended-block-signature -fregister-global-dtors-with-atexit -fgnuc-version=4.2.1 -fobjc-runtime=macosx-10.14.0 -fobjc-exceptions -fexceptions -fmax-type-align=16 -fdiagnostics-show-option -o /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/projects/debuginfo-tests/llgdb-tests/Output/foreach.m.tmp.o -x objective-c /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/debuginfo-tests/llgdb-tests/foreach.m
1. <eof> parser at end of file
2. Code generation
0 clang-10 0x000000010a6d1785 llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 37
1 clang-10 0x000000010a6d0698 llvm::sys::RunSignalHandlers() + 248
2 clang-10 0x000000010a6d1d76 SignalHandler(int) + 262
3 libsystem_platform.dylib 0x00007fff588d1b3d _sigtramp + 29
4 clang-10 0x000000010a2d2ca0 llvm::MCObjectStreamer::EmitBytes(llvm::StringRef) + 144
5 clang-10 0x000000010a2ca553 (anonymous namespace)::MCMachOStreamer::EmitLabel(llvm::MCSymbol*, llvm::SMLoc) + 35
6 clang-10 0x000000010b1b139d llvm::DwarfDebug::emitDebugRangesImpl(llvm::DwarfFile const&, llvm::MCSection*) + 429
7 clang-10 0x000000010b1a8c58 llvm::DwarfDebug::endModule() + 376
8 clang-10 0x000000010b177d5e llvm::AsmPrinter::doFinalization(llvm::Module&) + 1998
9 clang-10 0x0000000109f51c96 llvm::FPPassManager::doFinalization(llvm::Module&) + 54
10 clang-10 0x0000000109f52206 llvm::legacy::PassManagerImpl::run(llvm::Module&) + 1334
11 clang-10 0x000000010a916cd2 clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::DataLayout const&, llvm::Module*, clang::BackendAction, std::__1::unique_ptr<llvm::raw_pwrite_stream, std::__1::default_delete<llvm::raw_pwrite_stream> >) + 13698
12 clang-10 0x000000010abda154 clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) + 1108
13 clang-10 0x000000010bc292b3 clang::ParseAST(clang::Sema&, bool, bool) + 643
14 clang-10 0x000000010aeeb4d3 clang::FrontendAction::Execute() + 99
15 clang-10 0x000000010ae7c3e3 clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) + 1619
16 clang-10 0x000000010af60a0c clang::ExecuteCompilerInvocation(clang::CompilerInstance*) + 1772
17 clang-10 0x0000000108849979 cc1_main(llvm::ArrayRef<char const*>, char const*, void*) + 2233</pre><div class=""><br class=""></div><div class="">vedant</div><div><br class=""><blockquote type="cite" class=""><div class="">On Dec 12, 2019, at 4:54 PM, David Blaikie via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><br class="">Author: David Blaikie<br class="">Date: 2019-12-12T16:53:59-08:00<br class="">New Revision: 8e04896288d22ed8bef7ac367923374f96b753d6<br class=""><br class="">URL: <a href="https://github.com/llvm/llvm-project/commit/8e04896288d22ed8bef7ac367923374f96b753d6" class="">https://github.com/llvm/llvm-project/commit/8e04896288d22ed8bef7ac367923374f96b753d6</a><br class="">DIFF: <a href="https://github.com/llvm/llvm-project/commit/8e04896288d22ed8bef7ac367923374f96b753d6.diff" class="">https://github.com/llvm/llvm-project/commit/8e04896288d22ed8bef7ac367923374f96b753d6.diff</a><br class=""><br class="">LOG: NFC: DebugInfo: Refactor RangeSpanList to be a struct, like DebugLocStream::List<br class=""><br class="">Move these data structures closer together so their emission code can<br class="">eventually share more of its implementation.<br class=""><br class="">Added: <br class=""><br class=""><br class="">Modified: <br class=""> llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp<br class=""> llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br class=""> llvm/lib/CodeGen/AsmPrinter/DwarfFile.cpp<br class=""> llvm/lib/CodeGen/AsmPrinter/DwarfFile.h<br class=""><br class="">Removed: <br class=""><br class=""><br class=""><br class="">################################################################################<br class="">diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp b/llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp<br class="">index 0f3d8c689fa0..5707f962b4be 100644<br class="">--- a/llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp<br class="">+++ b/llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp<br class="">@@ -503,10 +503,10 @@ void DwarfCompileUnit::addScopeRangeList(DIE &ScopeDIE,<br class=""> const MCSymbol *RangeSectionSym =<br class=""> TLOF.getDwarfRangesSection()->getBeginSymbol();<br class=""> if (isDwoUnit())<br class="">- addSectionDelta(ScopeDIE, dwarf::DW_AT_ranges, List.getSym(),<br class="">+ addSectionDelta(ScopeDIE, dwarf::DW_AT_ranges, List.Label,<br class=""> RangeSectionSym);<br class=""> else<br class="">- addSectionLabel(ScopeDIE, dwarf::DW_AT_ranges, List.getSym(),<br class="">+ addSectionLabel(ScopeDIE, dwarf::DW_AT_ranges, List.Label,<br class=""> RangeSectionSym);<br class=""> }<br class=""> }<br class=""><br class="">diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br class="">index aa33659cd06e..62745f9bee72 100644<br class="">--- a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br class="">+++ b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br class="">@@ -2331,7 +2331,7 @@ static MCSymbol *emitRnglistsTableHeader(AsmPrinter *Asm,<br class=""> Asm->OutStreamer->EmitLabel(Holder.getRnglistsTableBaseSym());<br class=""><br class=""> for (const RangeSpanList &List : Holder.getRangeLists())<br class="">- Asm->EmitLabelDifference(List.getSym(), Holder.getRnglistsTableBaseSym(),<br class="">+ Asm->EmitLabelDifference(List.Label, Holder.getRnglistsTableBaseSym(),<br class=""> 4);<br class=""><br class=""> return TableEnd;<br class="">@@ -2688,11 +2688,11 @@ void DwarfDebug::emitDebugARanges() {<br class=""> /// Emit a single range list. We handle both DWARF v5 and earlier.<br class=""> static void emitRangeList(DwarfDebug &DD, AsmPrinter *Asm,<br class=""> const RangeSpanList &List) {<br class="">- emitRangeList(DD, Asm, List.getSym(), List.getRanges(), List.getCU(),<br class="">+ emitRangeList(DD, Asm, List.Label, List.Ranges, *List.CU,<br class=""> dwarf::DW_RLE_base_addressx, dwarf::DW_RLE_offset_pair,<br class=""> dwarf::DW_RLE_startx_length, dwarf::DW_RLE_end_of_list,<br class=""> llvm::dwarf::RangeListEncodingString,<br class="">- List.getCU().getCUNode()->getRangesBaseAddress() ||<br class="">+ List.CU->getCUNode()->getRangesBaseAddress() ||<br class=""> DD.getDwarfVersion() >= 5,<br class=""> [](auto) {});<br class=""> }<br class="">@@ -2709,8 +2709,9 @@ void DwarfDebug::emitDebugRangesImpl(const DwarfFile &Holder, MCSection *Section<br class=""><br class=""> Asm->OutStreamer->SwitchSection(Section);<br class=""><br class="">- MCSymbol *TableEnd =<br class="">- getDwarfVersion() < 5 ? nullptr : emitRnglistsTableHeader(Asm, Holder);<br class="">+ MCSymbol *TableEnd = nullptr;<br class="">+ if (getDwarfVersion() < 5)<br class="">+ TableEnd = emitRnglistsTableHeader(Asm, Holder);<br class=""><br class=""> for (const RangeSpanList &List : Holder.getRangeLists())<br class=""> emitRangeList(*this, Asm, List);<br class=""><br class="">diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfFile.cpp b/llvm/lib/CodeGen/AsmPrinter/DwarfFile.cpp<br class="">index e3c9095d1343..e5c4db58f477 100644<br class="">--- a/llvm/lib/CodeGen/AsmPrinter/DwarfFile.cpp<br class="">+++ b/llvm/lib/CodeGen/AsmPrinter/DwarfFile.cpp<br class="">@@ -126,6 +126,6 @@ void DwarfFile::addScopeLabel(LexicalScope *LS, DbgLabel *Label) {<br class=""> std::pair<uint32_t, RangeSpanList *><br class=""> DwarfFile::addRange(const DwarfCompileUnit &CU, SmallVector<RangeSpan, 2> R) {<br class=""> CURangeLists.push_back(<br class="">- RangeSpanList(Asm->createTempSymbol("debug_ranges"), CU, std::move(R)));<br class="">+ RangeSpanList{Asm->createTempSymbol("debug_ranges"), &CU, std::move(R)});<br class=""> return std::make_pair(CURangeLists.size() - 1, &CURangeLists.back());<br class=""> }<br class=""><br class="">diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfFile.h b/llvm/lib/CodeGen/AsmPrinter/DwarfFile.h<br class="">index 35fa51fb24c4..cf293d7534d0 100644<br class="">--- a/llvm/lib/CodeGen/AsmPrinter/DwarfFile.h<br class="">+++ b/llvm/lib/CodeGen/AsmPrinter/DwarfFile.h<br class="">@@ -37,21 +37,12 @@ struct RangeSpan {<br class=""> const MCSymbol *End;<br class=""> };<br class=""><br class="">-class RangeSpanList {<br class="">-private:<br class="">+struct RangeSpanList {<br class=""> // Index for locating within the debug_range section this particular span.<br class="">- MCSymbol *RangeSym;<br class="">+ MCSymbol *Label;<br class=""> const DwarfCompileUnit *CU;<br class=""> // List of ranges.<br class=""> SmallVector<RangeSpan, 2> Ranges;<br class="">-<br class="">-public:<br class="">- RangeSpanList(MCSymbol *Sym, const DwarfCompileUnit &CU,<br class="">- SmallVector<RangeSpan, 2> Ranges)<br class="">- : RangeSym(Sym), CU(&CU), Ranges(std::move(Ranges)) {}<br class="">- MCSymbol *getSym() const { return RangeSym; }<br class="">- const DwarfCompileUnit &getCU() const { return *CU; }<br class="">- const SmallVectorImpl<RangeSpan> &getRanges() const { return Ranges; }<br class=""> };<br class=""><br class=""> class DwarfFile {<br class=""><br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></div></blockquote></div><br class=""></div></body></html>