<div dir="ltr">I'm not sure having a commented out variable is the best thing here - perhaps it should be deleted? (if "if (getThing())" is a bit unclear/unintentional, perhaps a "if (getThing() != nullptr)" would be suitable here?)</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 29, 2019 at 5:12 AM Simon Pilgrim via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Simon Pilgrim<br>
Date: 2019-10-29T12:12:28Z<br>
New Revision: ec82eb2d024a3535bc9fa1dbe36764be017381b1<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/ec82eb2d024a3535bc9fa1dbe36764be017381b1" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/ec82eb2d024a3535bc9fa1dbe36764be017381b1</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/ec82eb2d024a3535bc9fa1dbe36764be017381b1.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/ec82eb2d024a3535bc9fa1dbe36764be017381b1.diff</a><br>
<br>
LOG: Fix unused variable warning. NFCI.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/lib/CodeGen/MachineInstr.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/lib/CodeGen/MachineInstr.cpp b/llvm/lib/CodeGen/MachineInstr.cpp<br>
index e643bcfd390e..397c1239d85c 100644<br>
--- a/llvm/lib/CodeGen/MachineInstr.cpp<br>
+++ b/llvm/lib/CodeGen/MachineInstr.cpp<br>
@@ -1701,7 +1701,7 @@ void MachineInstr::print(raw_ostream &OS, ModuleSlotTracker &MST,<br>
     OS << " post-instr-symbol ";<br>
     MachineOperand::printSymbol(OS, *PostInstrSymbol);<br>
   }<br>
-  if (MDNode *HeapAllocMarker = getHeapAllocMarker()) {<br>
+  if (/*MDNode *HeapAllocMarker =*/getHeapAllocMarker()) {<br>
     if (!FirstOp) {<br>
       FirstOp = false;<br>
       OS << ',';<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>