<div dir="auto">Thanks Hans!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Nov 7, 2019, 1:32 AM Hans Wennborg <<a href="mailto:hans@chromium.org">hans@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">In Chromium it broke the build in a few configurations, so I've<br>
reverted in 5b9a072c39c.<br>
<br>
See <a href="https://bugs.chromium.org/p/chromium/issues/detail?id=1022296#c1" rel="noreferrer noreferrer" target="_blank">https://bugs.chromium.org/p/chromium/issues/detail?id=1022296#c1</a><br>
for reproducer.<br>
<br>
On Thu, Nov 7, 2019 at 3:05 AM Eric Christopher via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" rel="noreferrer">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> As a heads up we're starting to see a problem around this commit with<br>
> backtraces for inline functions with msan where the line number has<br>
> gone away (replaced with 0).<br>
><br>
> Dave is looking at it, but I thought I'd send a message as early as I could.<br>
><br>
> -eric<br>
><br>
> On Mon, Nov 4, 2019 at 3:14 PM Vedant Kumar via llvm-commits<br>
> <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" rel="noreferrer">llvm-commits@lists.llvm.org</a>> wrote:<br>
> ><br>
> ><br>
> > Author: Vedant Kumar<br>
> > Date: 2019-11-04T15:14:24-08:00<br>
> > New Revision: a5c8ec4baa2c00d8dbca36ffd236a40f9e0c07ed<br>
> ><br>
> > URL: <a href="https://github.com/llvm/llvm-project/commit/a5c8ec4baa2c00d8dbca36ffd236a40f9e0c07ed" rel="noreferrer noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/a5c8ec4baa2c00d8dbca36ffd236a40f9e0c07ed</a><br>
> > DIFF: <a href="https://github.com/llvm/llvm-project/commit/a5c8ec4baa2c00d8dbca36ffd236a40f9e0c07ed.diff" rel="noreferrer noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/a5c8ec4baa2c00d8dbca36ffd236a40f9e0c07ed.diff</a><br>
> ><br>
> > LOG: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood<br>
> ><br>
> > Currently, clang emits subprograms for declared functions when the<br>
> > target debugger or DWARF standard is known to support entry values<br>
> > (DW_OP_entry_value & the GNU equivalent).<br>
> ><br>
> > Treat DW_AT_tail_call the same way to allow debuggers to follow cross-TU<br>
> > tail calls.<br>
> ><br>
> > Pre-patch debug session with a cross-TU tail call:<br>
> ><br>
> > ```<br>
> > * frame #0: 0x0000000100000fa4 main`target at b.c:4:3 [opt]<br>
> > frame #1: 0x0000000100000f99 main`main at a.c:8:10 [opt]<br>
> > ```<br>
> ><br>
> > Post-patch (note that the tail-calling frame, "helper", is visible):<br>
> ><br>
> > ```<br>
> > * frame #0: 0x0000000100000fa4 main`target at b.c:4:3 [opt]<br>
> > frame #1: 0x0000000100000f80 main`helper [opt] [artificial]<br>
> > frame #2: 0x0000000100000f99 main`main at a.c:8:10 [opt]<br>
> > ```<br>
> ><br>
> > rdar://46577651<br>
> ><br>
> > Differential Revision: <a href="https://reviews.llvm.org/D69743" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D69743</a><br>
> ><br>
> > Added:<br>
> ><br>
> ><br>
> > Modified:<br>
> > clang/lib/CodeGen/CGDebugInfo.cpp<br>
> > clang/test/CodeGen/debug-info-extern-call.c<br>
> > clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp<br>
> > llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll<br>
> ><br>
> > Removed:<br>
> ><br>
> ><br>
> ><br>
> > ################################################################################<br>
> > diff --git a/clang/lib/CodeGen/CGDebugInfo.cpp b/clang/lib/CodeGen/CGDebugInfo.cpp<br>
> > index e0bb3fda7acf..c0c8fd3c8f16 100644<br>
> > --- a/clang/lib/CodeGen/CGDebugInfo.cpp<br>
> > +++ b/clang/lib/CodeGen/CGDebugInfo.cpp<br>
> > @@ -3748,9 +3748,7 @@ void CGDebugInfo::EmitFunctionDecl(GlobalDecl GD, SourceLocation Loc,<br>
> > void CGDebugInfo::EmitFuncDeclForCallSite(llvm::CallBase *CallOrInvoke,<br>
> > QualType CalleeType,<br>
> > const FunctionDecl *CalleeDecl) {<br>
> > - auto &CGOpts = CGM.getCodeGenOpts();<br>
> > - if (!CGOpts.EnableDebugEntryValues || !CGM.getLangOpts().Optimize ||<br>
> > - !CallOrInvoke)<br>
> > + if (!CallOrInvoke || getCallSiteRelatedAttrs() == llvm::DINode::FlagZero)<br>
> > return;<br>
> ><br>
> > auto *Func = CallOrInvoke->getCalledFunction();<br>
> > @@ -4824,10 +4822,10 @@ llvm::DINode::DIFlags CGDebugInfo::getCallSiteRelatedAttrs() const {<br>
> > bool SupportsDWARFv4Ext =<br>
> > CGM.getCodeGenOpts().DwarfVersion == 4 &&<br>
> > (CGM.getCodeGenOpts().getDebuggerTuning() == llvm::DebuggerKind::LLDB ||<br>
> > - (CGM.getCodeGenOpts().EnableDebugEntryValues &&<br>
> > - CGM.getCodeGenOpts().getDebuggerTuning() == llvm::DebuggerKind::GDB));<br>
> > + CGM.getCodeGenOpts().getDebuggerTuning() == llvm::DebuggerKind::GDB);<br>
> ><br>
> > - if (!SupportsDWARFv4Ext && CGM.getCodeGenOpts().DwarfVersion < 5)<br>
> > + if (!SupportsDWARFv4Ext && CGM.getCodeGenOpts().DwarfVersion < 5 &&<br>
> > + !CGM.getCodeGenOpts().EnableDebugEntryValues)<br>
> > return llvm::DINode::FlagZero;<br>
> ><br>
> > return llvm::DINode::FlagAllCallsDescribed;<br>
> ><br>
> > diff --git a/clang/test/CodeGen/debug-info-extern-call.c b/clang/test/CodeGen/debug-info-extern-call.c<br>
> > index e35669b78f93..7f58fe59a635 100644<br>
> > --- a/clang/test/CodeGen/debug-info-extern-call.c<br>
> > +++ b/clang/test/CodeGen/debug-info-extern-call.c<br>
> > @@ -1,8 +1,21 @@<br>
> > -// RUN: %clang -Xclang -femit-debug-entry-values -g -O2 -target x86_64-none-linux-gnu -S -emit-llvm %s -o - | FileCheck %s -check-prefix=CHECK-EXT<br>
> > -// CHECK-EXT: !DISubprogram(name: "fn1"<br>
> > +// When entry values are emitted, expect a subprogram for extern decls so that<br>
> > +// the dwarf generator can describe call site parameters at extern call sites.<br>
> > +//<br>
> > +// RUN: %clang -Xclang -femit-debug-entry-values -g -O2 -target x86_64-none-linux-gnu -S -emit-llvm %s -o - | FileCheck %s -check-prefix=ENTRY-VAL<br>
> > +// ENTRY-VAL: !DISubprogram(name: "fn1"<br>
> ><br>
> > -// RUN: %clang -g -O2 -target x86_64-none-linux-gnu -S -emit-llvm %s -o - | FileCheck %s<br>
> > -// CHECK-NOT: !DISubprogram(name: "fn1"<br>
> > +// Similarly, when the debugger tuning is gdb, expect a subprogram for extern<br>
> > +// decls so that the dwarf generator can describe information needed for tail<br>
> > +// call frame reconstrution.<br>
> > +//<br>
> > +// RUN: %clang -g -O2 -target x86_64-none-linux-gnu -ggdb -S -emit-llvm %s -o - | FileCheck %s -check-prefix=GDB<br>
> > +// GDB: !DISubprogram(name: "fn1"<br>
> > +//<br>
> > +// Do not emit a subprogram for extern decls when entry values are disabled and<br>
> > +// the tuning is not set to gdb.<br>
> > +//<br>
> > +// RUN: %clang -g -O2 -target x86_64-none-linux-gnu -gsce -S -emit-llvm %s -o - | FileCheck %s -check-prefix=SCE<br>
> > +// SCE-NOT: !DISubprogram(name: "fn1"<br>
> ><br>
> > extern int fn1(int a, int b);<br>
> ><br>
> ><br>
> > diff --git a/clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp b/clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp<br>
> > index 1cb2b6c609f3..667c2469b55e 100644<br>
> > --- a/clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp<br>
> > +++ b/clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp<br>
> > @@ -56,6 +56,7 @@<br>
> ><br>
> > // NO-ATTR-NOT: FlagAllCallsDescribed<br>
> ><br>
> > +// HAS-ATTR-DAG: DISubprogram(name: "declaration1", {{.*}}, flags: DIFlagPrototyped<br>
> > // HAS-ATTR-DAG: DISubprogram(name: "declaration2", {{.*}}, flags: DIFlagPrototyped | DIFlagAllCallsDescribed, spFlags: DISPFlagDefinition<br>
> > // HAS-ATTR-DAG: DISubprogram(name: "struct1", {{.*}}, flags: DIFlagPrototyped, spFlags: DISPFlagOptimized)<br>
> > // HAS-ATTR-DAG: DISubprogram(name: "struct1", {{.*}}, flags: DIFlagPrototyped | DIFlagAllCallsDescribed, spFlags: DISPFlagDefinition<br>
> ><br>
> > diff --git a/llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll b/llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll<br>
> > index c37ce1eb7fbe..33e06faba57b 100644<br>
> > --- a/llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll<br>
> > +++ b/llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll<br>
> > @@ -25,6 +25,14 @@<br>
> ><br>
> > @sink = global i32 0, align 4, !dbg !0<br>
> ><br>
> > +define void @__has_no_subprogram() {<br>
> > +entry:<br>
> > + %0 = load volatile i32, i32* @sink, align 4<br>
> > + %inc = add nsw i32 %0, 1<br>
> > + store volatile i32 %inc, i32* @sink, align 4<br>
> > + ret void<br>
> > +}<br>
> > +<br>
> > ; ASM: DW_TAG_subprogram<br>
> > ; ASM: DW_AT_call_all_calls<br>
> > ; OBJ: [[bat_sp:.*]]: DW_TAG_subprogram<br>
> > @@ -70,6 +78,7 @@ entry:<br>
> > ; OBJ: DW_AT_call_tail_call<br>
> > define void @_Z3foov() !dbg !25 {<br>
> > entry:<br>
> > + tail call void @__has_no_subprogram()<br>
> > tail call void @_Z3barv(), !dbg !26<br>
> > tail call void @_Z3batv(), !dbg !27<br>
> > tail call void @_Z3barv(), !dbg !26<br>
> ><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > llvm-commits mailing list<br>
> > <a href="mailto:llvm-commits@lists.llvm.org" target="_blank" rel="noreferrer">llvm-commits@lists.llvm.org</a><br>
> > <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank" rel="noreferrer">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>