<div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Oct 5, 2019 at 4:55 AM James Molloy via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Steven,<div><br></div><div>I've committed r373820 to hopefully fix this. I spent some time trying to reproduce it first, but I can't install anything prior to gcc-6 on my system (through the package manager) and that doesn't show the bug. Hopefully this fixes your bots.</div></div></blockquote><div>Thanks James for looking into this. It seems that the same pattern shows up in a TableGen generated file.</div><div><br></div><div>For example, `unittests/TableGen/AutomataAutomata.inc` line 9766:<br>```<br> {1, {SK_a, SK_b, "yeet"}, 2, 0},<br>```</div><div><br></div><div>-- HT<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>Cheers,</div><div><br></div><div>James</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 4 Oct 2019 at 20:46, James Molloy <<a href="mailto:jmolloy@google.com" target="_blank">jmolloy@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto">Hi Steven,<div dir="auto"><br></div><div dir="auto">Thanks for reporting this. The fix looks trivial, I shall commit it tomorrow morning GMT time. </div><div dir="auto"><br></div><div dir="auto">It's interesting that GCC thinks the selected constructor is explicit. I'll double check the expected behaviour here (but I can simply fix by making the type explicit).</div><div dir="auto"><br></div><div dir="auto">James</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 4 Oct 2019, 20:23 Steven Wan via Phabricator, <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">stevewan added a comment.<br>
<br>
Hi,<br>
<br>
This is breaking our internal build bots with gcc version 5.4.0. Sample error is as follows,<br>
<br>
/home/docker/llvm-project/llvm/unittests/TableGen/AutomataTest.cpp: In member function ‘virtual void Automata_TupleAutomatonAccepts_Test::TestBody()’:<br>
/home/docker/llvm-project/llvm/unittests/TableGen/AutomataTest.cpp:65:33: error: converting to ‘const std::tuple<SymKind, SymKind, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >’ from initializer list would use explicit constructor ‘constexpr std::tuple< <template-parameter-1-1> >::tuple(_UElements&& ...) [with _UElements = {SymKind, SymKind, const char (&)[5]}; <template-parameter-2-2> = void; _Elements = {SymKind, SymKind, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >}]’<br>
A.add({SK_a, SK_b, "yeet"}));<br>
^<br>
<br>
Please let us know regarding timeline for a fix. Thanks!<br>
<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D67968/new/" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D67968/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D67968" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D67968</a><br>
<br>
<br>
<br>
</blockquote></div>
</blockquote></div>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>