<div dir="ltr">I'm on it.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Sep 27, 2019 at 3:11 PM Nico Weber via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">thakis added a comment.<br>
<br>
This upsets gcc: <a href="http://lab.llvm.org:8011/builders/lld-x86_64-ubuntu-fast/builds/6437/steps/build-unified-tree/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/lld-x86_64-ubuntu-fast/builds/6437/steps/build-unified-tree/logs/stdio</a><br>
<br>
  /home/buildbot/as-builder-4/lld-x86_64-ubuntu-fast/llvm/unittests/tools/llvm-exegesis/X86/SnippetRepetitorTest.cpp:66:27: error: declaration of ‘std::unique_ptr<llvm::Module> llvm::exegesis::{anonymous}::X86SnippetRepetitorTest::Module’ [-fpermissive]<br>
     std::unique_ptr<Module> Module;<br>
                             ^~~~~~<br>
  In file included from /home/buildbot/as-builder-4/lld-x86_64-ubuntu-fast/llvm/include/llvm/Analysis/TargetLibraryInfo.h:17:0,<br>
                   from /home/buildbot/as-builder-4/lld-x86_64-ubuntu-fast/llvm/include/llvm/Analysis/AliasAnalysis.h:45,<br>
                   from /home/buildbot/as-builder-4/lld-x86_64-ubuntu-fast/llvm/include/llvm/CodeGen/MachineInstr.h:23,<br>
                   from /home/buildbot/as-builder-4/lld-x86_64-ubuntu-fast/llvm/include/llvm/CodeGen/MachineBasicBlock.h:21,<br>
                   from /home/buildbot/as-builder-4/lld-x86_64-ubuntu-fast/llvm/include/llvm/CodeGen/MachineFunction.h:30,<br>
                   from /home/buildbot/as-builder-4/lld-x86_64-ubuntu-fast/llvm/tools/llvm-exegesis/lib/Assembler.h:23,<br>
                   from /home/buildbot/as-builder-4/lld-x86_64-ubuntu-fast/llvm/unittests/tools/llvm-exegesis/X86/../Common/AssemblerUtils.h:12,<br>
                   from /home/buildbot/as-builder-4/lld-x86_64-ubuntu-fast/llvm/unittests/tools/llvm-exegesis/X86/SnippetRepetitorTest.cpp:9:<br>
  /home/buildbot/as-builder-4/lld-x86_64-ubuntu-fast/llvm/include/llvm/IR/Module.h:65:7: error: changes meaning of ‘Module’ from ‘class llvm::Module’ [-fpermissive]<br>
   class Module {<br>
         ^~~~~~<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D68125/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D68125/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D68125" rel="noreferrer" target="_blank">https://reviews.llvm.org/D68125</a><br>
<br>
<br>
<br>
</blockquote></div>