<div dir="ltr">Reverted: <a href="https://reviews.llvm.org/rL372125">https://reviews.llvm.org/rL372125</a><div>But the test failure points to rather other commit -> relanded this commit.</div><div><br></div><div>More details: <a href="https://reviews.llvm.org/D67658">https://reviews.llvm.org/D67658</a><br><div><br></div><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">ut 17. 9. 2019 o 19:33 Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com">lebedev.ri@gmail.com</a>> napísal(a):<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Sep 17, 2019 at 8:10 PM David Bolvansky via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: xbolva00<br>
> Date: Tue Sep 17 10:12:24 2019<br>
> New Revision: 372142<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=372142&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=372142&view=rev</a><br>
> Log:<br>
> Reland "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)"<br>
Commit message does not mention anything about the revert, or why it's<br>
being recommitted.<br>
<br>
> Modified:<br>
>     llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp<br>
>     llvm/trunk/test/Transforms/InstCombine/strncpy-1.ll<br>
><br>
> Modified: llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp?rev=372142&r1=372141&r2=372142&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp?rev=372142&r1=372141&r2=372142&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp Tue Sep 17 10:12:24 2019<br>
> @@ -610,7 +610,10 @@ Value *LibCallSimplifier::optimizeStrNCp<br>
><br>
>    if (SrcLen == 0) {<br>
>      // strncpy(x, "", y) -> memset(align 1 x, '\0', y)<br>
> -    B.CreateMemSet(Dst, B.getInt8('\0'), Size, 1);<br>
> +    CallInst *NewCI = B.CreateMemSet(Dst, B.getInt8('\0'), Size, 1);<br>
> +    AttrBuilder ArgAttrs(CI->getAttributes().getParamAttributes(0));<br>
> +    NewCI->setAttributes(NewCI->getAttributes().addParamAttributes(<br>
> +        CI->getContext(), 0, ArgAttrs));<br>
>      return Dst;<br>
>    }<br>
><br>
><br>
> Modified: llvm/trunk/test/Transforms/InstCombine/strncpy-1.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/strncpy-1.ll?rev=372142&r1=372141&r2=372142&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/strncpy-1.ll?rev=372142&r1=372141&r2=372142&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/Transforms/InstCombine/strncpy-1.ll (original)<br>
> +++ llvm/trunk/test/Transforms/InstCombine/strncpy-1.ll Tue Sep 17 10:12:24 2019<br>
> @@ -134,6 +134,16 @@ define i8* @test2(i8* %dst) {<br>
>    ret i8* %ret<br>
>  }<br>
><br>
> +define i8* @test3(i8* %dst, i32 %n) {<br>
> +; CHECK-LABEL: @test3(<br>
> +; CHECK-NEXT:    call void @llvm.memset.p0i8.i32(i8* noalias nonnull align 1 dereferenceable(5) [[DST:%.*]], i8 0, i32 5, i1 false)<br>
> +; CHECK-NEXT:    ret i8* [[DST]]<br>
> +;<br>
> +  %src = getelementptr [1 x i8], [1 x i8]* @null, i32 0, i32 0<br>
> +  %ret = call i8* @strncpy(i8* noalias nonnull %dst, i8* nonnull %src, i32 5);<br>
> +  ret i8* %ret<br>
> +}<br>
> +<br>
>  ; Check cases that shouldn't be simplified.<br>
><br>
>  define void @test_no_simplify1() {<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>