<div dir="ltr"><div>There's a terrible typo here:</div><div>"There are 4 commuted variants for each of smin/smax/umin/umax</div><div>
that are not matched here."<br></div><div><br></div><div>Should be:<br></div><div>"There are 4 commuted variants for each of smin/smax/umin/umax<br>
that *are* matched here." </div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 20, 2019 at 9:38 AM Sanjay Patel via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: spatel<br>
Date: Tue Aug 20 06:39:17 2019<br>
New Revision: 369386<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=369386&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=369386&view=rev</a><br>
Log:<br>
[InstCombine] simplify min/max of min/max with same operands (PR35607)<br>
<br>
This is the original integer variant requested in:<br>
<a href="https://bugs.llvm.org/show_bug.cgi?id=35607" rel="noreferrer" target="_blank">https://bugs.llvm.org/show_bug.cgi?id=35607</a><br>
<br>
As noted in the TODO and several similar TODOs around this block,<br>
we could do this in instsimplify, but then it would cost more<br>
because we would be trying to match min/max via ValueTracking<br>
in 2 different places.<br>
<br>
There are 4 commuted variants for each of smin/smax/umin/umax<br>
that are not matched here. There are also icmp predicate variants<br>
that are not included in the affected test file because they are<br>
already handled by instsimplify by folding the final icmp to<br>
true/false.<br>
<br>
<a href="https://rise4fun.com/Alive/3KVc" rel="noreferrer" target="_blank">https://rise4fun.com/Alive/3KVc</a><br>
<br>
Name: smax(smax, smin)<br>
%c1 = icmp slt i32 %x, %y<br>
%c2 = icmp slt i32 %y, %x<br>
%min = select i1 %c1, i32 %x, i32 %y<br>
%max = select i1 %c2, i32 %x, i32 %y<br>
%c3 = icmp sgt i32 %max, %min<br>
%r = select i1 %c3, i32 %max, i32 %min<br>
=><br>
%r = %max<br>
<br>
Name: smin(smax, smin)<br>
%c1 = icmp slt i32 %x, %y<br>
%c2 = icmp slt i32 %y, %x<br>
%min = select i1 %c1, i32 %x, i32 %y<br>
%max = select i1 %c2, i32 %x, i32 %y<br>
%c3 = icmp sgt i32 %max, %min<br>
%r = select i1 %c3, i32 %min, i32 %max<br>
=><br>
%r = %min<br>
<br>
Name: umax(umax, umin)<br>
%c1 = icmp ult i32 %x, %y<br>
%c2 = icmp ult i32 %y, %x<br>
%min = select i1 %c1, i32 %x, i32 %y<br>
%max = select i1 %c2, i32 %x, i32 %y<br>
%c3 = icmp ult i32 %min, %max<br>
%r = select i1 %c3, i32 %max, i32 %min<br>
=><br>
%r = %max<br>
<br>
Name: umin(umax, umin)<br>
%c1 = icmp ult i32 %x, %y<br>
%c2 = icmp ult i32 %y, %x<br>
%min = select i1 %c1, i32 %x, i32 %y<br>
%max = select i1 %c2, i32 %x, i32 %y<br>
%c3 = icmp ult i32 %min, %max<br>
%r = select i1 %c3, i32 %min, i32 %max<br>
=><br>
%r = %min<br>
<br>
Modified:<br>
llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp<br>
llvm/trunk/test/Transforms/InstCombine/minmax-of-minmax.ll<br>
<br>
Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp?rev=369386&r1=369385&r2=369386&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp?rev=369386&r1=369385&r2=369386&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp Tue Aug 20 06:39:17 2019<br>
@@ -1457,6 +1457,16 @@ Instruction *InstCombiner::foldSPFofSPF(<br>
}<br>
}<br>
<br>
+ // max(max(A, B), min(A, B)) --> max(A, B)<br>
+ // min(min(A, B), max(A, B)) --> min(A, B)<br>
+ // TODO: This could be done in instsimplify.<br>
+ if (SPF1 == SPF2 &&<br>
+ ((SPF1 == SPF_UMIN && match(C, m_c_UMax(m_Specific(A), m_Specific(B)))) ||<br>
+ (SPF1 == SPF_SMIN && match(C, m_c_SMax(m_Specific(A), m_Specific(B)))) ||<br>
+ (SPF1 == SPF_UMAX && match(C, m_c_UMin(m_Specific(A), m_Specific(B)))) ||<br>
+ (SPF1 == SPF_SMAX && match(C, m_c_SMin(m_Specific(A), m_Specific(B))))))<br>
+ return replaceInstUsesWith(Outer, Inner);<br>
+<br>
// ABS(ABS(X)) -> ABS(X)<br>
// NABS(NABS(X)) -> NABS(X)<br>
// TODO: This could be done in instsimplify.<br>
<br>
Modified: llvm/trunk/test/Transforms/InstCombine/minmax-of-minmax.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/minmax-of-minmax.ll?rev=369386&r1=369385&r2=369386&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/minmax-of-minmax.ll?rev=369386&r1=369385&r2=369386&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/Transforms/InstCombine/minmax-of-minmax.ll (original)<br>
+++ llvm/trunk/test/Transforms/InstCombine/minmax-of-minmax.ll Tue Aug 20 06:39:17 2019<br>
@@ -3,13 +3,9 @@<br>
<br>
define i32 @smax_of_smax_smin_commute0(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @smax_of_smax_smin_commute0(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp slt i32 [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MIN:%.*]] = select i1 [[CMP1]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i32 [[Y]], [[X]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i32 [[Y:%.*]], [[X:%.*]]<br>
; CHECK-NEXT: [[MAX:%.*]] = select i1 [[CMP2]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp sgt i32 [[MAX]], [[MIN]]<br>
-; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP3]], i32 [[MAX]], i32 [[MIN]]<br>
-; CHECK-NEXT: ret i32 [[R]]<br>
+; CHECK-NEXT: ret i32 [[MAX]]<br>
;<br>
%cmp1 = icmp slt i32 %x, %y<br>
%min = select i1 %cmp1, i32 %x, i32 %y<br>
@@ -22,13 +18,9 @@ define i32 @smax_of_smax_smin_commute0(i<br>
<br>
define i32 @smax_of_smax_smin_commute1(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @smax_of_smax_smin_commute1(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp sgt i32 [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MIN:%.*]] = select i1 [[CMP1]], i32 [[Y]], i32 [[X]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp sgt i32 [[X]], [[Y]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp sgt i32 [[X:%.*]], [[Y:%.*]]<br>
; CHECK-NEXT: [[MAX:%.*]] = select i1 [[CMP2]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp sgt i32 [[MAX]], [[MIN]]<br>
-; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP3]], i32 [[MAX]], i32 [[MIN]]<br>
-; CHECK-NEXT: ret i32 [[R]]<br>
+; CHECK-NEXT: ret i32 [[MAX]]<br>
;<br>
%cmp1 = icmp sgt i32 %x, %y<br>
%min = select i1 %cmp1, i32 %y, i32 %x<br>
@@ -41,13 +33,9 @@ define i32 @smax_of_smax_smin_commute1(i<br>
<br>
define i32 @smax_of_smax_smin_commute2(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @smax_of_smax_smin_commute2(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp slt i32 [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MIN:%.*]] = select i1 [[CMP1]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i32 [[Y]], [[X]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i32 [[Y:%.*]], [[X:%.*]]<br>
; CHECK-NEXT: [[MAX:%.*]] = select i1 [[CMP2]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp slt i32 [[MIN]], [[MAX]]<br>
-; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP3]], i32 [[MAX]], i32 [[MIN]]<br>
-; CHECK-NEXT: ret i32 [[R]]<br>
+; CHECK-NEXT: ret i32 [[MAX]]<br>
;<br>
%cmp1 = icmp slt i32 %x, %y<br>
%min = select i1 %cmp1, i32 %x, i32 %y<br>
@@ -60,13 +48,9 @@ define i32 @smax_of_smax_smin_commute2(i<br>
<br>
define <2 x i32> @smax_of_smax_smin_commute3(<2 x i32> %x, <2 x i32> %y) {<br>
; CHECK-LABEL: @smax_of_smax_smin_commute3(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp sgt <2 x i32> [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MIN:%.*]] = select <2 x i1> [[CMP1]], <2 x i32> [[Y]], <2 x i32> [[X]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp sgt <2 x i32> [[X]], [[Y]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp sgt <2 x i32> [[X:%.*]], [[Y:%.*]]<br>
; CHECK-NEXT: [[MAX:%.*]] = select <2 x i1> [[CMP2]], <2 x i32> [[X]], <2 x i32> [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp slt <2 x i32> [[MIN]], [[MAX]]<br>
-; CHECK-NEXT: [[R:%.*]] = select <2 x i1> [[CMP3]], <2 x i32> [[MAX]], <2 x i32> [[MIN]]<br>
-; CHECK-NEXT: ret <2 x i32> [[R]]<br>
+; CHECK-NEXT: ret <2 x i32> [[MAX]]<br>
;<br>
%cmp1 = icmp sgt <2 x i32> %x, %y<br>
%min = select <2 x i1> %cmp1, <2 x i32> %y, <2 x i32> %x<br>
@@ -79,13 +63,9 @@ define <2 x i32> @smax_of_smax_smin_comm<br>
<br>
define i32 @smin_of_smin_smax_commute0(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @smin_of_smin_smax_commute0(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp sgt i32 [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MAX:%.*]] = select i1 [[CMP1]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp sgt i32 [[Y]], [[X]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp sgt i32 [[Y:%.*]], [[X:%.*]]<br>
; CHECK-NEXT: [[MIN:%.*]] = select i1 [[CMP2]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp sgt i32 [[MAX]], [[MIN]]<br>
-; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP3]], i32 [[MIN]], i32 [[MAX]]<br>
-; CHECK-NEXT: ret i32 [[R]]<br>
+; CHECK-NEXT: ret i32 [[MIN]]<br>
;<br>
%cmp1 = icmp sgt i32 %x, %y<br>
%max = select i1 %cmp1, i32 %x, i32 %y<br>
@@ -98,13 +78,9 @@ define i32 @smin_of_smin_smax_commute0(i<br>
<br>
define i32 @smin_of_smin_smax_commute1(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @smin_of_smin_smax_commute1(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp slt i32 [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MAX:%.*]] = select i1 [[CMP1]], i32 [[Y]], i32 [[X]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i32 [[X]], [[Y]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i32 [[X:%.*]], [[Y:%.*]]<br>
; CHECK-NEXT: [[MIN:%.*]] = select i1 [[CMP2]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp sgt i32 [[MAX]], [[MIN]]<br>
-; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP3]], i32 [[MIN]], i32 [[MAX]]<br>
-; CHECK-NEXT: ret i32 [[R]]<br>
+; CHECK-NEXT: ret i32 [[MIN]]<br>
;<br>
%cmp1 = icmp slt i32 %x, %y<br>
%max = select i1 %cmp1, i32 %y, i32 %x<br>
@@ -117,13 +93,9 @@ define i32 @smin_of_smin_smax_commute1(i<br>
<br>
define <2 x i32> @smin_of_smin_smax_commute2(<2 x i32> %x, <2 x i32> %y) {<br>
; CHECK-LABEL: @smin_of_smin_smax_commute2(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp sgt <2 x i32> [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MAX:%.*]] = select <2 x i1> [[CMP1]], <2 x i32> [[X]], <2 x i32> [[Y]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp slt <2 x i32> [[X]], [[Y]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp slt <2 x i32> [[X:%.*]], [[Y:%.*]]<br>
; CHECK-NEXT: [[MIN:%.*]] = select <2 x i1> [[CMP2]], <2 x i32> [[X]], <2 x i32> [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp slt <2 x i32> [[MIN]], [[MAX]]<br>
-; CHECK-NEXT: [[R:%.*]] = select <2 x i1> [[CMP3]], <2 x i32> [[MIN]], <2 x i32> [[MAX]]<br>
-; CHECK-NEXT: ret <2 x i32> [[R]]<br>
+; CHECK-NEXT: ret <2 x i32> [[MIN]]<br>
;<br>
%cmp1 = icmp sgt <2 x i32> %x, %y<br>
%max = select <2 x i1> %cmp1, <2 x i32> %x, <2 x i32> %y<br>
@@ -136,13 +108,9 @@ define <2 x i32> @smin_of_smin_smax_comm<br>
<br>
define i32 @smin_of_smin_smax_commute3(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @smin_of_smin_smax_commute3(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp slt i32 [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MAX:%.*]] = select i1 [[CMP1]], i32 [[Y]], i32 [[X]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp sgt i32 [[Y]], [[X]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp sgt i32 [[Y:%.*]], [[X:%.*]]<br>
; CHECK-NEXT: [[MIN:%.*]] = select i1 [[CMP2]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp slt i32 [[MIN]], [[MAX]]<br>
-; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP3]], i32 [[MIN]], i32 [[MAX]]<br>
-; CHECK-NEXT: ret i32 [[R]]<br>
+; CHECK-NEXT: ret i32 [[MIN]]<br>
;<br>
%cmp1 = icmp slt i32 %x, %y<br>
%max = select i1 %cmp1, i32 %y, i32 %x<br>
@@ -155,13 +123,9 @@ define i32 @smin_of_smin_smax_commute3(i<br>
<br>
define i32 @umax_of_umax_umin_commute0(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @umax_of_umax_umin_commute0(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i32 [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MIN:%.*]] = select i1 [[CMP1]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp ult i32 [[Y]], [[X]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp ult i32 [[Y:%.*]], [[X:%.*]]<br>
; CHECK-NEXT: [[MAX:%.*]] = select i1 [[CMP2]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp ugt i32 [[MAX]], [[MIN]]<br>
-; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP3]], i32 [[MAX]], i32 [[MIN]]<br>
-; CHECK-NEXT: ret i32 [[R]]<br>
+; CHECK-NEXT: ret i32 [[MAX]]<br>
;<br>
%cmp1 = icmp ult i32 %x, %y<br>
%min = select i1 %cmp1, i32 %x, i32 %y<br>
@@ -174,13 +138,9 @@ define i32 @umax_of_umax_umin_commute0(i<br>
<br>
define i32 @umax_of_umax_umin_commute1(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @umax_of_umax_umin_commute1(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp ugt i32 [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MIN:%.*]] = select i1 [[CMP1]], i32 [[Y]], i32 [[X]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp ugt i32 [[X]], [[Y]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp ugt i32 [[X:%.*]], [[Y:%.*]]<br>
; CHECK-NEXT: [[MAX:%.*]] = select i1 [[CMP2]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp ugt i32 [[MAX]], [[MIN]]<br>
-; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP3]], i32 [[MAX]], i32 [[MIN]]<br>
-; CHECK-NEXT: ret i32 [[R]]<br>
+; CHECK-NEXT: ret i32 [[MAX]]<br>
;<br>
%cmp1 = icmp ugt i32 %x, %y<br>
%min = select i1 %cmp1, i32 %y, i32 %x<br>
@@ -193,13 +153,9 @@ define i32 @umax_of_umax_umin_commute1(i<br>
<br>
define i32 @umax_of_umax_umin_commute2(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @umax_of_umax_umin_commute2(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i32 [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MIN:%.*]] = select i1 [[CMP1]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp ult i32 [[Y]], [[X]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp ult i32 [[Y:%.*]], [[X:%.*]]<br>
; CHECK-NEXT: [[MAX:%.*]] = select i1 [[CMP2]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp ult i32 [[MIN]], [[MAX]]<br>
-; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP3]], i32 [[MAX]], i32 [[MIN]]<br>
-; CHECK-NEXT: ret i32 [[R]]<br>
+; CHECK-NEXT: ret i32 [[MAX]]<br>
;<br>
%cmp1 = icmp ult i32 %x, %y<br>
%min = select i1 %cmp1, i32 %x, i32 %y<br>
@@ -212,13 +168,9 @@ define i32 @umax_of_umax_umin_commute2(i<br>
<br>
define <2 x i32> @umax_of_umax_umin_commute3(<2 x i32> %x, <2 x i32> %y) {<br>
; CHECK-LABEL: @umax_of_umax_umin_commute3(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp ugt <2 x i32> [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MIN:%.*]] = select <2 x i1> [[CMP1]], <2 x i32> [[Y]], <2 x i32> [[X]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp ugt <2 x i32> [[X]], [[Y]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp ugt <2 x i32> [[X:%.*]], [[Y:%.*]]<br>
; CHECK-NEXT: [[MAX:%.*]] = select <2 x i1> [[CMP2]], <2 x i32> [[X]], <2 x i32> [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp ult <2 x i32> [[MIN]], [[MAX]]<br>
-; CHECK-NEXT: [[R:%.*]] = select <2 x i1> [[CMP3]], <2 x i32> [[MAX]], <2 x i32> [[MIN]]<br>
-; CHECK-NEXT: ret <2 x i32> [[R]]<br>
+; CHECK-NEXT: ret <2 x i32> [[MAX]]<br>
;<br>
%cmp1 = icmp ugt <2 x i32> %x, %y<br>
%min = select <2 x i1> %cmp1, <2 x i32> %y, <2 x i32> %x<br>
@@ -231,13 +183,9 @@ define <2 x i32> @umax_of_umax_umin_comm<br>
<br>
define i32 @umin_of_umin_umax_commute0(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @umin_of_umin_umax_commute0(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp ugt i32 [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MAX:%.*]] = select i1 [[CMP1]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp ugt i32 [[Y]], [[X]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp ugt i32 [[Y:%.*]], [[X:%.*]]<br>
; CHECK-NEXT: [[MIN:%.*]] = select i1 [[CMP2]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp ugt i32 [[MAX]], [[MIN]]<br>
-; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP3]], i32 [[MIN]], i32 [[MAX]]<br>
-; CHECK-NEXT: ret i32 [[R]]<br>
+; CHECK-NEXT: ret i32 [[MIN]]<br>
;<br>
%cmp1 = icmp ugt i32 %x, %y<br>
%max = select i1 %cmp1, i32 %x, i32 %y<br>
@@ -250,13 +198,9 @@ define i32 @umin_of_umin_umax_commute0(i<br>
<br>
define i32 @umin_of_umin_umax_commute1(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @umin_of_umin_umax_commute1(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i32 [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MAX:%.*]] = select i1 [[CMP1]], i32 [[Y]], i32 [[X]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp ult i32 [[X]], [[Y]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp ult i32 [[X:%.*]], [[Y:%.*]]<br>
; CHECK-NEXT: [[MIN:%.*]] = select i1 [[CMP2]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp ugt i32 [[MAX]], [[MIN]]<br>
-; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP3]], i32 [[MIN]], i32 [[MAX]]<br>
-; CHECK-NEXT: ret i32 [[R]]<br>
+; CHECK-NEXT: ret i32 [[MIN]]<br>
;<br>
%cmp1 = icmp ult i32 %x, %y<br>
%max = select i1 %cmp1, i32 %y, i32 %x<br>
@@ -269,13 +213,9 @@ define i32 @umin_of_umin_umax_commute1(i<br>
<br>
define <2 x i32> @umin_of_umin_umax_commute2(<2 x i32> %x, <2 x i32> %y) {<br>
; CHECK-LABEL: @umin_of_umin_umax_commute2(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp ugt <2 x i32> [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MAX:%.*]] = select <2 x i1> [[CMP1]], <2 x i32> [[X]], <2 x i32> [[Y]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp ult <2 x i32> [[X]], [[Y]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp ult <2 x i32> [[X:%.*]], [[Y:%.*]]<br>
; CHECK-NEXT: [[MIN:%.*]] = select <2 x i1> [[CMP2]], <2 x i32> [[X]], <2 x i32> [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp ult <2 x i32> [[MIN]], [[MAX]]<br>
-; CHECK-NEXT: [[R:%.*]] = select <2 x i1> [[CMP3]], <2 x i32> [[MIN]], <2 x i32> [[MAX]]<br>
-; CHECK-NEXT: ret <2 x i32> [[R]]<br>
+; CHECK-NEXT: ret <2 x i32> [[MIN]]<br>
;<br>
%cmp1 = icmp ugt <2 x i32> %x, %y<br>
%max = select <2 x i1> %cmp1, <2 x i32> %x, <2 x i32> %y<br>
@@ -288,13 +228,9 @@ define <2 x i32> @umin_of_umin_umax_comm<br>
<br>
define i32 @umin_of_umin_umax_commute3(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @umin_of_umin_umax_commute3(<br>
-; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i32 [[X:%.*]], [[Y:%.*]]<br>
-; CHECK-NEXT: [[MAX:%.*]] = select i1 [[CMP1]], i32 [[Y]], i32 [[X]]<br>
-; CHECK-NEXT: [[CMP2:%.*]] = icmp ugt i32 [[Y]], [[X]]<br>
+; CHECK-NEXT: [[CMP2:%.*]] = icmp ugt i32 [[Y:%.*]], [[X:%.*]]<br>
; CHECK-NEXT: [[MIN:%.*]] = select i1 [[CMP2]], i32 [[X]], i32 [[Y]]<br>
-; CHECK-NEXT: [[CMP3:%.*]] = icmp ult i32 [[MIN]], [[MAX]]<br>
-; CHECK-NEXT: [[R:%.*]] = select i1 [[CMP3]], i32 [[MIN]], i32 [[MAX]]<br>
-; CHECK-NEXT: ret i32 [[R]]<br>
+; CHECK-NEXT: ret i32 [[MIN]]<br>
;<br>
%cmp1 = icmp ult i32 %x, %y<br>
%max = select i1 %cmp1, i32 %y, i32 %x<br>
@@ -305,6 +241,8 @@ define i32 @umin_of_umin_umax_commute3(i<br>
ret i32 %r<br>
}<br>
<br>
+; Negative test - mismatch of min/max flavor<br>
+<br>
define i32 @umin_of_smin_umax_wrong_pattern(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @umin_of_smin_umax_wrong_pattern(<br>
; CHECK-NEXT: [[CMP1:%.*]] = icmp ugt i32 [[X:%.*]], [[Y:%.*]]<br>
@@ -324,6 +262,8 @@ define i32 @umin_of_smin_umax_wrong_patt<br>
ret i32 %r<br>
}<br>
<br>
+; Negative test - mismatch of min/max flavor<br>
+<br>
define i32 @smin_of_umin_umax_wrong_pattern2(i32 %x, i32 %y) {<br>
; CHECK-LABEL: @smin_of_umin_umax_wrong_pattern2(<br>
; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i32 [[X:%.*]], [[Y:%.*]]<br>
@@ -343,6 +283,8 @@ define i32 @smin_of_umin_umax_wrong_patt<br>
ret i32 %r<br>
}<br>
<br>
+; Negative test - operands must match<br>
+<br>
define <2 x i32> @umin_of_umin_umax_wrong_operand(<2 x i32> %x, <2 x i32> %y, <2 x i32> %z) {<br>
; CHECK-LABEL: @umin_of_umin_umax_wrong_operand(<br>
; CHECK-NEXT: [[CMP1:%.*]] = icmp ugt <2 x i32> [[X:%.*]], [[Y:%.*]]<br>
@@ -362,6 +304,8 @@ define <2 x i32> @umin_of_umin_umax_wron<br>
ret <2 x i32> %r<br>
}<br>
<br>
+; Negative test - operands must match<br>
+<br>
define i32 @umin_of_umin_umax_wrong_operand2(i32 %x, i32 %y, i32 %z) {<br>
; CHECK-LABEL: @umin_of_umin_umax_wrong_operand2(<br>
; CHECK-NEXT: [[CMP1:%.*]] = icmp ult i32 [[X:%.*]], [[Z:%.*]]<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>