<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Aug 2, 2019, at 6:10 PM, <a href="mailto:vsk@apple.com" class="">vsk@apple.com</a> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi Djordje,<br class=""><br class="">I take your point about not wanting to clutter up llvm-dwarfdump --statistics output.<br class=""><br class="">I'll note that, beyond code sharing, there are significant benefits to emitting all `locstats` information using the existing `--statistics` option:<br class=""><br class="">1) We can check in a simple script in utils/ to pretty-print the `--statistics` JSON output, such that we get exactly what is emitted by the `locstats` tool today.<br class=""><br class="">2) Emitting stats in JSON is great for continuous integration jobs that track debug info quality over time. It'd be great to include the metrics reported by `locstats` in these jobs.<br class=""></div></div></blockquote></div><br class=""><div class="">And I should point out that this is not a hypothetical scenario. This job:</div><div class=""><br class=""></div><div class=""><a href="http://green.lab.llvm.org/green/view/LLDB/job/clang-3.4-debuginfo-statistics/" class="">http://green.lab.llvm.org/green/view/LLDB/job/clang-3.4-debuginfo-statistics/</a></div><div class=""><br class=""></div><div class="">Pushes data into:</div><div class=""><br class=""></div><div class=""><a href="http://lnt.llvm.org/db_default/v4/nts/machine/1357" class="">http://lnt.llvm.org/db_default/v4/nts/machine/1357</a></div><div class=""><br class=""></div><div class="">which generates graphs like:</div><div class=""><br class=""></div><div class=""><a href="http://lnt.llvm.org/db_default/v4/nts/graph?plot.0=1357.1607043.4&highlight_run=127815" class="">http://lnt.llvm.org/db_default/v4/nts/graph?plot.0=1357.1607043.4&highlight_run=127815</a></div><div class=""><br class=""></div><div class="">several times per hour. Any new JSON fields show up there without any extra manual intervention.</div><div class=""><br class=""></div><div class="">-- adrian</div></body></html>