<html><body><p>Looks like you did upload the wrong version.<br><br><a href="https://reviews.llvm.org/D64665?vs=212147&id=212800&whitespace=ignore-most#toc"><u><font color="#0000FF">https://reviews.llvm.org/D64665?vs=212147&id=212800&whitespace=ignore-most#toc</font></u></a><font size="2"> shows nothing new comparing to 212147 (July 29).</font><br><br><br><font size="2"><br>Best,<br><br>Jinsong Ji (纪金松), PhD.<br><br>XL/LLVM on Power Compiler Development <br>E-mail: jji@us.ibm.com</font><br><br><img width="16" height="16" src="cid:1__=8FBB0EDADFCCEB8C8f9e8a93df938690918c8FB@" border="0" alt="Inactive hide details for James Molloy ---08/01/2019 11:53:45 AM---Hi, Did you test the latest version? Those errors were all f"><font size="2" color="#424282">James Molloy ---08/01/2019 11:53:45 AM---Hi, Did you test the latest version? Those errors were all fixed just before I</font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">James Molloy <jmolloy@google.com></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">reviews+D64665+public+6971cdf24f5c9ab4@reviews.llvm.org</font><br><font size="2" color="#5F5F5F">Cc: </font><font size="2">bcahoon@quicinc.com, jji@us.ibm.com, Matthew.Arsenault@amd.com, hfinkel@anl.gov, llvm-commits@lists.llvm.org, jun.l@samsung.com, florian_hahn@apple.com</font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">08/01/2019 11:53 AM</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">[EXTERNAL] Re: [PATCH] D64665: [MachinePipeliner] Refactor schedule emission logic</font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br>Hi,<br><br>Did you test the latest version? Those errors were all fixed just before I sent the last email (unless I somehow managed to upload the wrong version...)<br><br>(The compiler options I use are slightly more permissive which is why these errors didn't show during development)<br><br><br>James<br><br>On Thu, 1 Aug 2019, 15:47 Jinsong Ji via Phabricator, <<a href="mailto:reviews@reviews.llvm.org"><u><font color="#0000FF">reviews@reviews.llvm.org</font></u></a>> wrote:
<ul>jsji added a comment.<br><br>How do you build and test? I can't config & build it with clang.<br><br><br><br>================<br>Comment at: lib/CodeGen/MachineLoopUtils.cpp:1<br>+//=- MachineLoopUtils.cpp - Functions for manipulating loops ----------------=//<br>+//<br>----------------<br>New file, you need to update `llvm/lib/CodeGen/CMakeLists.txt` as well.<br><br><br>================<br>Comment at: lib/CodeGen/MachinePipeliner.cpp:4287<br>+ SmallVector<int, 4> LiveStages;<br>+ for (int I = 0; I < NumPrologs; ++I) {<br>+ LiveStages.push_back(I);<br>----------------<br>`comparison of integers of different signs: 'int' and 'unsigned int'`<br><br><br>================<br>Comment at: lib/CodeGen/MachinePipeliner.cpp:4296<br>+ // stage NumStages-1, Epilog 1 performs stage NumStages-2 THEN NumStages-1.<br>+ for (int I = 0; I < NumPrologs; ++I) {<br>+ int StartStage = NumStages - 1 - I;<br>----------------<br>`comparison of integers of different signs: 'int' and 'unsigned int'`<br><br><br>================<br>Comment at: lib/CodeGen/MachinePipeliner.cpp:4299<br>+ CGBlocks.insert(std::next(Kernel), Kernel->peel(LPD_Back));<br>+ for (int Stage = StartStage + 1; Stage < NumStages; ++Stage) {<br>+ CGBlocks.insert(std::next(Kernel), Kernel->peel(LPD_Back));<br>----------------<br>`comparison of integers of different signs: 'int' and 'unsigned int'`<br><br><br>================<br>Comment at: lib/CodeGen/MachinePipeliner.cpp:4304<br>+ auto EBI = std::next(Kernel);<br>+ for (int I = 0; I < NumPrologs; ++I) {<br>+ int StartStage = NumStages - 1 - I;<br>----------------<br>`comparison of integers of different signs: 'int' and 'unsigned int'`<br><br><br>================<br>Comment at: lib/CodeGen/MachinePipeliner.cpp:4308<br>+ EBI++->setLiveStages({StartStage});<br>+ for (int Stage = StartStage + 1; Stage < NumStages; ++Stage) {<br>+ EBI++->setLiveStages({Stage});<br>----------------<br>`comparison of integers of different signs: 'int' and 'unsigned int'`<br><br><br>================<br>Comment at: lib/CodeGen/MachinePipeliner.cpp:4417<br>+ auto *MI = SU->getInstr();<br>+ InstrInfos[MI] = {Schedule.stageScheduled(SU), Cycle, Index++};<br>+ if (MI->isPHI())<br>----------------<br>`.../llvm-git/llvm-project/llvm/lib/CodeGen/MachinePipeliner.cpp:4417:22: error: no viable overloaded '='<br> InstrInfos[MI] = {Schedule.stageScheduled(SU), Cycle, Index++};<br> ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>.../llvm-git/llvm-project/llvm/lib/CodeGen/MachinePipeliner.cpp:4190:10: note: candidate function (the implicit copy assignment operator) not viable: cannot convert initializer list argument to 'const (anonymous namespace)::CGBlock::InstrInfo'<br> struct InstrInfo {<br> ^<br>.../llvm-git/llvm-project/llvm/lib/CodeGen/MachinePipeliner.cpp:4190:10: note: candidate function (the implicit move assignment operator) not viable: cannot convert initializer list argument to '(anonymous namespace)::CGBlock::InstrInfo'<br> struct InstrInfo {<br>`<br><br><br>Repository:<br> rL LLVM<br><br>CHANGES SINCE LAST ACTION<br> <a href="https://reviews.llvm.org/D64665/new/" target="_blank"><u><font color="#0000FF">https://reviews.llvm.org/D64665/new/</font></u></a><br><u><font color="#0000FF"><br></font></u><a href="https://reviews.llvm.org/D64665" target="_blank"><u><font color="#0000FF">https://reviews.llvm.org/D64665</font></u></a><br><br><br><br><br></ul><BR>
</body></html>