<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">googletest-format.py generates a %t.out, which among other things emits these two lines:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I am subTest B, I FAIL<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">And I have two lines of output<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">A hexdump of the .out file was very informative.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">If there is no 'env' in front of the %{python} in the %{lit} substitution, those lines are separate by CR CR LF.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">If there IS 'env' in front of %{python}, those lines are separated by CR CR CR LF. And that causes the CHECK-NEXT of the second line of output to fail.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">This is likely some peculiar interaction of python and GnuWin32 'env' on Windows. It still bugs me that Windows bots are not running into this. Yes we are
pursuing that internally. We might decide to XFAIL a bunch of the lit test suite tests just to get our auto-integration moving again, although I am not too happy about that tactic.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">--paulr<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Joel E. Denny [mailto:jdenny.ornl@gmail.com]
<br>
<b>Sent:</b> Friday, July 26, 2019 12:35 PM<br>
<b>To:</b> Robinson, Paul<br>
<b>Cc:</b> mgorny@gentoo.org; reviews+D65156+public+5784c7837e421597@reviews.llvm.org; Dan Liew; Thomas Preud'homme; LLVM Commits<br>
<b>Subject:</b> Re: [PATCH] D65156: [lit] Protect full test suite from FILECHECK_OPTS<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<div>
<p class="MsoNormal">Hi Paul,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">On Fri, Jul 26, 2019 at 11:56 AM <<a href="mailto:paul.robinson@sony.com">paul.robinson@sony.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">> We have had an internal bot get 9 failures in the lit test suite<br>
> since this patch went in; I will see if the suggested patches help.<br>
> --paulr<br>
<br>
They don't help. It appears the gnuwin32 'env' does understand -u so<br>
that wasn't the problem.<o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Bummer.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><br>
Picking apart 'googletest-format.py' and doing the steps manually,<br>
so that I can get FileCheck to tell me what's going on, it appears<br>
that the .out file generated by the test has an extra line terminator,<br>
so a CHECK-NEXT on the .out file fails.<o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Where does that line terminator appear?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><br>
If I hack the lit.cfg so it's just 'env %{python} etc' (not trying<br>
to set or unset) the same failure occurs; so, something about running<br>
python or lit.py under GnuWin32 'env' is making this occur.<br>
<br>
env version 5.3.0<br>
python version 2.7.12 on Windows version 7<br>
python version 2.7.14 on Windows version 10<o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">If you're pursuing this, let me know. Otherwise, I'll move to windows and try to figure this out.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Thanks for the details.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Joel<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
--paulr<br>
<br>
> <br>
> > -----Original Message-----<br>
> > From: Michał Górny [mailto:<a href="mailto:mgorny@gentoo.org" target="_blank">mgorny@gentoo.org</a>]<br>
> > Sent: Friday, July 26, 2019 10:28 AM<br>
> > To: Joel E. Denny;<br>
> <a href="mailto:reviews%2BD65156%2Bpublic%2B5784c7837e421597@reviews.llvm.org" target="_blank">
reviews+D65156+public+5784c7837e421597@reviews.llvm.org</a><br>
> > Cc: Robinson, Paul; Dan Liew; Thomas Preud'homme; LLVM Commits<br>
> > Subject: Re: [PATCH] D65156: [lit] Protect full test suite from<br>
> > FILECHECK_OPTS<br>
> ><br>
> > On Fri, 2019-07-26 at 10:17 -0400, Joel E. Denny wrote:<br>
> > > Hi Michał,<br>
> > ><br>
> > > On Fri, Jul 26, 2019 at 10:12 AM Michał Górny via Phabricator <<br>
> > > <a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br>
> > ><br>
> > > > mgorny added a comment.<br>
> > > ><br>
> > > > This change broke NetBSD buildbots, e.g.:<br>
> > > > <a href="http://lab.llvm.org:8011/builders/netbsd-" target="_blank">http://lab.llvm.org:8011/builders/netbsd-</a><br>
> ><br>
> amd64/builds/21152/steps/run%20unit%20tests/logs/FAIL%3A%20lit%3A%3A%20goo<br>
> > gletest-upstream-format.py<br>
> > ><br>
> > > I didn't receive an automated email for this. Should I have?<br>
> > ><br>
> ><br>
> > To be honest, I don't really know. The bot hasn't managed to get green<br>
> > for quite some time already, and I don't know if it pings you if there<br>
> > is a constant breakage.<br>
> ><br>
> > --<br>
> > Best regards,<br>
> > Michał Górny<o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</div>
</body>
</html>