<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jul 26, 2019 at 11:34 AM Eli Friedman via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">efriedma added subscribers: NutshellySima, brzycki.<br>
efriedma added a comment.<br>
<br>
Please rebase against trunk.<br>
<br>
<br>
<br>
================<br>
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:1214<br>
     if (PN->getParent() == BB && isa<BranchInst>(BB->getTerminator()))<br>
-      updatePredecessorProfileMetadata(PN, BB);<br>
+      updatePredecessorProfileMetadata(PN, BB, DTU->getDomTree());<br>
<br>
----------------<br>
Calling getDomTree() here is expensive; it flushes all updates in the DomTreeUpdater.<br>
<br></blockquote><div><br></div><div>Or I can detect loop using a set keeping nodes which have been visited. Whenever SinglePredBB is seen in the set, stop searching. </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D65310/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D65310/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D65310" rel="noreferrer" target="_blank">https://reviews.llvm.org/D65310</a><br>
<br>
<br>
<br>
</blockquote></div></div>