<div dir="ltr">Thanks! Did you do this manually?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jul 16, 2019 at 2:50 PM Fangrui Song via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: maskray<br>
Date: Mon Jul 15 22:50:45 2019<br>
New Revision: 366181<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=366181&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=366181&view=rev</a><br>
Log:<br>
[ELF] Fix variable names in comments after VariableName -> variableName change<br>
<br>
Also fix some typos.<br>
<br>
Modified:<br>
lld/trunk/ELF/AArch64ErrataFix.cpp<br>
lld/trunk/ELF/AArch64ErrataFix.h<br>
lld/trunk/ELF/Arch/AArch64.cpp<br>
lld/trunk/ELF/Arch/ARM.cpp<br>
lld/trunk/ELF/Arch/RISCV.cpp<br>
lld/trunk/ELF/CallGraphSort.cpp<br>
lld/trunk/ELF/Config.h<br>
lld/trunk/ELF/Driver.cpp<br>
lld/trunk/ELF/InputFiles.cpp<br>
lld/trunk/ELF/InputFiles.h<br>
lld/trunk/ELF/InputSection.cpp<br>
lld/trunk/ELF/InputSection.h<br>
lld/trunk/ELF/LTO.cpp<br>
lld/trunk/ELF/LinkerScript.cpp<br>
lld/trunk/ELF/Relocations.cpp<br>
lld/trunk/ELF/ScriptParser.h<br>
lld/trunk/ELF/SymbolTable.cpp<br>
lld/trunk/ELF/SyntheticSections.cpp<br>
lld/trunk/ELF/SyntheticSections.h<br>
lld/trunk/ELF/Target.h<br>
lld/trunk/ELF/Thunks.cpp<br>
lld/trunk/ELF/Writer.cpp<br>
lld/trunk/test/ELF/Inputs/gdb-index-multiple-cu-2.s<br>
lld/trunk/test/ELF/gdb-index-multiple-cu-2.s<br>
lld/trunk/test/ELF/gdb-index-multiple-cu.s<br>
<br>
Modified: lld/trunk/ELF/AArch64ErrataFix.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/AArch64ErrataFix.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/AArch64ErrataFix.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/AArch64ErrataFix.cpp (original)<br>
+++ lld/trunk/ELF/AArch64ErrataFix.cpp Mon Jul 15 22:50:45 2019<br>
@@ -413,8 +413,8 @@ void lld::elf::Patch843419Section::write<br>
write32le(buf, read32le(patchee->data().begin() + patcheeOffset));<br>
<br>
// Apply any relocation transferred from the original PatcheeSection.<br>
- // For a SyntheticSection Buf already has OutSecOff added, but relocateAlloc<br>
- // also adds OutSecOff so we need to subtract to avoid double counting.<br>
+ // For a SyntheticSection Buf already has outSecOff added, but relocateAlloc<br>
+ // also adds outSecOff so we need to subtract to avoid double counting.<br>
this->relocateAlloc(buf - outSecOff, buf - outSecOff + getSize());<br>
<br>
// Return address is the next instruction after the one we have just copied.<br>
@@ -427,7 +427,7 @@ void AArch64Err843419Patcher::init() {<br>
// The AArch64 ABI permits data in executable sections. We must avoid scanning<br>
// this data as if it were instructions to avoid false matches. We use the<br>
// mapping symbols in the InputObjects to identify this data, caching the<br>
- // results in SectionMap so we don't have to recalculate it each pass.<br>
+ // results in sectionMap so we don't have to recalculate it each pass.<br>
<br>
// The ABI Section 4.5.4 Mapping symbols; defines local symbols that describe<br>
// half open intervals [Symbol Value, Next Symbol Value) of code and data<br>
@@ -489,7 +489,7 @@ void AArch64Err843419Patcher::insertPatc<br>
uint64_t patchUpperBound = prevIsecLimit + target->getThunkSectionSpacing();<br>
uint64_t outSecAddr = isd.sections.front()->getParent()->addr;<br>
<br>
- // Set the OutSecOff of patches to the place where we want to insert them.<br>
+ // Set the outSecOff of patches to the place where we want to insert them.<br>
// We use a similar strategy to Thunk placement. Place patches roughly<br>
// every multiple of maximum branch range.<br>
auto patchIt = patches.begin();<br>
@@ -511,10 +511,10 @@ void AArch64Err843419Patcher::insertPatc<br>
(*patchIt)->outSecOff = isecLimit;<br>
}<br>
<br>
- // merge all patch sections. We use the OutSecOff assigned above to<br>
+ // merge all patch sections. We use the outSecOff assigned above to<br>
// determine the insertion point. This is ok as we only merge into an<br>
// InputSectionDescription once per pass, and at the end of the pass<br>
- // assignAddresses() will recalculate all the OutSecOff values.<br>
+ // assignAddresses() will recalculate all the outSecOff values.<br>
std::vector<InputSection *> tmp;<br>
tmp.reserve(isd.sections.size() + patches.size());<br>
auto mergeCmp = [](const InputSection *a, const InputSection *b) {<br>
@@ -530,8 +530,8 @@ void AArch64Err843419Patcher::insertPatc<br>
isd.sections = std::move(tmp);<br>
}<br>
<br>
-// Given an erratum sequence that starts at address AdrpAddr, with an<br>
-// instruction that we need to patch at PatcheeOffset from the start of<br>
+// Given an erratum sequence that starts at address adrpAddr, with an<br>
+// instruction that we need to patch at patcheeOffset from the start of<br>
// InputSection IS, create a Patch843419 Section and add it to the<br>
// Patches that we need to insert.<br>
static void implementPatch(uint64_t adrpAddr, uint64_t patcheeOffset,<br>
@@ -587,10 +587,10 @@ AArch64Err843419Patcher::patchInputSecti<br>
// LLD doesn't use the erratum sequence in SyntheticSections.<br>
if (isa<SyntheticSection>(isec))<br>
continue;<br>
- // Use SectionMap to make sure we only scan code and not inline data.<br>
+ // Use sectionMap to make sure we only scan code and not inline data.<br>
// We have already sorted MapSyms in ascending order and removed consecutive<br>
// mapping symbols of the same type. Our range of executable instructions to<br>
- // scan is therefore [CodeSym->Value, DataSym->Value) or [CodeSym->Value,<br>
+ // scan is therefore [codeSym->value, dataSym->value) or [codeSym->value,<br>
// section size).<br>
std::vector<const Defined *> &mapSyms = sectionMap[isec];<br>
<br>
<br>
Modified: lld/trunk/ELF/AArch64ErrataFix.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/AArch64ErrataFix.h?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/AArch64ErrataFix.h?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/AArch64ErrataFix.h (original)<br>
+++ lld/trunk/ELF/AArch64ErrataFix.h Mon Jul 15 22:50:45 2019<br>
@@ -36,7 +36,7 @@ private:<br>
<br>
void init();<br>
<br>
- // A cache of the mapping symbols defined by the InputSecion sorted in order<br>
+ // A cache of the mapping symbols defined by the InputSection sorted in order<br>
// of ascending value with redundant symbols removed. These describe<br>
// the ranges of code and data in an executable InputSection.<br>
std::map<InputSection *, std::vector<const Defined *>> sectionMap;<br>
<br>
Modified: lld/trunk/ELF/Arch/AArch64.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Arch/AArch64.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Arch/AArch64.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Arch/AArch64.cpp (original)<br>
+++ lld/trunk/ELF/Arch/AArch64.cpp Mon Jul 15 22:50:45 2019<br>
@@ -517,7 +517,7 @@ void AArch64BtiPac::writePltHeader(uint8<br>
uint64_t plt = in.plt->getVA();<br>
<br>
if (btiHeader) {<br>
- // PltHeader is called indirectly by Plt[N]. Prefix PltData with a BTI C<br>
+ // PltHeader is called indirectly by plt[N]. Prefix pltData with a BTI C<br>
// instruction.<br>
memcpy(buf, btiData, sizeof(btiData));<br>
buf += sizeof(btiData);<br>
@@ -538,7 +538,7 @@ void AArch64BtiPac::writePlt(uint8_t *bu<br>
uint64_t pltEntryAddr, int32_t index,<br>
unsigned relOff) const {<br>
// The PLT entry is of the form:<br>
- // [BtiData] AddrInst (PacBr | StdBr) [NopData]<br>
+ // [btiData] addrInst (pacBr | stdBr) [nopData]<br>
const uint8_t btiData[] = { 0x5f, 0x24, 0x03, 0xd5 }; // bti c<br>
const uint8_t addrInst[] = {<br>
0x10, 0x00, 0x00, 0x90, // adrp x16, Page(&(.plt.got[n]))<br>
<br>
Modified: lld/trunk/ELF/Arch/ARM.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Arch/ARM.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Arch/ARM.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Arch/ARM.cpp (original)<br>
+++ lld/trunk/ELF/Arch/ARM.cpp Mon Jul 15 22:50:45 2019<br>
@@ -299,13 +299,13 @@ bool ARM::needsThunk(RelExpr expr, RelTy<br>
<br>
uint32_t ARM::getThunkSectionSpacing() const {<br>
// The placing of pre-created ThunkSections is controlled by the value<br>
- // ThunkSectionSpacing returned by getThunkSectionSpacing(). The aim is to<br>
+ // thunkSectionSpacing returned by getThunkSectionSpacing(). The aim is to<br>
// place the ThunkSection such that all branches from the InputSections<br>
// prior to the ThunkSection can reach a Thunk placed at the end of the<br>
// ThunkSection. Graphically:<br>
- // | up to ThunkSectionSpacing .text input sections |<br>
+ // | up to thunkSectionSpacing .text input sections |<br>
// | ThunkSection |<br>
- // | up to ThunkSectionSpacing .text input sections |<br>
+ // | up to thunkSectionSpacing .text input sections |<br>
// | ThunkSection |<br>
<br>
// Pre-created ThunkSections are spaced roughly 16MiB apart on ARMv7. This<br>
@@ -316,14 +316,14 @@ uint32_t ARM::getThunkSectionSpacing() c<br>
// Thumb B<cc>.W range +/- 1MiB<br>
// If a branch cannot reach a pre-created ThunkSection a new one will be<br>
// created so we can handle the rare cases of a Thumb 2 conditional branch.<br>
- // We intentionally use a lower size for ThunkSectionSpacing than the maximum<br>
+ // We intentionally use a lower size for thunkSectionSpacing than the maximum<br>
// branch range so the end of the ThunkSection is more likely to be within<br>
// range of the branch instruction that is furthest away. The value we shorten<br>
- // ThunkSectionSpacing by is set conservatively to allow us to create 16,384<br>
+ // thunkSectionSpacing by is set conservatively to allow us to create 16,384<br>
// 12 byte Thunks at any offset in a ThunkSection without risk of a branch to<br>
// one of the Thunks going out of range.<br>
<br>
- // On Arm the ThunkSectionSpacing depends on the range of the Thumb Branch<br>
+ // On Arm the thunkSectionSpacing depends on the range of the Thumb Branch<br>
// range. On earlier Architectures such as ARMv4, ARMv5 and ARMv6 (except<br>
// ARMv6T2) the range is +/- 4MiB.<br>
<br>
<br>
Modified: lld/trunk/ELF/Arch/RISCV.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Arch/RISCV.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Arch/RISCV.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Arch/RISCV.cpp (original)<br>
+++ lld/trunk/ELF/Arch/RISCV.cpp Mon Jul 15 22:50:45 2019<br>
@@ -144,7 +144,7 @@ void RISCV::writePltHeader(uint8_t *buf)<br>
// 1: auipc t2, %pcrel_hi(.got.plt)<br>
// sub t1, t1, t3<br>
// l[wd] t3, %pcrel_lo(1b)(t2); t3 = _dl_runtime_resolve<br>
- // addi t1, t1, -PltHeaderSize-12; t1 = &.plt[i] - &.plt[0]<br>
+ // addi t1, t1, -pltHeaderSize-12; t1 = &.plt[i] - &.plt[0]<br>
// addi t0, t2, %pcrel_lo(1b)<br>
// srli t1, t1, (rv64?1:2); t1 = &.got.plt[i] - &.got.plt[0]<br>
// l[wd] t0, Wordsize(t0); t0 = link_map<br>
<br>
Modified: lld/trunk/ELF/CallGraphSort.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/CallGraphSort.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/CallGraphSort.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/CallGraphSort.cpp (original)<br>
+++ lld/trunk/ELF/CallGraphSort.cpp Mon Jul 15 22:50:45 2019<br>
@@ -177,7 +177,7 @@ void CallGraphSort::groupClusters() {<br>
});<br>
<br>
for (int si : sortedSecs) {<br>
- // Clusters[SI] is the same as SecToClusters[SI] here because it has not<br>
+ // clusters[si] is the same as secToClusters[si] here because it has not<br>
// been merged into another cluster yet.<br>
Cluster &c = clusters[si];<br>
<br>
@@ -233,8 +233,8 @@ DenseMap<const InputSectionBase *, int><br>
return orderMap;<br>
}<br>
<br>
- // Print the symbols ordered by C3, in the order of increasing CurOrder<br>
- // Instead of sorting all the OrderMap, just repeat the loops above.<br>
+ // Print the symbols ordered by C3, in the order of increasing curOrder<br>
+ // Instead of sorting all the orderMap, just repeat the loops above.<br>
for (const Cluster &c : clusters)<br>
for (int secIndex : c.sections)<br>
// Search all the symbols in the file of the section<br>
<br>
Modified: lld/trunk/ELF/Config.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Config.h?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Config.h?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Config.h (original)<br>
+++ lld/trunk/ELF/Config.h Mon Jul 15 22:50:45 2019<br>
@@ -249,7 +249,7 @@ struct Configuration {<br>
// True if the target is little-endian. False if big-endian.<br>
bool isLE;<br>
<br>
- // endianness::little if IsLE is true. endianness::big otherwise.<br>
+ // endianness::little if isLE is true. endianness::big otherwise.<br>
llvm::support::endianness endianness;<br>
<br>
// True if the target is the little-endian MIPS64.<br>
<br>
Modified: lld/trunk/ELF/Driver.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Driver.cpp (original)<br>
+++ lld/trunk/ELF/Driver.cpp Mon Jul 15 22:50:45 2019<br>
@@ -1255,7 +1255,7 @@ static uint64_t getCommonPageSize(opt::I<br>
warn("-z common-page-size set, but paging disabled by omagic or nmagic");<br>
return 1;<br>
}<br>
- // CommonPageSize can't be larger than MaxPageSize.<br>
+ // commonPageSize can't be larger than maxPageSize.<br>
if (val > config->maxPageSize)<br>
val = config->maxPageSize;<br>
return val;<br>
@@ -1263,7 +1263,7 @@ static uint64_t getCommonPageSize(opt::I<br>
<br>
// Parses -image-base option.<br>
static Optional<uint64_t> getImageBase(opt::InputArgList &args) {<br>
- // Because we are using "Config->MaxPageSize" here, this function has to be<br>
+ // Because we are using "Config->maxPageSize" here, this function has to be<br>
// called after the variable is initialized.<br>
auto *arg = args.getLastArg(OPT_image_base);<br>
if (!arg)<br>
@@ -1406,8 +1406,8 @@ static void demoteSharedSymbols() {<br>
});<br>
}<br>
<br>
-// The section referred to by S is considered address-significant. Set the<br>
-// KeepUnique flag on the section if appropriate.<br>
+// The section referred to by `s` is considered address-significant. Set the<br>
+// keepUnique flag on the section if appropriate.<br>
static void markAddrsig(Symbol *s) {<br>
if (auto *d = dyn_cast_or_null<Defined>(s))<br>
if (d->section)<br>
@@ -1772,7 +1772,7 @@ template <class ELFT> void LinkerDriver:<br>
if (args.hasArg(OPT_exclude_libs))<br>
excludeLibs(args);<br>
<br>
- // Create ElfHeader early. We need a dummy section in<br>
+ // Create elfHeader early. We need a dummy section in<br>
// addReservedSymbols to mark the created symbols as not absolute.<br>
Out::elfHeader = make<OutputSection>("", 0, SHF_ALLOC);<br>
Out::elfHeader->size = sizeof(typename ELFT::Ehdr);<br>
@@ -1854,14 +1854,14 @@ template <class ELFT> void LinkerDriver:<br>
target = getTarget();<br>
<br>
config->eflags = target->calcEFlags();<br>
- // MaxPageSize (sometimes called abi page size) is the maximum page size that<br>
+ // maxPageSize (sometimes called abi page size) is the maximum page size that<br>
// the output can be run on. For example if the OS can use 4k or 64k page<br>
- // sizes then MaxPageSize must be 64 for the output to be useable on both.<br>
+ // sizes then maxPageSize must be 64k for the output to be useable on both.<br>
// All important alignment decisions must use this value.<br>
config->maxPageSize = getMaxPageSize(args);<br>
- // CommonPageSize is the most common page size that the output will be run on.<br>
+ // commonPageSize is the most common page size that the output will be run on.<br>
// For example if an OS can use 4k or 64k page sizes and 4k is more common<br>
- // than 64k then CommonPageSize is set to 4k. CommonPageSize can be used for<br>
+ // than 64k then commonPageSize is set to 4k. commonPageSize can be used for<br>
// optimizations such as DATA_SEGMENT_ALIGN in linker scripts. LLD's use of it<br>
// is limited to writing trap instructions on the last executable segment.<br>
config->commonPageSize = getCommonPageSize(args);<br>
<br>
Modified: lld/trunk/ELF/InputFiles.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/InputFiles.cpp (original)<br>
+++ lld/trunk/ELF/InputFiles.cpp Mon Jul 15 22:50:45 2019<br>
@@ -229,7 +229,7 @@ static std::string getSrcMsgAux(ObjFile<<br>
file.getVariableLoc(sym.getName()))<br>
return createFileLineMsg(fileLine->first, fileLine->second);<br>
<br>
- // File.SourceFile contains STT_FILE symbol, and that is a last resort.<br>
+ // File.sourceFile contains STT_FILE symbol, and that is a last resort.<br>
return file.sourceFile;<br>
}<br>
<br>
@@ -269,7 +269,7 @@ template <class ELFT> void ObjFile<ELFT><br>
continue;<br>
lineTables.push_back(lt);<br>
<br>
- // Loop over variable records and insert them to VariableLoc.<br>
+ // Loop over variable records and insert them to variableLoc.<br>
for (const auto &entry : cu->dies()) {<br>
DWARFDie die(cu.get(), &entry);<br>
// Skip all tags that are not variables.<br>
@@ -290,7 +290,7 @@ template <class ELFT> void ObjFile<ELFT><br>
// Get the line number on which the variable is declared.<br>
unsigned line = dwarf::toUnsigned(die.find(dwarf::DW_AT_decl_line), 0);<br>
<br>
- // Here we want to take the variable name to add it into VariableLoc.<br>
+ // Here we want to take the variable name to add it into variableLoc.<br>
// Variable can have regular and linkage name associated. At first, we try<br>
// to get linkage name as it can be different, for example when we have<br>
// two variables in different namespaces of the same object. Use common<br>
@@ -450,7 +450,7 @@ template <class ELFT> ArrayRef<Symbol *><br>
}<br>
<br>
template <class ELFT> void ObjFile<ELFT>::parse(bool ignoreComdats) {<br>
- // Read a section table. JustSymbols is usually false.<br>
+ // Read a section table. justSymbols is usually false.<br>
if (this->justSymbols)<br>
initializeJustSymbols();<br>
else<br>
@@ -1178,7 +1178,7 @@ static std::vector<const void *> parseVe<br>
// We cannot determine the largest verdef identifier without inspecting<br>
// every Elf_Verdef, but both bfd and gold assign verdef identifiers<br>
// sequentially starting from 1, so we predict that the largest identifier<br>
- // will be VerdefCount.<br>
+ // will be verdefCount.<br>
unsigned verdefCount = sec->sh_info;<br>
std::vector<const void *> verdefs(verdefCount + 1);<br>
<br>
@@ -1262,7 +1262,7 @@ template <class ELFT> void SharedFile::p<br>
return;<br>
}<br>
<br>
- // Search for a DT_SONAME tag to initialize this->SoName.<br>
+ // Search for a DT_SONAME tag to initialize this->soName.<br>
for (const Elf_Dyn &dyn : dynamicTags) {<br>
if (dyn.d_tag == DT_NEEDED) {<br>
uint64_t val = dyn.getVal();<br>
<br>
Modified: lld/trunk/ELF/InputFiles.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.h?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.h?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/InputFiles.h (original)<br>
+++ lld/trunk/ELF/InputFiles.h Mon Jul 15 22:50:45 2019<br>
@@ -117,7 +117,7 @@ public:<br>
// True if this is an argument for --just-symbols. Usually false.<br>
bool justSymbols = false;<br>
<br>
- // OutSecOff of .got2 in the current file. This is used by PPC32 -fPIC/-fPIE<br>
+ // outSecOff of .got2 in the current file. This is used by PPC32 -fPIC/-fPIE<br>
// to compute offsets in PLT call stubs.<br>
uint32_t ppc32Got2OutSecOff = 0;<br>
<br>
@@ -132,7 +132,7 @@ public:<br>
// [.got, .got + 0xFFFC].<br>
bool ppc64SmallCodeModelTocRelocs = false;<br>
<br>
- // GroupId is used for --warn-backrefs which is an optional error<br>
+ // groupId is used for --warn-backrefs which is an optional error<br>
// checking feature. All files within the same --{start,end}-group or<br>
// --{start,end}-lib get the same group ID. Otherwise, each file gets a new<br>
// group ID. For more info, see checkDependency() in SymbolTable.cpp.<br>
<br>
Modified: lld/trunk/ELF/InputSection.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputSection.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputSection.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/InputSection.cpp (original)<br>
+++ lld/trunk/ELF/InputSection.cpp Mon Jul 15 22:50:45 2019<br>
@@ -206,9 +206,9 @@ OutputSection *SectionBase::getOutputSec<br>
return sec ? sec->getParent() : nullptr;<br>
}<br>
<br>
-// When a section is compressed, `RawData` consists with a header followed<br>
+// When a section is compressed, `rawData` consists with a header followed<br>
// by zlib-compressed data. This function parses a header to initialize<br>
-// `UncompressedSize` member and remove the header from `RawData`.<br>
+// `uncompressedSize` member and remove the header from `rawData`.<br>
void InputSectionBase::parseCompressedHeader() {<br>
using Chdr64 = typename ELF64LE::Chdr;<br>
using Chdr32 = typename ELF32LE::Chdr;<br>
@@ -306,7 +306,7 @@ std::string InputSectionBase::getLocatio<br>
return info->FileName + ":" + std::to_string(info->Line) + ":(" +<br>
secAndOffset + ")";<br>
<br>
- // File->SourceFile contains STT_FILE symbol that contains a<br>
+ // File->sourceFile contains STT_FILE symbol that contains a<br>
// source file name. If it's missing, we use an object file name.<br>
std::string srcFile = getFile<ELFT>()->sourceFile;<br>
if (srcFile.empty())<br>
<br>
Modified: lld/trunk/ELF/InputSection.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputSection.h?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputSection.h?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/InputSection.h (original)<br>
+++ lld/trunk/ELF/InputSection.h Mon Jul 15 22:50:45 2019<br>
@@ -219,8 +219,8 @@ protected:<br>
<br>
mutable ArrayRef<uint8_t> rawData;<br>
<br>
- // This field stores the uncompressed size of the compressed data in RawData,<br>
- // or -1 if RawData is not compressed (either because the section wasn't<br>
+ // This field stores the uncompressed size of the compressed data in rawData,<br>
+ // or -1 if rawData is not compressed (either because the section wasn't<br>
// compressed in the first place, or because we ended up uncompressing it).<br>
// Since the feature is not used often, this is usually -1.<br>
mutable int64_t uncompressedSize = -1;<br>
<br>
Modified: lld/trunk/ELF/LTO.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LTO.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LTO.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/LTO.cpp (original)<br>
+++ lld/trunk/ELF/LTO.cpp Mon Jul 15 22:50:45 2019<br>
@@ -124,11 +124,11 @@ static lto::Config createConfig() {<br>
}<br>
<br>
BitcodeCompiler::BitcodeCompiler() {<br>
- // Initialize IndexFile.<br>
+ // Initialize indexFile.<br>
if (!config->thinLTOIndexOnlyArg.empty())<br>
indexFile = openFile(config->thinLTOIndexOnlyArg);<br>
<br>
- // Initialize LTOObj.<br>
+ // Initialize ltoObj.<br>
lto::ThinBackend backend;<br>
if (config->thinLTOIndexOnly) {<br>
auto onIndexWrite = [&](StringRef s) { thinIndices.erase(s); };<br>
@@ -142,7 +142,7 @@ BitcodeCompiler::BitcodeCompiler() {<br>
ltoObj = llvm::make_unique<lto::LTO>(createConfig(), backend,<br>
config->ltoPartitions);<br>
<br>
- // Initialize UsedStartStop.<br>
+ // Initialize usedStartStop.<br>
symtab->forEachSymbol([&](Symbol *sym) {<br>
StringRef s = sym->getName();<br>
for (StringRef prefix : {"__start_", "__stop_"})<br>
<br>
Modified: lld/trunk/ELF/LinkerScript.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/LinkerScript.cpp (original)<br>
+++ lld/trunk/ELF/LinkerScript.cpp Mon Jul 15 22:50:45 2019<br>
@@ -115,7 +115,7 @@ void LinkerScript::expandMemoryRegions(u<br>
if (ctx->memRegion)<br>
expandMemoryRegion(ctx->memRegion, size, ctx->memRegion->name,<br>
ctx->outSec->name);<br>
- // Only expand the LMARegion if it is different from MemRegion.<br>
+ // Only expand the LMARegion if it is different from memRegion.<br>
if (ctx->lmaRegion && ctx->memRegion != ctx->lmaRegion)<br>
expandMemoryRegion(ctx->lmaRegion, size, ctx->lmaRegion->name,<br>
ctx->outSec->name);<br>
@@ -1035,8 +1035,8 @@ static uint64_t getInitialDot() {<br>
return config->imageBase ? *config->imageBase : 0;<br>
<br>
uint64_t startAddr = UINT64_MAX;<br>
- // The Sections with -T<section> have been sorted in order of ascending<br>
- // address. We must lower StartAddr if the lowest -T<section address> as<br>
+ // The sections with -T<section> have been sorted in order of ascending<br>
+ // address. We must lower startAddr if the lowest -T<section address> as<br>
// calls to setDot() must be monotonically increasing.<br>
for (auto &kv : config->sectionStartMap)<br>
startAddr = std::min(startAddr, kv.second);<br>
<br>
Modified: lld/trunk/ELF/Relocations.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Relocations.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Relocations.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Relocations.cpp (original)<br>
+++ lld/trunk/ELF/Relocations.cpp Mon Jul 15 22:50:45 2019<br>
@@ -829,7 +829,7 @@ public:<br>
<br>
// Translates offsets in input sections to offsets in output sections.<br>
// Given offset must increase monotonically. We assume that Piece is<br>
- // sorted by InputOff.<br>
+ // sorted by inputOff.<br>
uint64_t get(uint64_t off) {<br>
if (pieces.empty())<br>
return off;<br>
@@ -859,10 +859,10 @@ static void addRelativeReloc(InputSectio<br>
RelType type) {<br>
Partition &part = isec->getPartition();<br>
<br>
- // Add a relative relocation. If RelrDyn section is enabled, and the<br>
+ // Add a relative relocation. If relrDyn section is enabled, and the<br>
// relocation offset is guaranteed to be even, add the relocation to<br>
- // the RelrDyn section, otherwise add it to the RelaDyn section.<br>
- // RelrDyn sections don't support odd offsets. Also, RelrDyn sections<br>
+ // the relrDyn section, otherwise add it to the relaDyn section.<br>
+ // relrDyn sections don't support odd offsets. Also, relrDyn sections<br>
// don't store the addend values, so we must write it to the relocated<br>
// address.<br>
if (part.relrDyn && isec->alignment >= 2 && offsetInSec % 2 == 0) {<br>
@@ -922,7 +922,7 @@ static bool canDefineSymbolInExecutable(<br>
// executable will preempt it.<br>
// Note that we want the visibility of the shared symbol itself, not<br>
// the visibility of the symbol in the output file we are producing. That is<br>
- // why we use Sym.StOther.<br>
+ // why we use Sym.stOther.<br>
if ((sym.stOther & 0x3) == STV_DEFAULT)<br>
return true;<br>
<br>
@@ -1010,7 +1010,7 @@ static void processRelocAux(InputSection<br>
// Copy relocations (for STT_OBJECT) and canonical PLT (for STT_FUNC) are only<br>
// possible in an executable.<br>
//<br>
- // Among R_ABS relocatoin types, SymbolicRel has the same size as the word<br>
+ // Among R_ABS relocatoin types, symbolicRel has the same size as the word<br>
// size. Others have fewer bits and may cause runtime overflow in -pie/-shared<br>
// mode. Disallow them.<br>
if (config->shared ||<br>
@@ -1237,8 +1237,8 @@ static void scanReloc(InputSectionBase &<br>
// GOT-generating or PLT-generating, the handling of an ifunc is<br>
// relatively straightforward. We create a PLT entry in Iplt, which is<br>
// usually at the end of .plt, which makes an indirect call using a<br>
- // matching GOT entry in IgotPlt, which is usually at the end of .got.plt.<br>
- // The GOT entry is relocated using an IRELATIVE relocation in RelaIplt,<br>
+ // matching GOT entry in igotPlt, which is usually at the end of .got.plt.<br>
+ // The GOT entry is relocated using an IRELATIVE relocation in relaIplt,<br>
// which is usually at the end of .rela.plt. Unlike most relocations in<br>
// .rela.plt, which may be evaluated lazily without -z now, dynamic<br>
// loaders evaluate IRELATIVE relocs eagerly, which means that for<br>
@@ -1274,13 +1274,13 @@ static void scanReloc(InputSectionBase &<br>
// variable containing a pointer to the ifunc) needs to be relocated in<br>
// the exact same way as a GOT entry, so we can avoid needing to make the<br>
// PLT entry canonical by translating such relocations into IRELATIVE<br>
- // relocations in the RelaIplt.<br>
+ // relocations in the relaIplt.<br>
if (!sym.isInPlt()) {<br>
// Create PLT and GOTPLT slots for the symbol.<br>
sym.isInIplt = true;<br>
<br>
// Create a copy of the symbol to use as the target of the IRELATIVE<br>
- // relocation in the IgotPlt. This is in case we make the PLT canonical<br>
+ // relocation in the igotPlt. This is in case we make the PLT canonical<br>
// later, which would overwrite the original symbol.<br>
//<br>
// FIXME: Creating a copy of the symbol here is a bit of a hack. All<br>
@@ -1526,7 +1526,7 @@ void ThunkCreator::mergeThunks(ArrayRef<<br>
<br>
// ISD->ThunkSections contains all created ThunkSections, including<br>
// those inserted in previous passes. Extract the Thunks created this<br>
- // pass and order them in ascending OutSecOff.<br>
+ // pass and order them in ascending outSecOff.<br>
std::vector<ThunkSection *> newThunks;<br>
for (const std::pair<ThunkSection *, uint32_t> ts : isd->thunkSections)<br>
if (ts.second == pass)<br>
@@ -1536,7 +1536,7 @@ void ThunkCreator::mergeThunks(ArrayRef<<br>
return a->outSecOff < b->outSecOff;<br>
});<br>
<br>
- // Merge sorted vectors of Thunks and InputSections by OutSecOff<br>
+ // Merge sorted vectors of Thunks and InputSections by outSecOff<br>
std::vector<InputSection *> tmp;<br>
tmp.reserve(isd->sections.size() + newThunks.size());<br>
<br>
<br>
Modified: lld/trunk/ELF/ScriptParser.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/ScriptParser.h?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/ScriptParser.h?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/ScriptParser.h (original)<br>
+++ lld/trunk/ELF/ScriptParser.h Mon Jul 15 22:50:45 2019<br>
@@ -16,7 +16,7 @@ namespace lld {<br>
namespace elf {<br>
<br>
// Parses a linker script. Calling this function updates<br>
-// Config and ScriptConfig.<br>
+// lld::elf::config and lld::elf::script.<br>
void readLinkerScript(MemoryBufferRef mb);<br>
<br>
// Parses a version script.<br>
<br>
Modified: lld/trunk/ELF/SymbolTable.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SymbolTable.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SymbolTable.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/SymbolTable.cpp (original)<br>
+++ lld/trunk/ELF/SymbolTable.cpp Mon Jul 15 22:50:45 2019<br>
@@ -99,7 +99,7 @@ Symbol *SymbolTable::find(StringRef name<br>
return sym;<br>
}<br>
<br>
-// Initialize DemangledSyms with a map from demangled symbols to symbol<br>
+// Initialize demangledSyms with a map from demangled symbols to symbol<br>
// objects. Used to handle "extern C++" directive in version scripts.<br>
//<br>
// The map will contain all demangled symbols. That can be very large,<br>
@@ -225,7 +225,7 @@ void SymbolTable::assignWildcardVersion(<br>
b->versionId = versionId;<br>
}<br>
<br>
-// This function processes version scripts by updating VersionId<br>
+// This function processes version scripts by updating the versionId<br>
// member of symbols.<br>
// If there's only one anonymous version definition in a version<br>
// script file, the script does not actually define any symbol version,<br>
<br>
Modified: lld/trunk/ELF/SyntheticSections.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SyntheticSections.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SyntheticSections.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/SyntheticSections.cpp (original)<br>
+++ lld/trunk/ELF/SyntheticSections.cpp Mon Jul 15 22:50:45 2019<br>
@@ -579,11 +579,9 @@ void EhFrameSection::writeTo(uint8_t *bu<br>
GotSection::GotSection()<br>
: SyntheticSection(SHF_ALLOC | SHF_WRITE, SHT_PROGBITS, config->wordsize,<br>
".got") {<br>
- // PPC64 saves the ElfSym::GlobalOffsetTable .TOC. as the first entry in the<br>
- // .got. If there are no references to .TOC. in the symbol table,<br>
- // ElfSym::GlobalOffsetTable will not be defined and we won't need to save<br>
- // .TOC. in the .got. When it is defined, we increase NumEntries by the number<br>
- // of entries used to emit ElfSym::GlobalOffsetTable.<br>
+ // If ElfSym::globalOffsetTable is relative to .got and is referenced,<br>
+ // increase numEntries by the number of entries used to emit<br>
+ // ElfSym::globalOffsetTable.<br>
if (ElfSym::globalOffsetTable && !target->gotBaseSymInGotPlt)<br>
numEntries += target->gotHeaderEntriesNum;<br>
}<br>
@@ -861,9 +859,9 @@ void MipsGotSection::build() {<br>
} else {<br>
// If this is the first time we failed to merge with the primary GOT,<br>
// MergedGots.back() will also be the primary GOT. We must make sure not<br>
- // to try to merge again with IsPrimary=false, as otherwise, if the<br>
+ // to try to merge again with isPrimary=false, as otherwise, if the<br>
// inputs are just right, we could allow the primary GOT to become 1 or 2<br>
- // words too big due to ignoring the header size.<br>
+ // words bigger due to ignoring the header size.<br>
if (mergedGots.size() == 1 ||<br>
!tryMergeGots(mergedGots.back(), srcGot, false)) {<br>
mergedGots.emplace_back();<br>
@@ -888,7 +886,7 @@ void MipsGotSection::build() {<br>
for (std::pair<const OutputSection *, FileGot::PageBlock> &p :<br>
got.pagesMap) {<br>
// For each output section referenced by GOT page relocations calculate<br>
- // and save into PagesMap an upper bound of MIPS GOT entries required<br>
+ // and save into pagesMap an upper bound of MIPS GOT entries required<br>
// to store page addresses of local symbols. We assume the worst case -<br>
// each 64kb page of the output section has at least one GOT relocation<br>
// against it. And take in account the case when the section intersects<br>
@@ -910,7 +908,7 @@ void MipsGotSection::build() {<br>
}<br>
}<br>
<br>
- // Update Symbol::GotIndex field to use this<br>
+ // Update Symbol::gotIndex field to use this<br>
// value later in the `sortMipsSymbols` function.<br>
for (auto &p : primGot->global)<br>
p.first->gotIndex = p.second;<br>
@@ -936,7 +934,7 @@ void MipsGotSection::build() {<br>
} else {<br>
// When building a shared library we still need a dynamic relocation<br>
// for the module index. Therefore only checking for<br>
- // S->IsPreemptible is not sufficient (this happens e.g. for<br>
+ // S->isPreemptible is not sufficient (this happens e.g. for<br>
// thread-locals that have been marked as local through a linker script)<br>
if (!s->isPreemptible && !config->isPic)<br>
continue;<br>
@@ -1140,7 +1138,7 @@ StringTableSection::StringTableSection(S<br>
addString("");<br>
}<br>
<br>
-// Adds a string to the string table. If HashIt is true we hash and check for<br>
+// Adds a string to the string table. If `hashIt` is true we hash and check for<br>
// duplicates. It is optional because the name of global symbols are already<br>
// uniqued and hashing them again has a big cost for a small value: uniquing<br>
// them with some other string that happens to be the same.<br>
@@ -1335,9 +1333,9 @@ template <class ELFT> void DynamicSectio<br>
}<br>
// .rel[a].plt section usually consists of two parts, containing plt and<br>
// iplt relocations. It is possible to have only iplt relocations in the<br>
- // output. In that case RelaPlt is empty and have zero offset, the same offset<br>
- // as RelaIplt have. And we still want to emit proper dynamic tags for that<br>
- // case, so here we always use RelaPlt as marker for the begining of<br>
+ // output. In that case relaPlt is empty and have zero offset, the same offset<br>
+ // as relaIplt has. And we still want to emit proper dynamic tags for that<br>
+ // case, so here we always use relaPlt as marker for the begining of<br>
// .rel[a].plt section.<br>
if (isMain && (in.relaPlt->isNeeded() || in.relaIplt->isNeeded())) {<br>
addInSec(DT_JMPREL, in.relaPlt);<br>
@@ -2365,7 +2363,7 @@ void PltSection::writeTo(uint8_t *buf) {<br>
<br>
RelocationBaseSection *relSec = isIplt ? in.relaIplt : in.relaPlt;<br>
<br>
- // The IPlt is immediately after the Plt, account for this in RelOff<br>
+ // The IPlt is immediately after the Plt, account for this in relOff<br>
size_t pltOff = isIplt ? in.plt->getSize() : 0;<br>
<br>
for (size_t i = 0, e = entries.size(); i != e; ++i) {<br>
@@ -2491,9 +2489,9 @@ readPubNamesAndTypes(const LLDDwarfObj<E<br>
for (const DWARFSection *pub : {&pubNames, &pubTypes}) {<br>
DWARFDebugPubTable table(obj, *pub, config->isLE, true);<br>
for (const DWARFDebugPubTable::Set &set : table.getData()) {<br>
- // The value written into the constant pool is Kind << 24 | CuIndex. As we<br>
+ // The value written into the constant pool is kind << 24 | cuIndex. As we<br>
// don't know how many compilation units precede this object to compute<br>
- // CuIndex, we compute (Kind << 24 | CuIndexInThisObject) instead, and add<br>
+ // cuIndex, we compute (kind << 24 | cuIndexInThisObject) instead, and add<br>
// the number of preceding compilation units later.<br>
uint32_t i =<br>
lower_bound(cUs, set.Offset,<br>
@@ -2945,7 +2943,7 @@ void MergeTailSection::finalizeContents(<br>
<br>
// finalize() fixed tail-optimized strings, so we can now get<br>
// offsets of strings. Get an offset for each string and save it<br>
- // to a corresponding StringPiece for easy access.<br>
+ // to a corresponding SectionPiece for easy access.<br>
for (MergeInputSection *sec : sections)<br>
for (size_t i = 0, e = sec->pieces.size(); i != e; ++i)<br>
if (sec->pieces[i].live)<br>
@@ -3330,7 +3328,7 @@ bool PPC32Got2Section::isNeeded() const<br>
<br>
void PPC32Got2Section::finalizeContents() {<br>
// PPC32 may create multiple GOT sections for -fPIC/-fPIE, one per file in<br>
- // .got2 . This function computes OutSecOff of each .got2 to be used in<br>
+ // .got2 . This function computes outSecOff of each .got2 to be used in<br>
// PPC32PltCallStub::writeTo(). The purpose of this empty synthetic section is<br>
// to collect input sections named ".got2".<br>
uint32_t offset = 0;<br>
<br>
Modified: lld/trunk/ELF/SyntheticSections.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SyntheticSections.h?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SyntheticSections.h?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/SyntheticSections.h (original)<br>
+++ lld/trunk/ELF/SyntheticSections.h Mon Jul 15 22:50:45 2019<br>
@@ -434,8 +434,8 @@ public:<br>
uint32_t getSymIndex(SymbolTableBaseSection *symTab) const;<br>
<br>
// Computes the addend of the dynamic relocation. Note that this is not the<br>
- // same as the Addend member variable as it also includes the symbol address<br>
- // if UseSymVA is true.<br>
+ // same as the addend member variable as it also includes the symbol address<br>
+ // if useSymVA is true.<br>
int64_t computeAddend() const;<br>
<br>
RelType type;<br>
@@ -1026,7 +1026,7 @@ private:<br>
// thunks including ARM interworking and Mips LA25 PI to non-PI thunks.<br>
class ThunkSection : public SyntheticSection {<br>
public:<br>
- // ThunkSection in OS, with desired OutSecOff of Off<br>
+ // ThunkSection in OS, with desired outSecOff of Off<br>
ThunkSection(OutputSection *os, uint64_t off);<br>
<br>
// Add a newly created Thunk to this container:<br>
@@ -1044,7 +1044,7 @@ private:<br>
size_t size = 0;<br>
};<br>
<br>
-// Used to compute OutSecOff of .got2 in each object file. This is needed to<br>
+// Used to compute outSecOff of .got2 in each object file. This is needed to<br>
// synthesize PLT entries for PPC32 Secure PLT ABI.<br>
class PPC32Got2Section final : public SyntheticSection {<br>
public:<br>
<br>
Modified: lld/trunk/ELF/Target.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.h?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.h?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Target.h (original)<br>
+++ lld/trunk/ELF/Target.h Mon Jul 15 22:50:45 2019<br>
@@ -73,7 +73,7 @@ public:<br>
virtual bool adjustPrologueForCrossSplitStack(uint8_t *loc, uint8_t *end,<br>
uint8_t stOther) const;<br>
<br>
- // Return true if we can reach Dst from Src with Relocation RelocType<br>
+ // Return true if we can reach dst from src with RelType type.<br>
virtual bool inBranchRange(RelType type, uint64_t src,<br>
uint64_t dst) const;<br>
<br>
<br>
Modified: lld/trunk/ELF/Thunks.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Thunks.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Thunks.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Thunks.cpp (original)<br>
+++ lld/trunk/ELF/Thunks.cpp Mon Jul 15 22:50:45 2019<br>
@@ -388,7 +388,7 @@ static uint64_t getARMThunkDestVA(const<br>
}<br>
<br>
// This function returns true if the target is not Thumb and is within 2^26, and<br>
-// it has not previously returned false (see comment for MayUseShortThunk).<br>
+// it has not previously returned false (see comment for mayUseShortThunk).<br>
bool ARMThunk::getMayUseShortThunk() {<br>
if (!mayUseShortThunk)<br>
return false;<br>
@@ -426,7 +426,7 @@ bool ARMThunk::isCompatibleWith(const In<br>
}<br>
<br>
// This function returns true if the target is Thumb and is within 2^25, and<br>
-// it has not previously returned false (see comment for MayUseShortThunk).<br>
+// it has not previously returned false (see comment for mayUseShortThunk).<br>
bool ThumbThunk::getMayUseShortThunk() {<br>
if (!mayUseShortThunk)<br>
return false;<br>
<br>
Modified: lld/trunk/ELF/Writer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Writer.cpp (original)<br>
+++ lld/trunk/ELF/Writer.cpp Mon Jul 15 22:50:45 2019<br>
@@ -504,7 +504,7 @@ template <class ELFT> static void create<br>
config->isRela ? ".rela.plt" : ".rel.plt", /*sort=*/false);<br>
add(in.relaPlt);<br>
<br>
- // The RelaIplt immediately follows .rel.plt (.rel.dyn for ARM) to ensure<br>
+ // The relaIplt immediately follows .rel.plt (.rel.dyn for ARM) to ensure<br>
// that the IRelative relocations are processed last by the dynamic loader.<br>
// We cannot place the iplt section in .rel.dyn when Android relocation<br>
// packing is enabled because that would cause a section type mismatch.<br>
@@ -1023,7 +1023,7 @@ template <class ELFT> void Writer<ELFT>:<br>
<br>
// By default, __rela_iplt_{start,end} belong to a dummy section 0<br>
// because .rela.plt might be empty and thus removed from output.<br>
- // We'll override Out::ElfHeader with In.RelaIplt later when we are<br>
+ // We'll override Out::elfHeader with In.relaIplt later when we are<br>
// sure that .rela.plt exists in output.<br>
ElfSym::relaIpltStart = addOptionalRegular(<br>
config->isRela ? "__rela_iplt_start" : "__rel_iplt_start",<br>
@@ -1424,7 +1424,7 @@ template <class ELFT> void Writer<ELFT>:<br>
continue;<br>
os->sortRank = getSectionRank(os);<br>
<br>
- // We want to assign rude approximation values to OutSecOff fields<br>
+ // We want to assign rude approximation values to outSecOff fields<br>
// to know the relative order of the input sections. We use it for<br>
// sorting SHF_LINK_ORDER sections. See resolveShfLinkOrder().<br>
uint64_t i = 0;<br>
@@ -1884,7 +1884,7 @@ template <class ELFT> void Writer<ELFT>:<br>
finalizeSynthetic(in.partIndex);<br>
<br>
// Dynamic section must be the last one in this list and dynamic<br>
- // symbol table section (DynSymTab) must be the first one.<br>
+ // symbol table section (dynSymTab) must be the first one.<br>
for (Partition &part : partitions) {<br>
finalizeSynthetic(part.armExidx);<br>
finalizeSynthetic(part.dynSymTab);<br>
<br>
Modified: lld/trunk/test/ELF/Inputs/gdb-index-multiple-cu-2.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/Inputs/gdb-index-multiple-cu-2.s?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/Inputs/gdb-index-multiple-cu-2.s?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/test/ELF/Inputs/gdb-index-multiple-cu-2.s (original)<br>
+++ lld/trunk/test/ELF/Inputs/gdb-index-multiple-cu-2.s Mon Jul 15 22:50:45 2019<br>
@@ -31,7 +31,7 @@ _start:<br>
.byte 0<br>
.Lcu_end0:<br>
<br>
-# .debug_gnu_pubnames has just one set, associated with .Lcu_begin1 (CuIndex: 1)<br>
+# .debug_gnu_pubnames has just one set, associated with .Lcu_begin1 (cuIndex: 1)<br>
.section .debug_gnu_pubnames,"",@progbits<br>
.long .LpubNames_end0 - .LpubNames_begin0<br>
.LpubNames_begin0:<br>
<br>
Modified: lld/trunk/test/ELF/gdb-index-multiple-cu-2.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/gdb-index-multiple-cu-2.s?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/gdb-index-multiple-cu-2.s?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/test/ELF/gdb-index-multiple-cu-2.s (original)<br>
+++ lld/trunk/test/ELF/gdb-index-multiple-cu-2.s Mon Jul 15 22:50:45 2019<br>
@@ -4,8 +4,8 @@<br>
# RUN: ld.lld --gdb-index %t.o %t1.o -o %t<br>
# RUN: llvm-dwarfdump -gdb-index %t | FileCheck %s<br>
<br>
-# %t.o has 2 CUs while %t1 has 1, thus _start in %t1.o should have CuIndex 2.<br>
-# Attributes << 24 | CuIndex = 48 << 24 | 2 = 0x30000002<br>
+# %t.o has 2 CUs while %t1 has 1, thus _start in %t1.o should have cuIndex 2.<br>
+# attributes << 24 | cuIndex = 48 << 24 | 2 = 0x30000002<br>
# CHECK: Constant pool<br>
# CHECK-NEXT: 0(0x0): 0x30000002<br>
<br>
<br>
Modified: lld/trunk/test/ELF/gdb-index-multiple-cu.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/gdb-index-multiple-cu.s?rev=366181&r1=366180&r2=366181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/gdb-index-multiple-cu.s?rev=366181&r1=366180&r2=366181&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/test/ELF/gdb-index-multiple-cu.s (original)<br>
+++ lld/trunk/test/ELF/gdb-index-multiple-cu.s Mon Jul 15 22:50:45 2019<br>
@@ -3,10 +3,10 @@<br>
# RUN: ld.lld --gdb-index %t.o -o %t<br>
# RUN: llvm-dwarfdump -gdb-index %t | FileCheck %s<br>
<br>
-# CuIndexAndAttrs of _start:<br>
-# Attributes << 24 | CuIndex = 48 << 24 | 0 = 0x30000000<br>
-# CuIndexAndAttrs of foo:<br>
-# Attributes << 24 | CuIndex = 48 << 24 | 1 = 0x30000001<br>
+# cuIndexAndAttrs of _start:<br>
+# attributes << 24 | cuIndex = 48 << 24 | 0 = 0x30000000<br>
+# cuIndexAndAttrs of foo:<br>
+# attributes << 24 | cuIndex = 48 << 24 | 1 = 0x30000001<br>
# CHECK: Symbol table<br>
# CHECK-DAG: String name: _start, CU vector index: 0<br>
# CHECK-DAG: String name: foo, CU vector index: 1<br>
@@ -63,7 +63,7 @@ foo:<br>
# Swap sets to test the case where pubnames are in a<br>
# different order than the CUs they refer to.<br>
.section .debug_gnu_pubnames,"",@progbits<br>
- # CuIndex: 1<br>
+ # cuIndex: 1<br>
.long .LpubNames_end1 - .LpubNames_begin1<br>
.LpubNames_begin1:<br>
.short 2 # Version<br>
@@ -75,7 +75,7 @@ foo:<br>
.long 0<br>
.LpubNames_end1:<br>
<br>
- # CuIndex: 0<br>
+ # cuIndex: 0<br>
.long .LpubNames_end0 - .LpubNames_begin0<br>
.LpubNames_begin0:<br>
.short 2 # Version<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>