<div dir="auto">Agreed. </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jul 12, 2019, 9:54 AM Nikita Popov via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">nikic added inline comments.<br>
Herald added a subscriber: wuzish.<br>
<br>
<br>
================<br>
Comment at: compiler-rt/trunk/lib/builtins/arm/sync-ops.h:37<br>
+  DEFINE_COMPILERRT_THUMB_FUNCTION(__sync_fetch_and_##op)                      \<br>
+  push{r4, r5, r6, lr};                                                        \<br>
+  dmb;                                                                         \<br>
----------------<br>
It looks like this reformatted to illegal assembly:<br>
<br>
```<br>
compiler-rt/lib/builtins/arm/sync_fetch_and_add_8.S:21: Error: bad instruction `push{r4, r5,r6,lr}'<br>
```<br>
<br>
The whitespace between `push` and `{` likely needs to be preserved.<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D60351/new/" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D60351/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D60351" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D60351</a><br>
<br>
<br>
<br>
</blockquote></div>