<div dir="ltr"><a href="https://reviews.llvm.org/D63831">https://reviews.llvm.org/D63831</a> should have the necessary fixes, I put you guys as reviewers as well, thanks!<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jun 26, 2019 at 10:37 AM Kostya Kortchinsky <<a href="mailto:kostyak@google.com">kostyak@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Sorry about that, working on a fix!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jun 26, 2019 at 2:47 AM Hans Wennborg <<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">It broke Chromium's build too:<br>
<a href="https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8909601197093055184/+/steps/gclient_runhooks/0/stdout" rel="noreferrer" target="_blank">https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8909601197093055184/+/steps/gclient_runhooks/0/stdout</a><br>
<br>
I've reverted in r364400.<br>
<br>
On Wed, Jun 26, 2019 at 4:07 AM via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Hi Kostya,<br>
><br>
> This commit failed to build on our internal build bot. The build is bot is running linux and using gcc 5.4.0 to build which results in the following error:<br>
><br>
> FAILED: CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/lib/ccache/g++ -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iprojects/compiler-rt/lib/scudo/standalone -I/home/siadmin/jenkins/w/opensource/opensource_build/llvm/projects/compiler-rt/lib/scudo/standalone -Iinclude -I/home/siadmin/jenkins/w/opensource/opensource_build/llvm/include -I/home/siadmin/jenkins/w/opensource/opensource_build/llvm/projects/compiler-rt/lib/scudo/standalone/../.. -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -std=c++11 -Wno-unused-parameter -O3 -UNDEBUG -m64 -Wall -nostdinc++ -ffreestanding -fvisibility=hidden -O3 -MMD -MT projects/compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandaloneCWrappers.x86_64.dir/wrappers_c.cc.o -MF projects/compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandaloneCWrappers.x86_64.dir/wrappers_c.cc.o.d -o projects/compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandaloneCWrappers.x86_64.dir/wrappers_c.cc.o -c /home/siadmin/jenkins/w/opensource/opensource_build/llvm/projects/compiler-rt/lib/scudo/standalone/wrappers_c.cc<br>
> In file included from /home/siadmin/jenkins/w/opensource/opensource_build/llvm/projects/compiler-rt/lib/scudo/standalone/wrappers_c.cc:31:0:<br>
> /home/siadmin/jenkins/w/opensource/opensource_build/llvm/projects/compiler-rt/lib/scudo/standalone/wrappers_c.inc: In function 'void* calloc(size_t, size_t)':<br>
> /home/siadmin/jenkins/w/opensource/opensource_build/llvm/projects/compiler-rt/lib/scudo/standalone/wrappers_c.inc:20:68: error: declaration of 'void* calloc(size_t, size_t)' has a different exception specifier<br>
> INTERFACE WEAK void *SCUDO_PREFIX(calloc)(size_t nmemb, size_t size) {<br>
> ^<br>
> In file included from /home/siadmin/jenkins/w/opensource/opensource_build/llvm/projects/compiler-rt/lib/scudo/standalone/flags_parser.h:16:0,<br>
> from /home/siadmin/jenkins/w/opensource/opensource_build/llvm/projects/compiler-rt/lib/scudo/standalone/combined.h:15,<br>
> from /home/siadmin/jenkins/w/opensource/opensource_build/llvm/projects/compiler-rt/lib/scudo/standalone/allocator_config.h:12,<br>
> from /home/siadmin/jenkins/w/opensource/opensource_build/llvm/projects/compiler-rt/lib/scudo/standalone/wrappers_c.cc:14:<br>
> /usr/include/stdlib.h:468:14: error: from previous declaration 'void* calloc(size_t, size_t) throw ()'<br>
> extern void *calloc (size_t __nmemb, size_t __size)<br>
> ^<br>
><br>
> Identical compiler errors are emitted for your definitions of calloc, free, malloc, posix_memalign, realloc, valloc, and aligned_alloc.<br>
><br>
> Can you take a look?<br>
><br>
> Douglas Yung<br>
><br>
> -----Original Message-----<br>
> From: llvm-commits <<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a>> On Behalf Of Kostya Kortchinsky via llvm-commits<br>
> Sent: Tuesday, June 25, 2019 9:51<br>
> To: <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> Subject: [compiler-rt] r364332 - [scudo][standalone] Introduce the C & C++ wrappers<br>
><br>
> Author: cryptoad<br>
> Date: Tue Jun 25 09:51:27 2019<br>
> New Revision: 364332<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=364332&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=364332&view=rev</a><br>
> Log:<br>
> [scudo][standalone] Introduce the C & C++ wrappers<br>
><br>
> Summary:<br>
> This CL adds C & C++ wrappers and associated tests. Those use default configurations for a Scudo combined allocator that will likely be tweaked in the future.<br>
><br>
> This is the final CL required to have a functional C & C++ allocator based on Scudo.<br>
><br>
> The structure I have chosen is to define the core C allocation primitives in an `.inc` file that can be customized through defines.<br>
> This allows to easily have 2 (or more) sets of wrappers backed by different combined allocators, as demonstrated by the `Bionic`<br>
> wrappers: one set for the "default" allocator, one set for the "svelte"<br>
> allocator.<br>
><br>
> Currently all the tests added have been gtests, but I am planning to add some more lit tests as well.<br>
><br>
> Reviewers: morehouse, eugenis, vitalybuka, hctim, rengolin<br>
><br>
> Reviewed By: morehouse<br>
><br>
> Subscribers: srhines, mgorny, delcypher, jfb, #sanitizers, llvm-commits<br>
><br>
> Tags: #llvm, #sanitizers<br>
><br>
> Differential Revision: <a href="https://reviews.llvm.org/D63612" rel="noreferrer" target="_blank">https://reviews.llvm.org/D63612</a><br>
</blockquote></div>
</blockquote></div>