<div dir="ltr">Thanks again<div>(testcase was fixed and recommited)</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">pi 21. 6. 2019 o 20:00 Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com">lebedev.ri@gmail.com</a>> napísal(a):<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">That's great, what i'm saying is that the current test coverage is<br>
broken, as you can see.<br>
<br>
On Fri, Jun 21, 2019 at 8:45 PM Dávid Bolvanský<br>
<<a href="mailto:david.bolvansky@gmail.com" target="_blank">david.bolvansky@gmail.com</a>> wrote:<br>
><br>
> This case will fold.<br>
><br>
> define <3 x i64> @shl_sub_i64_vec_undef1(<3 x i64> %x) {<br>
> ; CHECK-LABEL: @shl_sub_i64_vec_undef1(<br>
> ; CHECK-NEXT: [[R:%.*]] = lshr <3 x i64> <i64 -9223372036854775808, i64 -9223372036854775808, i64 -9223372036854775808>, [[X:%.*]]<br>
> ; CHECK-NEXT: ret <3 x i64> [[R]]<br>
> ;<br>
> %s = sub <3 x i64> <i64 63, i64 63, i64 63>, %x<br>
> %r = shl <3 x i64> <i64 1, i64 undef, i64 1>, %s<br>
> ret <3 x i64> %r<br>
> }<br>
><br>
> pi 21. 6. 2019 o 18:33 Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com" target="_blank">lebedev.ri@gmail.com</a>> napísal(a):<br>
>><br>
>> On Fri, Jun 21, 2019 at 7:10 PM David Bolvansky via llvm-commits<br>
>> <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
>> ><br>
>> > Author: xbolva00<br>
>> > Date: Fri Jun 21 09:14:13 2019<br>
>> > New Revision: 364069<br>
>> ><br>
>> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=364069&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=364069&view=rev</a><br>
>> > Log:<br>
>> > [NFC] Added more tests for D63652<br>
>> ><br>
>> > Modified:<br>
>> > llvm/trunk/test/Transforms/InstCombine/shl-sub.ll<br>
>> ><br>
>> > Modified: llvm/trunk/test/Transforms/InstCombine/shl-sub.ll<br>
>> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/shl-sub.ll?rev=364069&r1=364068&r2=364069&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/shl-sub.ll?rev=364069&r1=364068&r2=364069&view=diff</a><br>
>> > ==============================================================================<br>
>> > --- llvm/trunk/test/Transforms/InstCombine/shl-sub.ll (original)<br>
>> > +++ llvm/trunk/test/Transforms/InstCombine/shl-sub.ll Fri Jun 21 09:14:13 2019<br>
>> > @@ -148,5 +148,38 @@ define <2 x i64> @bad_shl_sub_i64_vec(<2<br>
>> > ret <2 x i64> %r<br>
>> > }<br>
>> ><br>
>> > +define <3 x i64> @shl_sub_i64_vec_undef0(<3 x i64> %x) {<br>
>> > +; CHECK-LABEL: @shl_sub_i64_vec_undef0(<br>
>> > +; CHECK-NEXT: [[S:%.*]] = sub <3 x i64> <i64 63, i64 undef, i64 63>, [[X:%.*]]<br>
>> > +; CHECK-NEXT: [[R:%.*]] = shl <3 x i64> <i64 1, i64 1, i64 1>, [[S]]<br>
>> > +; CHECK-NEXT: ret <3 x i64> [[R]]<br>
>> > +;<br>
>> > + %s = sub <3 x i64> <i64 63, i64 undef, i64 63>, %x<br>
>> > + %r = shl <3 x i64> <i64 1, i64 1, i64 1>, %s<br>
>> > + ret <3 x i64> %r<br>
>> > +}<br>
>> > +<br>
>> > +define <3 x i64> @shl_sub_i64_vec_undef1(<3 x i64> %x) {<br>
>> > +; CHECK-LABEL: @shl_sub_i64_vec_undef1(<br>
>> > +; CHECK-NEXT: [[S:%.*]] = sub <3 x i64> <i64 63, i64 undef, i64 63>, [[X:%.*]]<br>
>> > +; CHECK-NEXT: [[R:%.*]] = shl <3 x i64> <i64 1, i64 undef, i64 1>, [[S]]<br>
>> > +; CHECK-NEXT: ret <3 x i64> [[R]]<br>
>> > +;<br>
>> > + %s = sub <3 x i64> <i64 63, i64 undef, i64 63>, %x<br>
>> > + %r = shl <3 x i64> <i64 1, i64 undef, i64 1>, %s<br>
>> I messed this up i guess, here only the second undef should be here<br>
>><br>
>> > + ret <3 x i64> %r<br>
>> > +}<br>
>> > +<br>
>> > +define <3 x i64> @shl_sub_i64_vec_undef2(<3 x i64> %x) {<br>
>> > +; CHECK-LABEL: @shl_sub_i64_vec_undef2(<br>
>> > +; CHECK-NEXT: [[S:%.*]] = sub <3 x i64> <i64 63, i64 undef, i64 63>, [[X:%.*]]<br>
>> > +; CHECK-NEXT: [[R:%.*]] = shl <3 x i64> <i64 1, i64 undef, i64 1>, [[S]]<br>
>> > +; CHECK-NEXT: ret <3 x i64> [[R]]<br>
>> > +<br>
>> > + %s = sub <3 x i64> <i64 63, i64 undef, i64 63>, %x<br>
>> > + %r = shl <3 x i64> <i64 1, i64 undef, i64 1>, %s<br>
>> > + ret <3 x i64> %r<br>
>> This test is identical to @shl_sub_i64_vec_undef1<br>
>><br>
>> > +}<br>
>> > +<br>
>> ><br>
>> > declare void @use(i32)<br>
>> Roman<br>
>><br>
>> ><br>
>> > _______________________________________________<br>
>> > llvm-commits mailing list<br>
>> > <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
>> > <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>