<div dir="ltr">Should be fixed with <a href="https://reviews.llvm.org/rL363805">https://reviews.llvm.org/rL363805</a></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jun 19, 2019 at 6:42 AM Max Moroz <<a href="mailto:mmoroz@google.com">mmoroz@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div dir="auto">Hi Yvan,</div></div><div dir="auto"><br></div><div dir="auto">Thanks for letting me know! I'll fix this soon, and sorry for the breakage.</div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jun 19, 2019 at 05:36 Yvan Roux <<a href="mailto:yvan.roux@linaro.org" target="_blank">yvan.roux@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Max,<br>
<br>
This commit broke AArch64 bots, ninja check2 output is:<br>
<br>
[39/697] Generating<br>
FuzzedDataProviderTestObjects.FuzzedDataProviderUnittest.cpp.aarch64.o<br>
FAILED: projects/compiler-rt/lib/fuzzer/tests/FuzzedDataProviderTestObjects.FuzzedDataProviderUnittest.cpp.aarch64.o<br>
cd /home/buildslave/buildslave/clang-cmake-aarch64-full/stage2/projects/compiler-rt/lib/fuzzer/tests<br>
&& /home/buildslave/buildslave/clang-cmake-aarch64-full/stage2/./bin/clang<br>
-mcpu=cortex-a57 -fPIC -fvisibility-inlines-hidden -Werror=date-time<br>
-Werror=unguarded-availability-new -std=c++11 -Wall -Wextra<br>
-Wno-unused-parameter -Wwrite-strings -Wcast-qual<br>
-Wmissing-field-initializers -pedantic -Wno-long-long<br>
-Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type<br>
-Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion<br>
-fdiagnostics-color -ffunction-sections -fdata-sections -Wall<br>
-std=c++11 -Wno-unused-parameter -Wno-unknown-warning-option<br>
-Wno-covered-switch-default -DGTEST_NO_LLVM_RAW_OSTREAM=1<br>
-DGTEST_HAS_RTTI=0<br>
-I/home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/utils/unittest/googletest/include<br>
-I/home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/utils/unittest/googletest<br>
-I/home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/projects/compiler-rt/lib/fuzzer<br>
-fno-rtti -O2 -fvisibility=hidden -march=armv8-a -c -o<br>
FuzzedDataProviderTestObjects.FuzzedDataProviderUnittest.cpp.aarch64.o<br>
/home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/projects/compiler-rt/lib/fuzzer/tests/FuzzedDataProviderUnittest.cpp<br>
In file included from<br>
/home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/projects/compiler-rt/lib/fuzzer/tests/FuzzedDataProviderUnittest.cpp:9:<br>
/home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/projects/compiler-rt/lib/fuzzer/utils/FuzzedDataProvider.h:226:5:<br>
error: static_assert failed due to requirement<br>
'std::numeric_limits<char>::is_signed' "Destination type must be<br>
signed."<br>
    static_assert(std::numeric_limits<TS>::is_signed,<br>
    ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
/home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/projects/compiler-rt/lib/fuzzer/utils/FuzzedDataProvider.h:126:19:<br>
note: in instantiation of function template specialization<br>
'FuzzedDataProvider::ConvertUnsignedToSigned<char, unsigned char>'<br>
requested here<br>
      char next = ConvertUnsignedToSigned<char>(data_ptr_[0]);<br>
                  ^<br>
1 error generated.<br>
<br>
logs are availabe here:<br>
<a href="http://lab.llvm.org:8011/waterfall?show=clang-cmake-aarch64-full" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/waterfall?show=clang-cmake-aarch64-full</a><br>
<br>
Thanks,<br>
Yvan<br>
<br>
On Tue, 18 Jun 2019 at 22:26, Max Moroz via Phabricator via<br>
llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> This revision was automatically updated to reflect the committed changes.<br>
> Closed by commit rL363735: [libFuzzer] Improve FuzzedDataProvider helper. (authored by Dor1s, committed by ).<br>
><br>
> Repository:<br>
>   rL LLVM<br>
><br>
> CHANGES SINCE LAST ACTION<br>
>   <a href="https://reviews.llvm.org/D63348/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D63348/new/</a><br>
><br>
> <a href="https://reviews.llvm.org/D63348" rel="noreferrer" target="_blank">https://reviews.llvm.org/D63348</a><br>
><br>
> Files:<br>
>   compiler-rt/trunk/lib/fuzzer/tests/FuzzedDataProviderUnittest.cpp<br>
>   compiler-rt/trunk/lib/fuzzer/utils/FuzzedDataProvider.h<br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>-- <br><div dir="ltr" class="gmail-m_8753775428077385377gmail_signature">Max<br>Sent from a phone</div>
</blockquote></div>