<div dir="ltr">Attempted a fix in r363445.<div>FTR: libFuzzer *is* currently supported on windows. <a class="gmail_plusreply" id="plusReplyChip-1" href="mailto:metzman@google.com" tabindex="-1">+Jonathan Metzman</a> </div><div>This particular functionality is not, but obviously I should not break the windows build :)</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jun 14, 2019 at 9:57 AM Kostya Serebryany <<a href="mailto:kcc@google.com">kcc@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">thanks for the revert! </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jun 14, 2019 at 12:29 AM Hans Wennborg <<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Jun 14, 2019 at 8:46 AM Martin Storsjö via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> On Thu, 13 Jun 2019, Kostya Serebryany via llvm-commits wrote:<br>
><br>
> > Author: kcc<br>
> > Date: Thu Jun 13 14:17:49 2019<br>
> > New Revision: 363326<br>
> ><br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=363326&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=363326&view=rev</a><br>
> > Log:<br>
> > [libFuzzer] simplify the DFT trace collection using the new faster DFSan mode that traces up to 16 labels at a time and never runs out of labels.<br>
> ><br>
> > Added:<br>
> >    compiler-rt/trunk/test/fuzzer/Labels20Test.cpp<br>
> > Modified:<br>
> >    compiler-rt/trunk/lib/fuzzer/FuzzerDataFlowTrace.cpp<br>
> >    compiler-rt/trunk/lib/fuzzer/FuzzerFork.cpp<br>
> >    compiler-rt/trunk/lib/fuzzer/dataflow/DataFlow.cpp<br>
> >    compiler-rt/trunk/test/fuzzer/OnlySomeBytesTest.cpp<br>
> >    compiler-rt/trunk/test/fuzzer/dataflow.test<br>
> ><br>
> > Modified: compiler-rt/trunk/lib/fuzzer/FuzzerDataFlowTrace.cpp<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/fuzzer/FuzzerDataFlowTrace.cpp?rev=363326&r1=363325&r2=363326&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/fuzzer/FuzzerDataFlowTrace.cpp?rev=363326&r1=363325&r2=363326&view=diff</a><br>
> > ==============================================================================<br>
> > --- compiler-rt/trunk/lib/fuzzer/FuzzerDataFlowTrace.cpp (original)<br>
> > +++ compiler-rt/trunk/lib/fuzzer/FuzzerDataFlowTrace.cpp Thu Jun 13 14:17:49 2019<br>
><br>
> > @@ -246,74 +240,24 @@ int CollectDataFlow(const std::string &D<br>
> >                     const Vector<SizedFile> &CorporaFiles) {<br>
> >   Printf("INFO: collecting data flow: bin: %s dir: %s files: %zd\n",<br>
> >          DFTBinary.c_str(), DirPath.c_str(), CorporaFiles.size());<br>
> > +  setenv("DFSAN_OPTIONS", "fast16labels=1:warn_unimplemented=0", 1);<br>
> >   MkDir(DirPath);<br>
><br>
> On windows, setenv isn't available - only putenv is. While libfuzzer might<br>
> not actually support windows, it's still being built, at least for MinGW.<br>
<br>
Also for MSVC. I've reverted in r363358 until this can be figured out.<br>
</blockquote></div>
</blockquote></div>