<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 4, 2019, 10:10 AM Simon Pilgrim via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>AFAICT it was reverted at rL362453</p></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Ah, thanks, even better!</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF">
<div class="m_299254261269421483moz-cite-prefix">On 04/06/2019 09:05, Aaron Ballman via
llvm-commits wrote:<br>
</div>
<blockquote type="cite">
<div dir="auto">
<div>Did you intend to commit this? (It looks reasonable, but
the commit message gave me pause).</div>
<div dir="auto"><br>
</div>
<div dir="auto">~Aaron<br>
<br>
<div class="gmail_quote" dir="auto">
<div dir="ltr" class="gmail_attr">On Tue, Jun 4, 2019, 12:08
AM Craig Topper via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" rel="noreferrer">llvm-commits@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author:
ctopper<br>
Date: Mon Jun 3 15:11:30 2019<br>
New Revision: 362451<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=362451&view=rev" rel="noreferrer noreferrer noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=362451&view=rev</a><br>
Log:<br>
foo<br>
<br>
Modified:<br>
llvm/trunk/test/CodeGen/X86/bmi.ll<br>
<br>
Modified: llvm/trunk/test/CodeGen/X86/bmi.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/bmi.ll?rev=362451&r1=362450&r2=362451&view=diff" rel="noreferrer noreferrer noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/bmi.ll?rev=362451&r1=362450&r2=362451&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/X86/bmi.ll (original)<br>
+++ llvm/trunk/test/CodeGen/X86/bmi.ll Mon Jun 3 15:11:30
2019<br>
@@ -1149,3 +1149,77 @@ define i64 @blsr64_branch(i64 %x) {<br>
}<br>
<br>
declare void @bar()<br>
+<br>
+define void @pr42118_i32(i32 %x) {<br>
+; X86-LABEL: pr42118_i32:<br>
+; X86: # %bb.0:<br>
+; X86-NEXT: blsrl {{[0-9]+}}(%esp), %eax<br>
+; X86-NEXT: jne .LBB48_1<br>
+; X86-NEXT: # %bb.2:<br>
+; X86-NEXT: jmp bar # TAILCALL<br>
+; X86-NEXT: .LBB48_1:<br>
+; X86-NEXT: retl<br>
+;<br>
+; X64-LABEL: pr42118_i32:<br>
+; X64: # %bb.0:<br>
+; X64-NEXT: blsrl %edi, %eax<br>
+; X64-NEXT: jne .LBB48_1<br>
+; X64-NEXT: # %bb.2:<br>
+; X64-NEXT: jmp bar # TAILCALL<br>
+; X64-NEXT: .LBB48_1:<br>
+; X64-NEXT: retq<br>
+ %tmp = sub i32 0, %x<br>
+ %tmp1 = and i32 %tmp, %x<br>
+ %cmp = icmp eq i32 %tmp1, %x<br>
+ br i1 %cmp, label %1, label %2<br>
+<br>
+ tail call void @bar()<br>
+ br label %2<br>
+<br>
+ ret void<br>
+}<br>
+<br>
+define void @pr42118_i64(i64 %x) {<br>
+; X86-LABEL: pr42118_i64:<br>
+; X86: # %bb.0:<br>
+; X86-NEXT: pushl %esi<br>
+; X86-NEXT: .cfi_def_cfa_offset 8<br>
+; X86-NEXT: .cfi_offset %esi, -8<br>
+; X86-NEXT: movl {{[0-9]+}}(%esp), %eax<br>
+; X86-NEXT: movl {{[0-9]+}}(%esp), %ecx<br>
+; X86-NEXT: movl %eax, %edx<br>
+; X86-NEXT: addl $-1, %edx<br>
+; X86-NEXT: movl %ecx, %esi<br>
+; X86-NEXT: adcl $-1, %esi<br>
+; X86-NEXT: andl %eax, %edx<br>
+; X86-NEXT: andl %ecx, %esi<br>
+; X86-NEXT: orl %edx, %esi<br>
+; X86-NEXT: jne .LBB49_1<br>
+; X86-NEXT: # %bb.2:<br>
+; X86-NEXT: popl %esi<br>
+; X86-NEXT: .cfi_def_cfa_offset 4<br>
+; X86-NEXT: jmp bar # TAILCALL<br>
+; X86-NEXT: .LBB49_1:<br>
+; X86-NEXT: .cfi_def_cfa_offset 8<br>
+; X86-NEXT: popl %esi<br>
+; X86-NEXT: .cfi_def_cfa_offset 4<br>
+; X86-NEXT: retl<br>
+;<br>
+; X64-LABEL: pr42118_i64:<br>
+; X64: # %bb.0:<br>
+; X64-NEXT: blsrq %rdi, %rax<br>
+; X64-NEXT: jne .LBB49_1<br>
+; X64-NEXT: # %bb.2:<br>
+; X64-NEXT: jmp bar # TAILCALL<br>
+; X64-NEXT: .LBB49_1:<br>
+; X64-NEXT: retq<br>
+ %tmp = sub i64 0, %x<br>
+ %tmp1 = and i64 %tmp, %x<br>
+ %cmp = icmp eq i64 %tmp1, %x<br>
+ br i1 %cmp, label %1, label %2<br>
+<br>
+ tail call void @bar()<br>
+ br label %2<br>
+<br>
+ ret void<br>
+}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" rel="noreferrer noreferrer" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
</div>
</div>
<br>
<fieldset class="m_299254261269421483mimeAttachmentHeader"></fieldset>
<pre class="m_299254261269421483moz-quote-pre">_______________________________________________
llvm-commits mailing list
<a class="m_299254261269421483moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org" target="_blank" rel="noreferrer">llvm-commits@lists.llvm.org</a>
<a class="m_299254261269421483moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" rel="noreferrer">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
</div>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" rel="noreferrer">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div>