<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Yeah I failed to squash it with the following commit. I immediately reverted it.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><a name="_____replyseparator"></a><b>From:</b> Aaron Ballman <aaron.ballman@gmail.com>
<br>
<b>Sent:</b> Tuesday, June 4, 2019 1:06 AM<br>
<b>To:</b> Topper, Craig <craig.topper@intel.com><br>
<b>Cc:</b> llvm-commits <llvm-commits@lists.llvm.org><br>
<b>Subject:</b> Re: [llvm] r362451 - foo<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">Did you intend to commit this? (It looks reasonable, but the commit message gave me pause).<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">~Aaron<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal">On Tue, Jun 4, 2019, 12:08 AM Craig Topper via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Author: ctopper<br>
Date: Mon Jun 3 15:11:30 2019<br>
New Revision: 362451<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=362451&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=362451&view=rev</a><br>
Log:<br>
foo<br>
<br>
Modified:<br>
llvm/trunk/test/CodeGen/X86/bmi.ll<br>
<br>
Modified: llvm/trunk/test/CodeGen/X86/bmi.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/bmi.ll?rev=362451&r1=362450&r2=362451&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/bmi.ll?rev=362451&r1=362450&r2=362451&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/X86/bmi.ll (original)<br>
+++ llvm/trunk/test/CodeGen/X86/bmi.ll Mon Jun 3 15:11:30 2019<br>
@@ -1149,3 +1149,77 @@ define i64 @blsr64_branch(i64 %x) {<br>
}<br>
<br>
declare void @bar()<br>
+<br>
+define void @pr42118_i32(i32 %x) {<br>
+; X86-LABEL: pr42118_i32:<br>
+; X86: # %bb.0:<br>
+; X86-NEXT: blsrl {{[0-9]+}}(%esp), %eax<br>
+; X86-NEXT: jne .LBB48_1<br>
+; X86-NEXT: # %bb.2:<br>
+; X86-NEXT: jmp bar # TAILCALL<br>
+; X86-NEXT: .LBB48_1:<br>
+; X86-NEXT: retl<br>
+;<br>
+; X64-LABEL: pr42118_i32:<br>
+; X64: # %bb.0:<br>
+; X64-NEXT: blsrl %edi, %eax<br>
+; X64-NEXT: jne .LBB48_1<br>
+; X64-NEXT: # %bb.2:<br>
+; X64-NEXT: jmp bar # TAILCALL<br>
+; X64-NEXT: .LBB48_1:<br>
+; X64-NEXT: retq<br>
+ %tmp = sub i32 0, %x<br>
+ %tmp1 = and i32 %tmp, %x<br>
+ %cmp = icmp eq i32 %tmp1, %x<br>
+ br i1 %cmp, label %1, label %2<br>
+<br>
+ tail call void @bar()<br>
+ br label %2<br>
+<br>
+ ret void<br>
+}<br>
+<br>
+define void @pr42118_i64(i64 %x) {<br>
+; X86-LABEL: pr42118_i64:<br>
+; X86: # %bb.0:<br>
+; X86-NEXT: pushl %esi<br>
+; X86-NEXT: .cfi_def_cfa_offset 8<br>
+; X86-NEXT: .cfi_offset %esi, -8<br>
+; X86-NEXT: movl {{[0-9]+}}(%esp), %eax<br>
+; X86-NEXT: movl {{[0-9]+}}(%esp), %ecx<br>
+; X86-NEXT: movl %eax, %edx<br>
+; X86-NEXT: addl $-1, %edx<br>
+; X86-NEXT: movl %ecx, %esi<br>
+; X86-NEXT: adcl $-1, %esi<br>
+; X86-NEXT: andl %eax, %edx<br>
+; X86-NEXT: andl %ecx, %esi<br>
+; X86-NEXT: orl %edx, %esi<br>
+; X86-NEXT: jne .LBB49_1<br>
+; X86-NEXT: # %bb.2:<br>
+; X86-NEXT: popl %esi<br>
+; X86-NEXT: .cfi_def_cfa_offset 4<br>
+; X86-NEXT: jmp bar # TAILCALL<br>
+; X86-NEXT: .LBB49_1:<br>
+; X86-NEXT: .cfi_def_cfa_offset 8<br>
+; X86-NEXT: popl %esi<br>
+; X86-NEXT: .cfi_def_cfa_offset 4<br>
+; X86-NEXT: retl<br>
+;<br>
+; X64-LABEL: pr42118_i64:<br>
+; X64: # %bb.0:<br>
+; X64-NEXT: blsrq %rdi, %rax<br>
+; X64-NEXT: jne .LBB49_1<br>
+; X64-NEXT: # %bb.2:<br>
+; X64-NEXT: jmp bar # TAILCALL<br>
+; X64-NEXT: .LBB49_1:<br>
+; X64-NEXT: retq<br>
+ %tmp = sub i64 0, %x<br>
+ %tmp1 = and i64 %tmp, %x<br>
+ %cmp = icmp eq i64 %tmp1, %x<br>
+ br i1 %cmp, label %1, label %2<br>
+<br>
+ tail call void @bar()<br>
+ br label %2<br>
+<br>
+ ret void<br>
+}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</div>
</body>
</html>