<div dir="ltr">Nice!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 28, 2019 at 7:09 PM Fangrui Song via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: maskray<br>
Date: Tue May 28 03:12:06 2019<br>
New Revision: 361802<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=361802&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=361802&view=rev</a><br>
Log:<br>
[ELF] Replace two addSymbol() call sites with Symbol::resolve(). NFC<br>
<br>
If we have a handle of the symbol, insert() called by addSymbol() is<br>
redundant. Just call resolve().<br>
<br>
Modified:<br>
    lld/trunk/ELF/Writer.cpp<br>
<br>
Modified: lld/trunk/ELF/Writer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=361802&r1=361801&r2=361802&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=361802&r1=361801&r2=361802&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Writer.cpp (original)<br>
+++ lld/trunk/ELF/Writer.cpp Tue May 28 03:12:06 2019<br>
@@ -180,9 +180,9 @@ static Defined *addOptionalRegular(Strin<br>
   if (!S || S->isDefined())<br>
     return nullptr;<br>
<br>
-  return cast<Defined>(Symtab->addSymbol(<br>
-      Defined{/*File=*/nullptr, Name, Binding, StOther, STT_NOTYPE, Val,<br>
-              /*Size=*/0, Sec}));<br>
+  S->resolve(Defined{/*File=*/nullptr, Name, Binding, StOther, STT_NOTYPE, Val,<br>
+                     /*Size=*/0, Sec});<br>
+  return cast<Defined>(S);<br>
 }<br>
<br>
 static Defined *addAbsolute(StringRef Name) {<br>
@@ -239,9 +239,8 @@ void elf::addReservedSymbols() {<br>
     if (Config->EMachine == EM_PPC || Config->EMachine == EM_PPC64)<br>
       GotOff = 0x8000;<br>
<br>
-    Symtab->addSymbol(Defined{/*File=*/nullptr, GotSymName, STB_GLOBAL,<br>
-                              STV_HIDDEN, STT_NOTYPE, GotOff, /*Size=*/0,<br>
-                              Out::ElfHeader});<br>
+    S->resolve(Defined{/*File=*/nullptr, GotSymName, STB_GLOBAL, STV_HIDDEN,<br>
+                       STT_NOTYPE, GotOff, /*Size=*/0, Out::ElfHeader});<br>
     ElfSym::GlobalOffsetTable = cast<Defined>(S);<br>
   }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>