<div dir="ltr">Reverted by r361430.<div><br></div><div>Please feel free to let me know if information in the build log is not enough and you would need a help with a particular builder.</div><div><br></div><div>Thanks</div><div><br></div><div>Galina</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 21, 2019 at 10:34 PM Galina Kistanova <<a href="mailto:gkistanova@gmail.com" target="_blank">gkistanova@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hello Fangrui,<br><br>This commit added broken test to the next builder:<br><a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/17776" target="_blank">http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/17776</a><br>Please have a look ASAP?<br><br>. . .<br>Failing Tests (4):<br>. . .<br> LLVM :: CodeGen/AMDGPU/regbank-reassign.mir<br><br>The builder was already red and did not send any notifications.<br><br>Thanks<br><br>Galina</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 20, 2019 at 3:15 AM Fangrui Song via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: maskray<br>
Date: Mon May 20 03:18:35 2019<br>
New Revision: 361134<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=361134&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=361134&view=rev</a><br>
Log:<br>
Use llvm::sort. NFC<br>
<br>
Modified:<br>
llvm/trunk/lib/DebugInfo/CodeView/DebugFrameDataSubsection.cpp<br>
llvm/trunk/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp<br>
llvm/trunk/lib/Target/AMDGPU/GCNRegBankReassign.cpp<br>
llvm/trunk/lib/Target/XCore/XCoreFrameLowering.cpp<br>
<br>
Modified: llvm/trunk/lib/DebugInfo/CodeView/DebugFrameDataSubsection.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/CodeView/DebugFrameDataSubsection.cpp?rev=361134&r1=361133&r2=361134&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/CodeView/DebugFrameDataSubsection.cpp?rev=361134&r1=361133&r2=361134&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/DebugInfo/CodeView/DebugFrameDataSubsection.cpp (original)<br>
+++ llvm/trunk/lib/DebugInfo/CodeView/DebugFrameDataSubsection.cpp Mon May 20 03:18:35 2019<br>
@@ -47,10 +47,9 @@ Error DebugFrameDataSubsection::commit(B<br>
}<br>
<br>
std::vector<FrameData> SortedFrames(Frames.begin(), Frames.end());<br>
- std::sort(SortedFrames.begin(), SortedFrames.end(),<br>
- [](const FrameData &LHS, const FrameData &RHS) {<br>
- return LHS.RvaStart < RHS.RvaStart;<br>
- });<br>
+ llvm::sort(SortedFrames, [](const FrameData &LHS, const FrameData &RHS) {<br>
+ return LHS.RvaStart < RHS.RvaStart;<br>
+ });<br>
if (auto EC = Writer.writeArray(makeArrayRef(SortedFrames)))<br>
return EC;<br>
return Error::success();<br>
<br>
Modified: llvm/trunk/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp?rev=361134&r1=361133&r2=361134&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp?rev=361134&r1=361133&r2=361134&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp (original)<br>
+++ llvm/trunk/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp Mon May 20 03:18:35 2019<br>
@@ -158,10 +158,8 @@ void JITLinkerBase::layOutAtoms() {<br>
};<br>
for (auto &KV : Layout) {<br>
auto &SL = KV.second;<br>
- std::sort(SL.ContentSections.begin(), SL.ContentSections.end(),<br>
- CompareByOrdinal);<br>
- std::sort(SL.ZeroFillSections.begin(), SL.ZeroFillSections.end(),<br>
- CompareByOrdinal);<br>
+ llvm::sort(SL.ContentSections, CompareByOrdinal);<br>
+ llvm::sort(SL.ZeroFillSections, CompareByOrdinal);<br>
}<br>
}<br>
<br>
@@ -188,10 +186,10 @@ void JITLinkerBase::layOutAtoms() {<br>
OrderedLayoutHeads.push_back(DA);<br>
<br>
// Now sort the list of layout heads by address.<br>
- std::sort(OrderedLayoutHeads.begin(), OrderedLayoutHeads.end(),<br>
- [](const DefinedAtom *LHS, const DefinedAtom *RHS) {<br>
- return LHS->getAddress() < RHS->getAddress();<br>
- });<br>
+ llvm::sort(OrderedLayoutHeads,<br>
+ [](const DefinedAtom *LHS, const DefinedAtom *RHS) {<br>
+ return LHS->getAddress() < RHS->getAddress();<br>
+ });<br>
<br>
// Now populate the SI.Atoms field by appending each of the chains.<br>
for (auto *DA : OrderedLayoutHeads) {<br>
<br>
Modified: llvm/trunk/lib/Target/AMDGPU/GCNRegBankReassign.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/GCNRegBankReassign.cpp?rev=361134&r1=361133&r2=361134&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/GCNRegBankReassign.cpp?rev=361134&r1=361133&r2=361134&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/AMDGPU/GCNRegBankReassign.cpp (original)<br>
+++ llvm/trunk/lib/Target/AMDGPU/GCNRegBankReassign.cpp Mon May 20 03:18:35 2019<br>
@@ -649,7 +649,7 @@ unsigned GCNRegBankReassign::tryReassign<br>
}<br>
}<br>
}<br>
- std::sort(BankStalls.begin(), BankStalls.end());<br>
+ llvm::sort(BankStalls);<br>
<br>
unsigned OrigReg = VRM->getPhys(C.Reg);<br>
LRM->unassign(LI);<br>
<br>
Modified: llvm/trunk/lib/Target/XCore/XCoreFrameLowering.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/XCore/XCoreFrameLowering.cpp?rev=361134&r1=361133&r2=361134&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/XCore/XCoreFrameLowering.cpp?rev=361134&r1=361133&r2=361134&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/XCore/XCoreFrameLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/XCore/XCoreFrameLowering.cpp Mon May 20 03:18:35 2019<br>
@@ -27,7 +27,6 @@<br>
#include "llvm/IR/Function.h"<br>
#include "llvm/Support/ErrorHandling.h"<br>
#include "llvm/Target/TargetOptions.h"<br>
-#include <algorithm> // std::sort<br>
<br>
using namespace llvm;<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div>