<div dir="ltr">Seems to be working now. Thanks, Don!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 21, 2019 at 3:31 PM Don Hinton <<a href="mailto:hintonda@gmail.com">hintonda@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">Hi Cameron:<div><br></div><div>Sorry about that. I think I've got it fixed now, as of r361291. I was using <span style="color:rgb(80,0,80)">VERSION_GREATER_EQUAL, but turns out that isn't available prior to cmake version 3.7.2.</span></div><div><span style="color:rgb(80,0,80)"><br></span></div><div><span style="color:rgb(80,0,80)">I'm watching the bots, but please let me know if the latest fix doesn't work for you.</span></div><div><span style="color:rgb(80,0,80)"><br></span></div><div><span style="color:rgb(80,0,80)">thanks...</span></div><div><span style="color:rgb(80,0,80)">don</span></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 21, 2019 at 12:20 PM Cameron McInally <<a href="mailto:cameron.mcinally@nyu.edu" target="_blank">cameron.mcinally@nyu.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">Hi Don,<div><br></div><div>This change seems to have broken my local build. Any ideas?</div><div><br></div><div>```</div><div><div>CMake Error at cmake/config-ix.cmake:567 (if):</div><div> if given arguments:</div><div><br></div><div> "CMAKE_GENERATOR" "STREQUAL" "Ninja" "AND" "" "VERSION_GREATER_EQUAL" "1.9.0" "AND" "CMAKE_HOST_APPLE" "AND" "CMAKE_HOST_SYSTEM_VERSION" "VERSION_GREATER" "15.6.0"</div><div><br></div><div> Unknown arguments specified</div><div>Call Stack (most recent call first):</div><div> CMakeLists.txt:654 (include)</div><div><br></div><div>-- Configuring incomplete, errors occurred!</div></div><div>```</div><div><br></div><div>Thanks,</div><div>Cam</div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 21, 2019 at 2:48 PM Don Hinton via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Author: dhinton<br>
Date: Tue May 21 11:51:21 2019<br>
New Revision: 361286<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D361286-26view-3Drev&d=DwIGaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=ofcGBHHj9RUrHt-AaraheSp-lrdUKyr-eS56uF75LGg&s=r6rRmERt67hHL0IXpkU_AlHJxghFd8y7_XmFwUVTZ4M&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D361286-26view-3Drev&d=DwIGaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=ofcGBHHj9RUrHt-AaraheSp-lrdUKyr-eS56uF75LGg&s=r6rRmERt67hHL0IXpkU_AlHJxghFd8y7_XmFwUVTZ4M&e=</a><br>
Log:<br>
[cmake] Try to make cmake happy and fix bots.<br>
<br>
Modified:<br>
llvm/trunk/cmake/config-ix.cmake<br>
<br>
Modified: llvm/trunk/cmake/config-ix.cmake<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_cmake_config-2Dix.cmake-3Frev-3D361286-26r1-3D361285-26r2-3D361286-26view-3Ddiff&d=DwIGaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=ofcGBHHj9RUrHt-AaraheSp-lrdUKyr-eS56uF75LGg&s=rYjv2Bh7sNtU7QaehRn34MJtAvtdpn8xHXNn3BgLQ-4&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_cmake_config-2Dix.cmake-3Frev-3D361286-26r1-3D361285-26r2-3D361286-26view-3Ddiff&d=DwIGaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=ofcGBHHj9RUrHt-AaraheSp-lrdUKyr-eS56uF75LGg&s=rYjv2Bh7sNtU7QaehRn34MJtAvtdpn8xHXNn3BgLQ-4&e=</a><br>
==============================================================================<br>
--- llvm/trunk/cmake/config-ix.cmake (original)<br>
+++ llvm/trunk/cmake/config-ix.cmake Tue May 21 11:51:21 2019<br>
@@ -565,7 +565,7 @@ if(CMAKE_GENERATOR STREQUAL "Ninja")<br>
endif()<br>
<br>
if(CMAKE_GENERATOR STREQUAL "Ninja" AND<br>
- NINJA_VERSION VERSION_GREATER_EQUAL "1.9.0" AND<br>
+ "${NINJA_VERSION}" VERSION_GREATER_EQUAL "1.9.0" AND<br>
CMAKE_HOST_APPLE AND CMAKE_HOST_SYSTEM_VERSION VERSION_GREATER "15.6.0")<br>
set(LLVM_TOUCH_STATIC_LIBRARIES ON)<br>
endif()<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIGaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=ofcGBHHj9RUrHt-AaraheSp-lrdUKyr-eS56uF75LGg&s=RvddPuYu0rDvB3FcMQ9NmL63J975TZFmodOIlIj7QU0&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIGaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=ofcGBHHj9RUrHt-AaraheSp-lrdUKyr-eS56uF75LGg&s=RvddPuYu0rDvB3FcMQ9NmL63J975TZFmodOIlIj7QU0&e=</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>