<div dir="ltr">That was my mistake. My git commit editor starts warning at 50 chars, but I see other committed summaries extend up to 80. Thanks for correcting me...</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 15, 2019 at 4:46 PM Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com">lebedev.ri@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">On Wed, May 15, 2019 at 11:43 PM Cameron McInally<br>
<<a href="mailto:cameron.mcinally@nyu.edu" target="_blank">cameron.mcinally@nyu.edu</a>> wrote:<br>
><br>
> Sure, no problem.<br>
><br>
> I was trying to stay within the git 80 char summary limit. Is that not a problem? Or should the details go in the body?<br>
That is kinda the point.<br>
The subject should be as informative as possible. ~80 chars is a lot of space.<br>
<br>
> On Wed, May 15, 2019 at 4:32 PM Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com" target="_blank">lebedev.ri@gmail.com</a>> wrote:<br>
>><br>
>> Really minor, but could your commit messages please<br>
>> follow the general pattern of other commit messages?<br>
>> In particular, this could have been<br>
>> "[NFC][InstSimplify] Add more unary fneg tests to fp-nan.ll"<br>
>><br>
>> Roman.<br>
>><br>
>> On Wed, May 15, 2019 at 11:24 PM Cameron McInally via llvm-commits<br>
>> <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
>> ><br>
>> > Author: mcinally<br>
>> > Date: Wed May 15 13:27:35 2019<br>
>> > New Revision: 360807<br>
>> ><br>
>> > URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D360807-26view-3Drev&d=DwIBaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=YzI3EnjdxSNx535S0MftkJS_JgIWIFnV_C6uMmH4-Wk&s=riimpdhdq754Tsd8qcD-Ws5E6vTKN1MfzkMDYb7MmUc&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D360807-26view-3Drev&d=DwIBaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=YzI3EnjdxSNx535S0MftkJS_JgIWIFnV_C6uMmH4-Wk&s=riimpdhdq754Tsd8qcD-Ws5E6vTKN1MfzkMDYb7MmUc&e=</a><br>
>> > Log:<br>
>> > Add unary fneg to InstSimplify/fp-nan.ll<br>
>> ><br>
>> > Modified:<br>
>> > llvm/trunk/test/Transforms/InstSimplify/fp-nan.ll<br>
>> ><br>
>> > Modified: llvm/trunk/test/Transforms/InstSimplify/fp-nan.ll<br>
>> > URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_Transforms_InstSimplify_fp-2Dnan.ll-3Frev-3D360807-26r1-3D360806-26r2-3D360807-26view-3Ddiff&d=DwIBaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=YzI3EnjdxSNx535S0MftkJS_JgIWIFnV_C6uMmH4-Wk&s=LkGwPjFdB5neBd-AqFmN_qveGBZKTqE6Zmr8J9X8F6c&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_Transforms_InstSimplify_fp-2Dnan.ll-3Frev-3D360807-26r1-3D360806-26r2-3D360807-26view-3Ddiff&d=DwIBaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=YzI3EnjdxSNx535S0MftkJS_JgIWIFnV_C6uMmH4-Wk&s=LkGwPjFdB5neBd-AqFmN_qveGBZKTqE6Zmr8J9X8F6c&e=</a><br>
>> > ==============================================================================<br>
>> > --- llvm/trunk/test/Transforms/InstSimplify/fp-nan.ll (original)<br>
>> > +++ llvm/trunk/test/Transforms/InstSimplify/fp-nan.ll Wed May 15 13:27:35 2019<br>
>> > @@ -117,6 +117,14 @@ define double @unary_fneg_nan_1(double %<br>
>> > ret double %r<br>
>> > }<br>
>> ><br>
>> > +define double @unary_fneg_nan_1(double %x) {<br>
>> > +; CHECK-LABEL: @unary_fneg_nan_1(<br>
>> > +; CHECK-NEXT: ret double 0xFFFABCDEF0123456<br>
>> > +;<br>
>> > + %r = fneg double 0x7FFABCDEF0123456<br>
>> > + ret double %r<br>
>> > +}<br>
>> > +<br>
>> > define <2 x double> @fneg_nan_2(<2 x double> %x) {<br>
>> > ; CHECK-LABEL: @fneg_nan_2(<br>
>> > ; CHECK-NEXT: ret <2 x double> <double 0x7FF1234567890ABC, double 0xFFF0000000000001><br>
>> > @@ -125,6 +133,14 @@ define <2 x double> @fneg_nan_2(<2 x dou<br>
>> > ret <2 x double> %r<br>
>> > }<br>
>> ><br>
>> > +define <2 x double> @unary_fneg_nan_2(<2 x double> %x) {<br>
>> > +; CHECK-LABEL: @unary_fneg_nan_2(<br>
>> > +; CHECK-NEXT: ret <2 x double> <double 0x7FF1234567890ABC, double 0xFFF0000000000001><br>
>> > +;<br>
>> > + %r = fneg <2 x double> <double 0xFFF1234567890ABC, double 0x7FF0000000000001><br>
>> > + ret <2 x double> %r<br>
>> > +}<br>
>> > +<br>
>> > define <2 x double> @unary_fneg_nan_2(<2 x double> %x) {<br>
>> > ; CHECK-LABEL: @unary_fneg_nan_2(<br>
>> > ; CHECK-NEXT: ret <2 x double> <double 0x7FF1234567890ABC, double 0xFFF0000000000001><br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > llvm-commits mailing list<br>
>> > <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
>> > <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIBaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=YzI3EnjdxSNx535S0MftkJS_JgIWIFnV_C6uMmH4-Wk&s=A_3slit-SN0bIIajmAr4ccZZpDb_zU1Zj142Nr6orBE&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIBaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=YzI3EnjdxSNx535S0MftkJS_JgIWIFnV_C6uMmH4-Wk&s=A_3slit-SN0bIIajmAr4ccZZpDb_zU1Zj142Nr6orBE&e=</a><br>
</blockquote></div>