<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="text-align:left; direction:ltr;">
<div>OK, I have built piglit and dumped the IR.</div>
<div>I have it reproduced. It is not related to my change, but triggered by it.</div>
<div><br>
</div>
<div><span>
<pre>-- <br></pre>
<div style="width: 71ch;">Stas</div>
</span></div>
<div><br>
</div>
<div>-----Original Message-----</div>
<div><b>From</b>: Stanislav Mekhanoshin <<a href="mailto:Stanislav%20Mekhanoshin%20%3cStanislav.Mekhanoshin@amd.com%3e">Stanislav.Mekhanoshin@amd.com</a>></div>
<div><b>To</b>: Michel Dänzer <<a href="mailto:Michel%20%3d%3fISO-8859-1%3fQ%3fD%3dE4nzer%3f%3d%20%3cmichel@daenzer.net%3e">michel@daenzer.net</a>></div>
<div><b>Cc</b>: <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a></div>
<div><b>Subject</b>: Re: [llvm] r360395 - [AMDGPU] Pattern for v_xor3_b32</div>
<div><b>Date</b>: Fri, 10 May 2019 10:23:45 -0700</div>
<div><br>
</div>
<!-- text/html -->
<div>That is very strange, it should not change anything on the Bonaire. All the patterns affected are either gfx9 or gfx10.</div>
<div>Could you please provide an IR?</div>
<div><br>
</div>
<div><span>
<pre>-- </pre>
<br>
<div style="width: 71ch;">Stas</div>
</span></div>
<div><br>
</div>
<div>-----Original Message-----</div>
<div><b>From</b>: Michel Dänzer <<a href="mailto:Michel%20%3d%3fISO-8859-1%3fQ%3fD%3dE4nzer%3f%3d%20%3cmichel@daenzer.net%3e">michel@daenzer.net</a>></div>
<div><b>To</b>: Stanislav Mekhanoshin <<a href="mailto:Stanislav%20Mekhanoshin%20%3cStanislav.Mekhanoshin@amd.com%3e">Stanislav.Mekhanoshin@amd.com</a>></div>
<div><b>Cc</b>: <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a></div>
<div><b>Subject</b>: Re: [llvm] r360395 - [AMDGPU] Pattern for v_xor3_b32</div>
<div><b>Date</b>: Fri, 10 May 2019 19:04:19 +0200</div>
<div><br>
</div>
<pre>[CAUTION: External Email]</pre>
<br>
<pre>Hi Stanislav,</pre>
<br>
<br>
<pre>On 2019-05-10 2:09 a.m., Stanislav Mekhanoshin via llvm-commits wrote:</pre>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<pre>Author: rampitec</pre>
<pre>Date: Thu May 9 17:09:01 2019</pre>
<pre>New Revision: 360395</pre>
<br>
<pre>URL: </pre>
<a href="http://llvm.org/viewvc/llvm-project?rev=360395&view=rev">
<pre>http://llvm.org/viewvc/llvm-project?rev=360395&view=rev</pre>
</a><br>
<pre>Log:</pre>
<pre>[AMDGPU] Pattern for v_xor3_b32</pre>
<br>
<pre>This also allows three op patterns to use increased constant bus</pre>
<pre>limit of GFX10.</pre>
<br>
<pre>Differential Revision: </pre>
<a href="https://reviews.llvm.org/D61763">
<pre>https://reviews.llvm.org/D61763</pre>
</a><br>
</blockquote>
<br>
<pre>This change broke the piglit test all@shaders@glsl-fs-loop-nested-if with radeonsi on Bonaire:</pre>
<br>
<pre>invalid bitwidth</pre>
<pre>UNREACHABLE executed at ../lib/Target/AMDGPU/SIInstrInfo.cpp:2537!</pre>
<br>
<pre>Thread 5 "shader_run:sh1" received signal SIGABRT, Aborted.</pre>
<pre>[Switching to Thread 0x7fffeb7fe700 (LWP 25947)]</pre>
<pre>__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50</pre>
<pre>50 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.</pre>
<pre>(gdb) bt</pre>
<pre>#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50</pre>
<pre>#1 0x00007ffff7466535 in __GI_abort () at abort.c:79</pre>
<pre>#2 0x00007ffff331e8d0 in llvm::llvm_unreachable_internal (msg=<optimized out>, file=0x7ffff20bcebe "../lib/Target/AMDGPU/SIInstrInfo.cpp", line=2537) at ../lib/Support/ErrorHandling.cpp:221</pre>
<pre>#3 0x00007ffff4924ce0 in llvm::SIInstrInfo::isInlineConstant (this=<optimized out>, Imm=...) at ../lib/Target/AMDGPU/SIInstrInfo.cpp:2537</pre>
<pre>#4 0x00007ffff483ae2c in (anonymous namespace)::AMDGPUDAGToDAGISel::CheckNodePredicateWithOperands (this=0x5555556a64b0, Node=<optimized out>, PredNo=<optimized out>, Operands=...) at lib/Target/AMDGPU/AMDGPUGenDAGISel.inc:72963</pre>
<pre>#5 0x00007ffff3aa9cbb in llvm::SelectionDAGISel::SelectCodeCommon (this=<optimized out>, NodeToMatch=<optimized out>, MatcherTable=<optimized out>, TableSize=<optimized out>) at ../lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:3259</pre>
<pre>#6 0x00007ffff48389df in (anonymous namespace)::AMDGPUDAGToDAGISel::Select (this=<optimized out>, N=<optimized out>) at ../lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1910</pre>
<pre>#7 0x00007ffff3aa1998 in llvm::SelectionDAGISel::DoInstructionSelection (this=0x5555556a64b0) at ../lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1139</pre>
<pre>#8 0x00007ffff3aa09bb in llvm::SelectionDAGISel::CodeGenAndEmitDAG (this=0x5555556700c0) at ../lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:937</pre>
<pre>#9 0x00007ffff3a9dd27 in llvm::SelectionDAGISel::SelectAllBasicBlocks (this=0x5555556a64b0, Fn=...) at ../lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1814</pre>
<pre>#10 0x00007ffff3a9a463 in llvm::SelectionDAGISel::runOnMachineFunction (this=0x5555556a64b0, mf=...) at ../lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:496</pre>
<pre>#11 0x00007ffff36d096a in llvm::MachineFunctionPass::runOnFunction (this=0x5555556a64b0, F=...) at ../lib/CodeGen/MachineFunctionPass.cpp:73</pre>
<pre>#12 0x00007ffff34fc043 in llvm::FPPassManager::runOnFunction (this=0x5555556a5cf0, F=...) at ../lib/IR/LegacyPassManager.cpp:1648</pre>
<pre>#13 0x00007ffff4283f32 in (anonymous namespace)::CGPassManager::RunPassOnSCC (this=<optimized out>, P=0x5555556a5cf0, CurSCC=..., CG=..., CallGraphUpToDate=<optimized out>, DevirtualizedCall=<optimized out>) at ../lib/Analysis/CallGraphSCCPass.cpp:176</pre>
<pre>#14 (anonymous namespace)::CGPassManager::RunAllPassesOnSCC (this=<optimized out>, CurSCC=..., CG=..., DevirtualizedCall=<optimized out>) at ../lib/Analysis/CallGraphSCCPass.cpp:441</pre>
<pre>#15 (anonymous namespace)::CGPassManager::runOnModule (this=<optimized out>, M=...) at ../lib/Analysis/CallGraphSCCPass.cpp:497</pre>
<pre>#16 0x00007ffff34fc8c1 in (anonymous namespace)::MPPassManager::runOnModule (this=<optimized out>, M=...) at ../lib/IR/LegacyPassManager.cpp:1752</pre>
<pre>#17 llvm::legacy::PassManagerImpl::run (this=0x555555690970, M=...) at ../lib/IR/LegacyPassManager.cpp:1865</pre>
<pre>#18 0x00007ffff54cabf6 in ac_compile_module_to_binary (p=p@entry=0x5555556768a0, module=module@entry=0x7fffd80063b0, binary=binary@entry=0x7fffd8000be0) at /home/daenzer/src/llvm-git/llvm/include/llvm/IR/Module.h:914</pre>
<pre>#19 0x00007ffff54861b2 in si_llvm_compile (M=M@entry=0x7fffd80063b0, binary=binary@entry=0x7fffd8000be0, compiler=compiler@entry=0x55555562e7a0, debug=debug@entry=0x555555bf0630, less_optimized=less_optimized@entry=false)</pre>
<pre> at ../src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c:103</pre>
<pre>#20 0x00007ffff547726c in si_compile_llvm (sscreen=sscreen@entry=0x55555562e030, binary=binary@entry=0x7fffd8000be0, conf=conf@entry=0x7fffd8000c30, compiler=compiler@entry=0x55555562e7a0, mod=0x7fffd80063b0, debug=debug@entry=0x555555bf0630, processor=1,</pre>
<pre> name=0x7ffff5af3950 "Pixel Shader", less_optimized=false) at ../src/gallium/drivers/radeonsi/si_shader.c:5531</pre>
<pre>#21 0x00007ffff5478c1a in si_compile_tgsi_shader (sscreen=sscreen@entry=0x55555562e030, compiler=compiler@entry=0x55555562e7a0, shader=shader@entry=0x7fffd8000b20, debug=debug@entry=0x555555bf0630) at ../src/gallium/drivers/radeonsi/si_shader.c:6668</pre>
<pre>#22 0x00007ffff543237f in si_init_shader_selector_async (job=job@entry=0x555555bf0610, thread_index=thread_index@entry=1) at ../src/gallium/drivers/radeonsi/si_state_shaders.c:2090</pre>
<pre>#23 0x00007ffff5897f3e in util_queue_thread_func (input=input@entry=0x555555631bb0) at ../src/util/u_queue.c:289</pre>
<pre>#24 0x00007ffff5897898 in impl_thrd_routine (p=<optimized out>) at ../include/c11/threads_posix.h:87</pre>
<pre>#25 0x00007ffff69bcfa3 in start_thread (arg=<optimized out>) at pthread_create.c:486</pre>
<pre>#26 0x00007ffff753d4cf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95</pre>
<br>
<br>
<pre>--</pre>
<pre>Earthling Michel Dänzer | </pre>
<a href="https://www.amd.com">
<pre>https://www.amd.com</pre>
</a><br>
<pre>Libre software enthusiast | Mesa and X developer</pre>
</body>
</html>