<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thanks for catching that!<div class=""><br class=""></div><div class="">-Chris<div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Apr 21, 2019, at 12:18 PM, Don Hinton <<a href="mailto:hintonda@gmail.com" class="">hintonda@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><font face="arial, helvetica, sans-serif" class="">Fixed in <span style="color:rgb(32,33,36);font-variant-ligatures:no-contextual" class="">r358859.</span></font></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Apr 21, 2019 at 11:25 AM Don Hinton <<a href="mailto:hintonda@gmail.com" class="">hintonda@gmail.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class=""><div dir="ltr" class="">Hi Chris:<div class=""><br class=""></div><div class="">You need to escape the semicolons:</div><div class=""><br class=""></div><div class=""><div class="">diff --git a/llvm/cmake/modules/CrossCompile.cmake b/llvm/cmake/modules/CrossCompile.cmake</div><div class="">index 6d186de2724..157f4dd4ff3 100644</div><div class="">--- a/llvm/cmake/modules/CrossCompile.cmake</div><div class="">+++ b/llvm/cmake/modules/CrossCompile.cmake</div><div class="">@@ -45,6 +45,11 @@ function(llvm_create_cross_target_internal target_name toolchain buildtype)</div><div class=""> string(REPLACE ";" "$<SEMICOLON>" experimental_targets_to_build_arg</div><div class=""> "${LLVM_EXPERIMENTAL_TARGETS_TO_BUILD}")</div><div class=""><br class=""></div><div class="">+ string(REPLACE ";" "$<SEMICOLON>" llvm_enable_projects_arg</div><div class="">+ "${LLVM_ENABLE_PROJECTS}")</div><div class="">+ string(REPLACE ";" "$<SEMICOLON>" llvm_external_projects_arg</div><div class="">+ "${LLVM_EXTERNAL_PROJECTS}")</div><div class="">+</div><div class=""> add_custom_command(OUTPUT ${LLVM_${target_name}_BUILD}/CMakeCache.txt</div><div class=""> COMMAND ${CMAKE_COMMAND} -G "${CMAKE_GENERATOR}"</div><div class=""> -DCMAKE_MAKE_PROGRAM="${CMAKE_MAKE_PROGRAM}"</div><div class="">@@ -54,8 +59,8 @@ function(llvm_create_cross_target_internal target_name toolchain buildtype)</div><div class=""> -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="${experimental_targets_to_build_arg}"</div><div class=""> -DLLVM_DEFAULT_TARGET_TRIPLE="${TARGET_TRIPLE}"</div><div class=""> -DLLVM_TARGET_ARCH="${LLVM_TARGET_ARCH}"</div><div class="">- -DLLVM_ENABLE_PROJECTS="${LLVM_ENABLE_PROJECTS}"</div><div class="">- -DLLVM_EXTERNAL_PROJECTS="${LLVM_EXTERNAL_PROJECTS}"</div><div class="">+ -DLLVM_ENABLE_PROJECTS="${llvm_enable_projects_arg}"</div><div class="">+ -DLLVM_EXTERNAL_PROJECTS="${llvm_external_projects_arg}"</div><div class=""> -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN="${LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN}"</div><div class=""> ${build_type_flags} ${linker_flag} ${external_clang_dir}</div><div class=""> WORKING_DIRECTORY ${LLVM_${target_name}_BUILD}</div></div></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 19, 2019 at 1:06 PM Chris Bieneman via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: cbieneman<br class="">
Date: Fri Apr 19 13:08:55 2019<br class="">
New Revision: 358779<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=358779&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=358779&view=rev</a><br class="">
Log:<br class="">
[CMake] Pass monorepo build settings in cross compile<br class="">
<br class="">
This allows the cross compiled build targets to configure the LLVM tools and sub-projects that are part of the main build.<br class="">
<br class="">
This is needed for generating native non llvm *-tablegen tools when cross compiling clang in the monorepo build environment.<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/cmake/modules/CrossCompile.cmake<br class="">
<br class="">
Modified: llvm/trunk/cmake/modules/CrossCompile.cmake<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/CrossCompile.cmake?rev=358779&r1=358778&r2=358779&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/CrossCompile.cmake?rev=358779&r1=358778&r2=358779&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/cmake/modules/CrossCompile.cmake (original)<br class="">
+++ llvm/trunk/cmake/modules/CrossCompile.cmake Fri Apr 19 13:08:55 2019<br class="">
@@ -54,6 +54,8 @@ function(llvm_create_cross_target_intern<br class="">
-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="${experimental_targets_to_build_arg}"<br class="">
-DLLVM_DEFAULT_TARGET_TRIPLE="${TARGET_TRIPLE}"<br class="">
-DLLVM_TARGET_ARCH="${LLVM_TARGET_ARCH}"<br class="">
+ -DLLVM_ENABLE_PROJECTS="${LLVM_ENABLE_PROJECTS}"<br class="">
+ -DLLVM_EXTERNAL_PROJECTS="${LLVM_EXTERNAL_PROJECTS}"<br class="">
-DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN="${LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN}"<br class="">
${build_type_flags} ${linker_flag} ${external_clang_dir}<br class="">
WORKING_DIRECTORY ${LLVM_${target_name}_BUILD}<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</blockquote></div>
</div></blockquote></div><br class=""></div></div></body></html>