<div dir="ltr"><font face="arial, helvetica, sans-serif">Fixed in <span style="color:rgb(32,33,36);font-variant-ligatures:no-contextual">r358859.</span></font></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Apr 21, 2019 at 11:25 AM Don Hinton <<a href="mailto:hintonda@gmail.com">hintonda@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">Hi Chris:<div><br></div><div>You need to escape the semicolons:</div><div><br></div><div><div>diff --git a/llvm/cmake/modules/CrossCompile.cmake b/llvm/cmake/modules/CrossCompile.cmake</div><div>index 6d186de2724..157f4dd4ff3 100644</div><div>--- a/llvm/cmake/modules/CrossCompile.cmake</div><div>+++ b/llvm/cmake/modules/CrossCompile.cmake</div><div>@@ -45,6 +45,11 @@ function(llvm_create_cross_target_internal target_name toolchain buildtype)</div><div> string(REPLACE ";" "$<SEMICOLON>" experimental_targets_to_build_arg</div><div> "${LLVM_EXPERIMENTAL_TARGETS_TO_BUILD}")</div><div><br></div><div>+ string(REPLACE ";" "$<SEMICOLON>" llvm_enable_projects_arg</div><div>+ "${LLVM_ENABLE_PROJECTS}")</div><div>+ string(REPLACE ";" "$<SEMICOLON>" llvm_external_projects_arg</div><div>+ "${LLVM_EXTERNAL_PROJECTS}")</div><div>+</div><div> add_custom_command(OUTPUT ${LLVM_${target_name}_BUILD}/CMakeCache.txt</div><div> COMMAND ${CMAKE_COMMAND} -G "${CMAKE_GENERATOR}"</div><div> -DCMAKE_MAKE_PROGRAM="${CMAKE_MAKE_PROGRAM}"</div><div>@@ -54,8 +59,8 @@ function(llvm_create_cross_target_internal target_name toolchain buildtype)</div><div> -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="${experimental_targets_to_build_arg}"</div><div> -DLLVM_DEFAULT_TARGET_TRIPLE="${TARGET_TRIPLE}"</div><div> -DLLVM_TARGET_ARCH="${LLVM_TARGET_ARCH}"</div><div>- -DLLVM_ENABLE_PROJECTS="${LLVM_ENABLE_PROJECTS}"</div><div>- -DLLVM_EXTERNAL_PROJECTS="${LLVM_EXTERNAL_PROJECTS}"</div><div>+ -DLLVM_ENABLE_PROJECTS="${llvm_enable_projects_arg}"</div><div>+ -DLLVM_EXTERNAL_PROJECTS="${llvm_external_projects_arg}"</div><div> -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN="${LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN}"</div><div> ${build_type_flags} ${linker_flag} ${external_clang_dir}</div><div> WORKING_DIRECTORY ${LLVM_${target_name}_BUILD}</div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 19, 2019 at 1:06 PM Chris Bieneman via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: cbieneman<br>
Date: Fri Apr 19 13:08:55 2019<br>
New Revision: 358779<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=358779&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=358779&view=rev</a><br>
Log:<br>
[CMake] Pass monorepo build settings in cross compile<br>
<br>
This allows the cross compiled build targets to configure the LLVM tools and sub-projects that are part of the main build.<br>
<br>
This is needed for generating native non llvm *-tablegen tools when cross compiling clang in the monorepo build environment.<br>
<br>
Modified:<br>
llvm/trunk/cmake/modules/CrossCompile.cmake<br>
<br>
Modified: llvm/trunk/cmake/modules/CrossCompile.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/CrossCompile.cmake?rev=358779&r1=358778&r2=358779&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/CrossCompile.cmake?rev=358779&r1=358778&r2=358779&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/cmake/modules/CrossCompile.cmake (original)<br>
+++ llvm/trunk/cmake/modules/CrossCompile.cmake Fri Apr 19 13:08:55 2019<br>
@@ -54,6 +54,8 @@ function(llvm_create_cross_target_intern<br>
-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="${experimental_targets_to_build_arg}"<br>
-DLLVM_DEFAULT_TARGET_TRIPLE="${TARGET_TRIPLE}"<br>
-DLLVM_TARGET_ARCH="${LLVM_TARGET_ARCH}"<br>
+ -DLLVM_ENABLE_PROJECTS="${LLVM_ENABLE_PROJECTS}"<br>
+ -DLLVM_EXTERNAL_PROJECTS="${LLVM_EXTERNAL_PROJECTS}"<br>
-DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN="${LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN}"<br>
${build_type_flags} ${linker_flag} ${external_clang_dir}<br>
WORKING_DIRECTORY ${LLVM_${target_name}_BUILD}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div>