<div dir="ltr"><div dir="ltr">Should be fixed by r358811</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Apr 20, 2019 at 11:55 AM Sam McCall <<a href="mailto:sammccall@google.com">sammccall@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto">Ah sorry, i wasn't building with this warning on.<div dir="auto">It's noise here, but i can change the example so it doesn't fire.</div><div dir="auto">Will land that patch later today once i find a computer.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Apr 20, 2019, 05:18 Tianle Liu via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">liutianle added a comment.<br>
<br>
hi sammccall, when I run "check-all", some waring/error print out in STLExtrasTest.cpp as follow. My version is llvm:0ee120077 and clang:d87ee8e678. Could you please fix it or guide me how to fix it?<br>
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------<br>
<br>
myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp: In lambda function:<br>
myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp:475:58: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]<br>
<br>
  EXPECT_EQ(5u, bsearch(5, 10, [](unsigned X) { return X >= 0; }));<br>
                                                         ^<br>
<br>
myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest_pred_impl.h:77:52: note: in definition of macro 'GTEST_ASSERT_'<br>
<br>
  if (const ::testing::AssertionResult gtest_ar = (expression)) \<br>
                                                   ^<br>
<br>
myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest_pred_impl.h:162:3: note: in expansion of macro 'GTEST_PRED_FORMAT2_'<br>
<br>
  GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)<br>
  ^<br>
<br>
myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest.h:1923:3: note: in expansion of macro 'EXPECT_PRED_FORMAT2'<br>
<br>
  EXPECT_PRED_FORMAT2(::testing::internal:: \<br>
  ^<br>
<br>
myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp:475:3: note: in expansion of macro 'EXPECT_EQ'<br>
<br>
  EXPECT_EQ(5u, bsearch(5, 10, [](unsigned X) { return X >= 0; }));<br>
  ^<br>
<br>
myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp: In lambda function:<br>
myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp:483:67: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]<br>
<br>
  bsearch(V.begin(), V.end(), [](unsigned X) { return X >= 0; }));<br>
                                                        ^<br>
<br>
myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest_pred_impl.h:77:52: note: in definition of macro 'GTEST_ASSERT_'<br>
<br>
  if (const ::testing::AssertionResult gtest_ar = (expression)) \<br>
                                                      ^<br>
<br>
myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest_pred_impl.h:162:3: note: in expansion of macro 'GTEST_PRED_FORMAT2_'<br>
<br>
  GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)<br>
  ^<br>
<br>
myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest.h:1923:3: note: in expansion of macro 'EXPECT_PRED_FORMAT2'<br>
<br>
  EXPECT_PRED_FORMAT2(::testing::internal:: \<br>
  ^<br>
<br>
myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp:482:3: note: in expansion of macro 'EXPECT_EQ'<br>
<br>
  EXPECT_EQ(V.begin(),<br>
  ^<br>
<br>
myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp: In lambda function:<br>
myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp:489:61: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]<br>
<br>
  EXPECT_EQ(V.begin(), bsearch(V, [](unsigned X) { return X >= 0; }));<br>
                                                            ^<br>
<br>
myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest_pred_impl.h:77:52: note: in definition of macro 'GTEST_ASSERT_'<br>
<br>
  if (const ::testing::AssertionResult gtest_ar = (expression)) \<br>
                                                   ^<br>
<br>
myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest_pred_impl.h:162:3: note: in expansion of macro 'GTEST_PRED_FORMAT2_'<br>
<br>
  GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)<br>
  ^<br>
<br>
myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest.h:1923:3: note: in expansion of macro 'EXPECT_PRED_FORMAT2'<br>
<br>
  EXPECT_PRED_FORMAT2(::testing::internal:: \<br>
  ^<br>
<br>
myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp:489:3: note: in expansion of macro 'EXPECT_EQ'<br>
<br>
  EXPECT_EQ(V.begin(), bsearch(V, [](unsigned X) { return X >= 0; }));<br>
  ^<br>
<br>
-----------------------------------------------------------------------------------------------------------------------------<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D60779/new/" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D60779/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D60779" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D60779</a><br>
<br>
<br>
<br>
</blockquote></div>
</blockquote></div>