<div dir="ltr">It would, I just forgot, since I already noted that via Phab, but I do think it's ultimately best to record the author in the commit message, which is a more reliable system of record.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 4, 2019 at 3:24 PM Shoaib Meenai <<a href="mailto:smeenai@fb.com">smeenai@fb.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Would it be customary to include the "Patch by Zach Turner" here?<br>
<br>
On 4/4/19, 1:27 PM, "llvm-commits on behalf of Reid Kleckner via llvm-commits" <<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a> on behalf of <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
<br>
    Author: rnk<br>
    Date: Thu Apr  4 13:28:43 2019<br>
    New Revision: 357721<br>
<br>
    URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D357721-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=uKio4tY85gPY3WehKTNqyLjSByecM10H6HRd76uUZ6Q&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D357721-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=uKio4tY85gPY3WehKTNqyLjSByecM10H6HRd76uUZ6Q&e=</a><br>
    Log:<br>
    [LLDB] Remove all abandoned LLDB bots<br>
<br>
    Summary: All of these bots have been broken for months -- in some cases years.  Removing them from the waterfall.<br>
<br>
    Reviewers: gkistanova, labath, serge-sans-paille, stella.stamenova, srhines<br>
<br>
    Reviewed By: gkistanova, labath, stella.stamenova, srhines<br>
<br>
    Subscribers: javed.absar, jdoerfert, jankratochvil, srhines, stella.stamenova, echristo, llvm-commits<br>
<br>
    Differential Revision: <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D57911&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=mv4jNvp4Mc5CU3wzaYHbfxIEKu3avcABBiUpFbkzkhg&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D57911&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=mv4jNvp4Mc5CU3wzaYHbfxIEKu3avcABBiUpFbkzkhg&e=</a><br>
<br>
    Removed:<br>
        zorg/trunk/zorg/buildbot/schedulers/LLDBTriggerable.py<br>
    Modified:<br>
        zorg/trunk/buildbot/osuosl/master/config/builders.py<br>
        zorg/trunk/buildbot/osuosl/master/config/slaves.py<br>
        zorg/trunk/buildbot/osuosl/master/config/status.py<br>
        zorg/trunk/buildbot/osuosl/master/master.cfg<br>
<br>
    Modified: zorg/trunk/buildbot/osuosl/master/config/builders.py<br>
    URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_zorg_trunk_buildbot_osuosl_master_config_builders.py-3Frev-3D357721-26r1-3D357720-26r2-3D357721-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=PhhUY1pBwmhg1cF2XIR1vVtufBtiZ4furVu0EMzvuno&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_zorg_trunk_buildbot_osuosl_master_config_builders.py-3Frev-3D357721-26r1-3D357720-26r2-3D357721-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=PhhUY1pBwmhg1cF2XIR1vVtufBtiZ4furVu0EMzvuno&e=</a><br>
    ==============================================================================<br>
    --- zorg/trunk/buildbot/osuosl/master/config/builders.py (original)<br>
    +++ zorg/trunk/buildbot/osuosl/master/config/builders.py Thu Apr  4 13:28:43 2019<br>
    @@ -937,39 +937,6 @@ def _get_rev_iter_builders():<br>
     # LLDB builders.<br>
     def _get_lldb_builders():<br>
         return [<br>
    -        {'name': "lldb-x86-windows-msvc2015",<br>
    -         'slavenames': ["zturner-win2008"],<br>
    -         'builddir': "lldb-windows-x86",<br>
    -         'factory': LLDBBuilder.getLLDBCMakeBuildFactory(<br>
    -                    test=False,<br>
    -                    python_source_dir=r'C:/Python35',<br>
    -                    vs=r"""%VS140COMNTOOLS%""")},<br>
    -        # Disable the builder till we fix the cmake configuration<br>
    -        #{'name': "lldb-x86-win7-msvc",<br>
    -        #'slavenames': ["hexagon-build-01"],<br>
    -        #'builddir': "builddir/lldb-win7-msvc",<br>
    -        #'factory': LLDBBuilder.getLLDBCMakeBuildFactory(<br>
    -        #           config='Debug',<br>
    -        #           python_source_dir=r'C:/Python35',<br>
    -        #           vs=r"""%VS140COMNTOOLS%""")},<br>
    -        {'name': "lldb-x86_64-ubuntu-14.04-buildserver",<br>
    -         'slavenames': ["lldb-linux-android-buildserver"],<br>
    -         'builddir': "lldb-android-buildserver",<br>
    -         'category' : 'lldb',<br>
    -         'factory': LLDBBuilder.getLLDBScriptCommandsFactory(<br>
    -                    downloadBinary=False,<br>
    -                    buildAndroid=True,<br>
    -                    runTest=False,<br>
    -                    extra_cmake_args=['-DLLVM_ENABLE_ASSERTIONS=ON'])},<br>
    -        {'name': "lldb-x86_64-ubuntu-14.04-cmake",<br>
    -         'slavenames': ["lldb-build1-ubuntu-1404"],<br>
    -         'builddir': "buildWorkingDir",<br>
    -         'category' : 'lldb',<br>
    -         'factory': LLDBBuilder.getLLDBScriptCommandsFactory(<br>
    -                    downloadBinary=False,<br>
    -                    buildAndroid=False,<br>
    -                    runTest=True,<br>
    -                    extra_cmake_args=['-DLLVM_ENABLE_ASSERTIONS=ON'])},<br>
             {'name': "lldb-amd64-ninja-freebsd11",<br>
              'slavenames': ["lldb-amd64-ninja-freebsd11"],<br>
              'builddir': "scratch",<br>
    @@ -1599,34 +1566,6 @@ def _get_experimental_scheduled_builders<br>
                          enable_thrust_tests=False,<br>
              ),<br>
              'category' : 'clang'},<br>
    -<br>
    -        # lldb builders<br>
    -        {'name': "lldb-x86_64-darwin-13.4",<br>
    -         'slavenames': ["lldb-x86_64-darwin-13.4"],<br>
    -         'builddir': "buildDir",<br>
    -         'category' : 'lldb',<br>
    -         'factory': LLDBBuilder.getLLDBScriptCommandsFactory(<br>
    -                    downloadBinary=True,<br>
    -                    buildAndroid=False,<br>
    -                    runTest=True)},<br>
    -        {'name': "lldb-x86_64-ubuntu-14.04-android",<br>
    -         'slavenames': ["lldb-lab-linux01"],<br>
    -         'builddir': "lldb-cross-compile",<br>
    -         'category' : 'lldb',<br>
    -         'factory': LLDBBuilder.getLLDBScriptCommandsFactory(<br>
    -                    downloadBinary=True,<br>
    -                    buildAndroid=False,<br>
    -                    runTest=True)},<br>
    -        {'name': "lldb-windows7-android",<br>
    -         'slavenames': ["lldb-lab-win01"],<br>
    -         'builddir': "lldb-win7-android",<br>
    -         'category': "lldb",<br>
    -         'factory': LLDBBuilder.getLLDBScriptCommandsFactory(<br>
    -                    downloadBinary=True,<br>
    -                    buildAndroid=False,<br>
    -                    runTest=True,<br>
    -                    scriptExt='.bat')},<br>
    -<br>
             ]<br>
<br>
     # Builders responsible building Sphinix documentation<br>
<br>
    Modified: zorg/trunk/buildbot/osuosl/master/config/slaves.py<br>
    URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_zorg_trunk_buildbot_osuosl_master_config_slaves.py-3Frev-3D357721-26r1-3D357720-26r2-3D357721-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=kxK58MEOPVi16G3j0EJlKzwZu-Ihhuorr8bE75LyZcI&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_zorg_trunk_buildbot_osuosl_master_config_slaves.py-3Frev-3D357721-26r1-3D357720-26r2-3D357721-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=kxK58MEOPVi16G3j0EJlKzwZu-Ihhuorr8bE75LyZcI&e=</a><br>
    ==============================================================================<br>
    --- zorg/trunk/buildbot/osuosl/master/config/slaves.py (original)<br>
    +++ zorg/trunk/buildbot/osuosl/master/config/slaves.py Thu Apr  4 13:28:43 2019<br>
    @@ -189,8 +189,6 @@ def get_build_slaves():<br>
             create_slave('libcxx-cloud5', properties={'jobs': 64}, max_builds=1),<br>
<br>
<br>
    -        # Windows Server 2008 R2, Quad 2.6GHz Intel Xeon(R) 4GB RAM<br>
    -        create_slave("zturner-win2008", properties={'jobs': 4}, max_builds=1),<br>
             # Windows Server 2012 x86_64 16-core GCE instance<br>
             create_slave("sanitizer-windows", properties={'jobs': 16}, max_builds=1),<br>
             create_slave("windows-gcebot1", properties={'jobs': 8}, max_builds=1),<br>
    @@ -199,17 +197,6 @@ def get_build_slaves():<br>
             # Windows Server 2016 x86_64 16-core GCE instance<br>
             create_slave("windows-lld-thinlto-1", max_builds=1),<br>
<br>
    -        # Ubuntu x86-64, 51GiB System memory Intel(R) Xeon(R) CPU @ 2.60GHz<br>
    -        create_slave("lldb-build1-ubuntu-1404", properties={'jobs': 32, 'loadaverage':32}, max_builds=1),<br>
    -        # Darwin 13.4.0, x86_64<br>
    -        create_slave("lldb-x86_64-darwin-13.4", properties={'jobs': 16, 'loadaverage':32}, max_builds=1),<br>
    -        # Ubuntu 14.04 x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz<br>
    -        create_slave("lldb-lab-linux01", properties={'jobs': 40}, max_builds=1),<br>
    -<br>
    -        # Windows 7 x86_64<br>
    -        create_slave("lldb-lab-win01", properties={'jobs': 40}, max_builds=1),<br>
    -        # Ubuntu 14.04 x86_64<br>
    -        create_slave("lldb-linux-android-buildserver", properties={'jobs': 40}, max_builds=1),<br>
             # Ubuntu 14.04 x86_64, Intel(R) Xeon(R) CPU L5520 @ 2.27GHz<br>
             create_slave("bpf-build-slave01", properties={'jobs': 16}, max_builds=1),<br>
<br>
<br>
    Modified: zorg/trunk/buildbot/osuosl/master/config/status.py<br>
    URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_zorg_trunk_buildbot_osuosl_master_config_status.py-3Frev-3D357721-26r1-3D357720-26r2-3D357721-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=1tQnrwUKGzZd0G4fsuxUF1JVqJMe41d7ndwSVTBPV-M&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_zorg_trunk_buildbot_osuosl_master_config_status.py-3Frev-3D357721-26r1-3D357720-26r2-3D357721-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=1tQnrwUKGzZd0G4fsuxUF1JVqJMe41d7ndwSVTBPV-M&e=</a><br>
    ==============================================================================<br>
    --- zorg/trunk/buildbot/osuosl/master/config/status.py (original)<br>
    +++ zorg/trunk/buildbot/osuosl/master/config/status.py Thu Apr  4 13:28:43 2019<br>
    @@ -145,20 +145,6 @@ def get_status_targets(standard_builders<br>
             InformativeMailNotifier(<br>
                 fromaddr = "<a href="mailto:llvm.buildmaster@lab.llvm.org" target="_blank">llvm.buildmaster@lab.llvm.org</a>",<br>
                 sendToInterestedUsers= False,<br>
    -            extraRecipients = ["<a href="mailto:lldb-build-police-gmt@grotations.appspotmail.com" target="_blank">lldb-build-police-gmt@grotations.appspotmail.com</a>",<br>
    -                               "<a href="mailto:lldb-build-police-pst@grotations.appspotmail.com" target="_blank">lldb-build-police-pst@grotations.appspotmail.com</a>"],<br>
    -            subject="Build %(builder)s Failure",<br>
    -            mode = "failing",<br>
    -            builders = ["lldb-x86_64-ubuntu-14.04-cmake",<br>
    -                        "lldb-x86_64-ubuntu-14.04-buildserver",<br>
    -                        "lldb-windows7-android",<br>
    -                        "lldb-x86_64-darwin-13.4",<br>
    -                        "lldb-x86_64-ubuntu-14.04-android"],<br>
    -            addLogs=False,<br>
    -            num_lines = 15),<br>
    -        InformativeMailNotifier(<br>
    -            fromaddr = "<a href="mailto:llvm.buildmaster@lab.llvm.org" target="_blank">llvm.buildmaster@lab.llvm.org</a>",<br>
    -            sendToInterestedUsers= False,<br>
                 extraRecipients = ["<a href="mailto:sunil_srivastava@playstation.sony.com" target="_blank">sunil_srivastava@playstation.sony.com</a>",<br>
                                    "<a href="mailto:warren_ristow@playstation.sony.com" target="_blank">warren_ristow@playstation.sony.com</a>"],<br>
                 subject="Build %(builder)s Failure",<br>
<br>
    Modified: zorg/trunk/buildbot/osuosl/master/master.cfg<br>
    URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_zorg_trunk_buildbot_osuosl_master_master.cfg-3Frev-3D357721-26r1-3D357720-26r2-3D357721-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=cSDcZll5f_Vq9-GIRq4ERn0426qRzMwfhdmGhgcYITI&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_zorg_trunk_buildbot_osuosl_master_master.cfg-3Frev-3D357721-26r1-3D357720-26r2-3D357721-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=cSDcZll5f_Vq9-GIRq4ERn0426qRzMwfhdmGhgcYITI&e=</a><br>
    ==============================================================================<br>
    --- zorg/trunk/buildbot/osuosl/master/master.cfg (original)<br>
    +++ zorg/trunk/buildbot/osuosl/master/master.cfg Thu Apr  4 13:28:43 2019<br>
    @@ -178,19 +178,9 @@ c['schedulers'].append(SingleBranchSched<br>
                                     "llvm",<br>
                                     "lld"])))<br>
<br>
    -# lldb android builders will be triggered by completion of buildserver instead of by source change<br>
    -lldb_android_builders=["lldb-x86_64-ubuntu-14.04-android",<br>
    -                       "lldb-windows7-android",<br>
    -                       "lldb-x86_64-darwin-13.4"]<br>
    -from zorg.buildbot.schedulers.LLDBTriggerable import LLDBTriggerable<br>
    -c['schedulers'].append((LLDBTriggerable(<br>
    -                                  projects=['lldb', 'cfe', 'llvm'],<br>
    -                                  name="lldb_android_scheduler",<br>
    -                                  builderNames=lldb_android_builders)))<br>
    -<br>
     c['schedulers'].append(SingleBranchScheduler(name="lldb_scheduler",<br>
                                 treeStableTimer=2*60,<br>
    -                            builderNames=list(set(get_all_for("lldb"))-set(lldb_android_builders)),<br>
    +                            builderNames=get_all_for("lldb"),<br>
                                 change_filter=depends_on([<br>
                                     "llvm",<br>
                                     "cfe",<br>
<br>
    Removed: zorg/trunk/zorg/buildbot/schedulers/LLDBTriggerable.py<br>
    URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_zorg_trunk_zorg_buildbot_schedulers_LLDBTriggerable.py-3Frev-3D357720-26view-3Dauto&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=Uk2VBbNIrxzc4n3VnaZp4TPKR7bpWwruUdO985XLZuc&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_zorg_trunk_zorg_buildbot_schedulers_LLDBTriggerable.py-3Frev-3D357720-26view-3Dauto&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=Uk2VBbNIrxzc4n3VnaZp4TPKR7bpWwruUdO985XLZuc&e=</a><br>
    ==============================================================================<br>
    --- zorg/trunk/zorg/buildbot/schedulers/LLDBTriggerable.py (original)<br>
    +++ zorg/trunk/zorg/buildbot/schedulers/LLDBTriggerable.py (removed)<br>
    @@ -1,84 +0,0 @@<br>
    -from twisted.python import log<br>
    -from twisted.internet import defer<br>
    -from buildbot.schedulers.triggerable import Triggerable<br>
    -from buildbot.process.properties import Properties<br>
    -<br>
    -class LLDBTriggerable(Triggerable):<br>
    -    """<br>
    -    This is the scheduler used for lldb android builders,<br>
    -    Overwrite trigger function, so the triggered builder will<br>
    -    get changelist based on new changes since their last build.<br>
    -    The origianl implementation takes changelist from upstream<br>
    -    triggerer builder, this will be inaccurate in the case that<br>
    -    some builds in upstream didn't trigger new builds due to<br>
    -    failure in their early steps.<br>
    -    """<br>
    -<br>
    -    def __init__(self, projects, maxChange=100, **kwargs):<br>
    -        Triggerable.__init__(self, **kwargs)<br>
    -        self.projects = projects<br>
    -        self.lastRevision = None<br>
    -        self.maxChange = maxChange<br>
    -<br>
    -    def trigger(self, ssid, set_props=None):<br>
    -        """Trigger this scheduler with the given sourcestamp ID. Returns a<br>
    -        deferred that will fire when the buildset is finished."""<br>
    -        # properties for this buildset are composed of our own properties,<br>
    -        # potentially overridden by anything from the triggering build<br>
    -        props = Properties()<br>
    -        props.updateFromProperties(self.properties)<br>
    -        if set_props:<br>
    -            props.updateFromProperties(set_props)<br>
    -<br>
    -        newRevision = [None]<br>
    -        def getRevision(ss):<br>
    -            newRevision[0] = ss['revision']<br>
    -            return ss['revision']<br>
    -<br>
    -        def getRecentChanges(newRev):<br>
    -            if self.lastRevision is None:<br>
    -                return None<br>
    -            return self.master.db.changes.getRecentChanges(self.maxChange)<br>
    -<br>
    -        # check the last x changeset and pick up the ones that are between<br>
    -        # last revision and current revision and belong to interested projects<br>
    -        def selectChangeSet(changes):<br>
    -            changeids = []<br>
    -            if changes is not None:<br>
    -                for change in changes:<br>
    -                    if change['revision'] > newRevision[0] or change['revision'] <= self.lastRevision or change['project'] not in self.projects:<br>
    -                        continue<br>
    -                    changeids.append(change['changeid'])<br>
    -            log.msg("LLDBTriggerable: last revision change from %s to %s" % (self.lastRevision, newRevision[0]))<br>
    -            self.lastRevision = newRevision[0]<br>
    -            return changeids<br>
    -<br>
    -        def addBuildset(changeids):<br>
    -            if changeids:<br>
    -                log.msg("LLDBTriggerable: addBuildsetForChanges, changeids: %s" % changeids)<br>
    -                return self.addBuildsetForChanges(reason=self.reason, changeids=changeids, properties=props)<br>
    -            elif ssid:<br>
    -                # if this is the first build after master startup, use the source stamp from triggerer build<br>
    -                # it's possible to write last revision to a file on master, so after master reconfig we could<br>
    -                # pick up the correct last revision.<br>
    -                # It's not implemented here because 1) the cases are rare that first build after master restart<br>
    -                # is preceded by failing builds on triggerer builder, 2) avoid polluting master with project<br>
    -                # specific cache files<br>
    -                log.msg("LLDBTriggerable: addBuildsetForSourceStamp")<br>
    -                return self.addBuildsetForSourceStamp(reason=self.reason, ssid=ssid, properties=props)<br>
    -            else:<br>
    -                return self.addBuildsetForLatest(reason=self.reason, properties=props)<br>
    -<br>
    -        def setup_waiter((bsid,brids)):<br>
    -            self._waiters[bsid] = d = defer.Deferred()<br>
    -            self._updateWaiters()<br>
    -            return d<br>
    -<br>
    -        d = self.master.db.sourcestamps.getSourceStamp(ssid)<br>
    -        d.addCallback(getRevision)<br>
    -        d.addCallback(getRecentChanges)<br>
    -        d.addCallback(selectChangeSet)<br>
    -        d.addCallback(addBuildset)<br>
    -        d.addCallback(setup_waiter)<br>
    -        return d<br>
    -<br>
<br>
<br>
    _______________________________________________<br>
    llvm-commits mailing list<br>
    <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
    <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=lCRlHLiqh3vBe_lke6GvRECfCUHLj5t4hoSwgodpFTI&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=QKCZC7_UHAA40H02VuKG43vTwhmf-JTRG8tKkyEWnsI&s=lCRlHLiqh3vBe_lke6GvRECfCUHLj5t4hoSwgodpFTI&e=</a><br>
<br>
<br>
</blockquote></div>