<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">I have just put up a patch for review (<a href="https://reviews.llvm.org/D59663">https://reviews.llvm.org/D59663</a>) that fixes this issue.<br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 21 Mar 2019 at 18:22, Reid Kleckner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: rnk<br>
Date: Thu Mar 21 11:24:05 2019<br>
New Revision: 356694<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=356694&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=356694&view=rev</a><br>
Log:<br>
Fix lld wasm tests after r356610<br>
<br>
Apparently stdout is not opened in binary mode, so the executable gets<br>
corrupted when piping to obj2yaml.<br>
<br>
Modified:<br>
    lld/trunk/test/wasm/target-feature-disallowed.yaml<br>
    lld/trunk/test/wasm/target-feature-required.yaml<br>
    lld/trunk/test/wasm/target-feature-used.yaml<br>
<br>
Modified: lld/trunk/test/wasm/target-feature-disallowed.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/wasm/target-feature-disallowed.yaml?rev=356694&r1=356693&r2=356694&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/wasm/target-feature-disallowed.yaml?rev=356694&r1=356693&r2=356694&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/test/wasm/target-feature-disallowed.yaml (original)<br>
+++ lld/trunk/test/wasm/target-feature-disallowed.yaml Thu Mar 21 11:24:05 2019<br>
@@ -1,10 +1,12 @@<br>
 # RUN: yaml2obj %s -o %t1.o<br>
<br>
 # RUN: yaml2obj %S/Inputs/disallow-feature-foo.yaml -o %t.disallowed.o<br>
-# RUN: wasm-ld --no-entry -o - %t1.o %t.disallowed.o | obj2yaml | FileCheck %s --check-prefix DISALLOWED<br>
+# RUN: wasm-ld --no-entry -o %t.disallowed.exe %t1.o %t.disallowed.o<br>
+# RUN: obj2yaml < %t.disallowed.exe | FileCheck %s --check-prefix DISALLOWED<br>
<br>
 # RUN: yaml2obj %S/Inputs/no-feature-foo.yaml -o %t.none.o<br>
-# RUN: wasm-ld --no-entry -o - %t1.o %t.none.o | obj2yaml | FileCheck %s --check-prefix NONE<br>
+# RUN: wasm-ld --no-entry -o %t.none.exe %t1.o %t.none.o<br>
+# RUN: obj2yaml < %t.none.exe | FileCheck %s --check-prefix NONE<br>
<br>
 # Check that the following combinations of feature linkage policies<br>
 # give the expected results:<br>
<br>
Modified: lld/trunk/test/wasm/target-feature-required.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/wasm/target-feature-required.yaml?rev=356694&r1=356693&r2=356694&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/wasm/target-feature-required.yaml?rev=356694&r1=356693&r2=356694&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/test/wasm/target-feature-required.yaml (original)<br>
+++ lld/trunk/test/wasm/target-feature-required.yaml Thu Mar 21 11:24:05 2019<br>
@@ -1,13 +1,14 @@<br>
 # RUN: yaml2obj %s -o %t1.o<br>
<br>
 # RUN: yaml2obj %S/Inputs/require-feature-foo.yaml -o %t.required.o<br>
-# RUN: wasm-ld --no-entry -o - %t1.o %t.required.o | obj2yaml | FileCheck %s --check-prefix REQUIRED<br>
+# RUN: wasm-ld --no-entry -o %t.required.exe %t1.o %t.required.o<br>
+# RUN: obj2yaml < %t.required.exe | FileCheck %s --check-prefix REQUIRED<br>
<br>
 # RUN: yaml2obj %S/Inputs/disallow-feature-foo.yaml -o %t.disallowed.o<br>
-# RUN: not wasm-ld --no-entry -o - %t1.o %t.disallowed.o 2>&1 | FileCheck %s --check-prefix DISALLOWED<br>
+# RUN: not wasm-ld --no-entry -o /dev/null %t1.o %t.disallowed.o 2>&1 | FileCheck %s --check-prefix DISALLOWED<br>
<br>
 # RUN: yaml2obj %S/Inputs/no-feature-foo.yaml -o %t.none.o<br>
-# RUN: not wasm-ld --no-entry -o - %t1.o %t.none.o 2>&1 | FileCheck %s --check-prefix NONE<br>
+# RUN: not wasm-ld --no-entry -o /dev/null %t1.o %t.none.o 2>&1 | FileCheck %s --check-prefix NONE<br>
<br>
 # Check that the following combinations of feature linkage policies<br>
 # give the expected results:<br>
<br>
Modified: lld/trunk/test/wasm/target-feature-used.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/wasm/target-feature-used.yaml?rev=356694&r1=356693&r2=356694&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/wasm/target-feature-used.yaml?rev=356694&r1=356693&r2=356694&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/test/wasm/target-feature-used.yaml (original)<br>
+++ lld/trunk/test/wasm/target-feature-used.yaml Thu Mar 21 11:24:05 2019<br>
@@ -1,16 +1,19 @@<br>
 # RUN: yaml2obj %s -o %t1.o<br>
<br>
 # RUN: yaml2obj %S/Inputs/use-feature-foo.yaml -o %t.used.o<br>
-# RUN: wasm-ld --no-entry -o - %t1.o %t.used.o | obj2yaml | FileCheck %s --check-prefix USED<br>
+# RUN: wasm-ld --no-entry -o %t.used.exe %t1.o %t.used.o<br>
+# RUN: obj2yaml < %t.used.exe | FileCheck %s --check-prefix USED<br>
<br>
 # RUN: yaml2obj %S/Inputs/require-feature-foo.yaml -o %t.required.o<br>
-# RUN: wasm-ld --no-entry -o - %t1.o %t.required.o | obj2yaml | FileCheck %s --check-prefix REQUIRED<br>
+# RUN: wasm-ld --no-entry -o %t.required.exe %t1.o %t.required.o<br>
+# RUN: obj2yaml < %t.required.exe | FileCheck %s --check-prefix REQUIRED<br>
<br>
 # RUN: yaml2obj %S/Inputs/disallow-feature-foo.yaml -o %t.disallowed.o<br>
-# RUN: not wasm-ld --no-entry -o - %t1.o %t.disallowed.o 2>&1 | FileCheck %s --check-prefix DISALLOWED<br>
+# RUN: not wasm-ld --no-entry -o /dev/null %t1.o %t.disallowed.o 2>&1 | FileCheck %s --check-prefix DISALLOWED<br>
<br>
 # RUN: yaml2obj %S/Inputs/no-feature-foo.yaml -o %t.none.o<br>
-# RUN: wasm-ld --no-entry -o - %t1.o %t.none.o | obj2yaml | FileCheck %s --check-prefix NONE<br>
+# RUN: wasm-ld --no-entry -o %t.none.exe %t1.o %t.none.o<br>
+# RUN: obj2yaml %t.none.exe | FileCheck %s --check-prefix NONE<br>
<br>
 # Check that the following combinations of feature linkage policies<br>
 # give the expected results:<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>