<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 7, 2019 at 3:54 AM Michael Platings via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: michaelplatings<br>
Date: Thu Mar  7 03:55:26 2019<br>
New Revision: 355590<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=355590&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=355590&view=rev</a><br>
Log:<br>
Fix & re-enable test that intermittently failed in debug mode.<br>
<br>
The Value class and derivates will have uninitialized member variables if not created via operator new.<br></blockquote><div><br>Perhaps this ^ should be fixed instead?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/unittests/IR/ConstantsTest.cpp<br>
<br>
Modified: llvm/trunk/unittests/IR/ConstantsTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/IR/ConstantsTest.cpp?rev=355590&r1=355589&r2=355590&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/IR/ConstantsTest.cpp?rev=355590&r1=355589&r2=355590&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/unittests/IR/ConstantsTest.cpp (original)<br>
+++ llvm/trunk/unittests/IR/ConstantsTest.cpp Thu Mar  7 03:55:26 2019<br>
@@ -556,20 +556,21 @@ TEST(ConstantsTest, DontFoldFunctionPtrI<br>
   ASSERT_FALSE(foldFuncPtrAndConstToNull(Context, nullptr, 2, 4));<br>
 }<br>
<br>
-TEST(ConstantsTest, DISABLED_FoldGlobalVariablePtr) {<br>
+TEST(ConstantsTest, FoldGlobalVariablePtr) {<br>
   LLVMContext Context;<br>
<br>
<br>
   IntegerType *IntType(Type::getInt32Ty(Context));<br>
<br>
-  GlobalVariable Global(IntType, true, GlobalValue::ExternalLinkage);<br>
+  std::unique_ptr<GlobalVariable> Global(<br>
+      new GlobalVariable(IntType, true, GlobalValue::ExternalLinkage));<br>
<br>
-  Global.setAlignment(4);<br>
+  Global->setAlignment(4);<br>
<br>
   ConstantInt *TheConstant(ConstantInt::get(IntType, 2));<br>
<br>
   Constant *TheConstantExpr(<br>
-      ConstantExpr::getPtrToInt(&Global, IntType));<br>
+      ConstantExpr::getPtrToInt(Global.get(), IntType));<br>
<br>
   ASSERT_TRUE(ConstantExpr::get( \<br>
       Instruction::And, TheConstantExpr, TheConstant)->isNullValue());<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>