<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 11, 2019 at 2:01 PM Adrian Prantl <<a href="mailto:aprantl@apple.com">aprantl@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">You'll see the sad resolution of this two commits further down. (I reverted this one, too). There was a header file with a function body that used the LLVM_DEBUG macro (which I believe fundamentally cannot work inside a non-textual header) </div></blockquote><div><br>Right - if it depends on its inclusion state to define DEBUG_TYPE that's not modular. I assume that's the case? Oh, it looks like it is the case, that DEBUG_TYPE is defined within this file, so I don't think there's a problem with using LLVM_DEBUG here? It's not intended to consume the value of DEBUG_TYPE from its inclusion context.<br><br>Perhaps that's invalid in a modular context if it's ever included somewhere that also defines DEBUG_TYPE? I'm not sure there.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">and inside of it it called a dump method, thus pulling the reference to the dump method into the link.</div></blockquote><div><br>Missed a step here - inside of what it called a dump function? & why was that a problem? It called a dump function unconditionally rather than only under the condition that the dump function is defined? I'm not sure how modules would make/break that.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><br></div><div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div>-- adrian</div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><br><div><br><blockquote type="cite"><div>On Mar 11, 2019, at 1:56 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:</div><br class="m_-8565424306644221792Apple-interchange-newline"><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 7, 2019 at 2:24 PM Adrian Prantl via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Author: adrian<br>Date: Thu Mar  7 14:25:26 2019<br>New Revision: 355646<br><br>URL:<span class="m_-8565424306644221792Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=355646&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=355646&view=rev</a><br>Log:<br>Work around a module build error on the LLDB incremental green dragon bot.<br><br>Modified:<br>   <span class="m_-8565424306644221792Apple-converted-space"> </span>llvm/trunk/include/llvm/module.modulemap<br><br>Modified: llvm/trunk/include/llvm/module.modulemap<br>URL:<span class="m_-8565424306644221792Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/module.modulemap?rev=355646&r1=355645&r2=355646&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/module.modulemap?rev=355646&r1=355645&r2=355646&view=diff</a><br>==============================================================================<br>--- llvm/trunk/include/llvm/module.modulemap (original)<br>+++ llvm/trunk/include/llvm/module.modulemap Thu Mar  7 14:25:26 2019<br>@@ -353,6 +353,10 @@ module LLVM_Utils {<br>     exclude header "Support/PluginLoader.h"<br>     exclude header "Support/Solaris/sys/regset.h"<br><br>+    // FIXME: The function bodies in this header pull in<br>+    //        unwanted dependencies that cause linker errors.<br></blockquote><div><br>What does it pull in & how does it cause linker errors?<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">+    exclude header "Support/GenericDomTreeConstruction.h"<br>+<br>     // These are intended for textual inclusion.<br>     textual header "Support/ARMTargetParser.def"<br>     textual header "Support/AArch64TargetParser.def"<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></blockquote></div></div></div></blockquote></div><br></div></div></blockquote></div></div>