<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Mar 11, 2019, at 12:16 PM, Jonas Paulsson via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">jonpa marked an inline comment as done.<br class="">jonpa added inline comments.<br class=""><br class=""><br class="">================<br class="">Comment at: test/CodeGen/X86/regalloc-copy-hints.mir:308<br class="">+ attributes #0 = { "target-cpu"="i486" }<br class="">+ attributes #1 = { nounwind }<br class="">+<br class="">----------------<br class="">qcolombet wrote:<br class=""><blockquote type="cite" class="">Do we need the IR part?<br class="">(I.e., does anything in the MIR reference back the IR?)<br class=""></blockquote>I tried removing it but then got 'basic block "bb' is not defined in the function 'fun'"…?<br class=""></div></div></blockquote><div><br class=""></div><div>For that you need to remove the "IR links” from the machine block to the IR block.</div><div>The machine block names look like this:</div><div><span style="font-family: Menlo, Consolas, Monaco, monospace; font-size: 11px; white-space: pre-wrap; background-color: rgba(151, 234, 151, 0.6);" class="">bb.#MachineID[.nameOfIRBasicBlock]</span></div><div>In other words, delete the part after the number for each basic block.</div><div><br class=""></div><div>I see that you have memory operands (the things that look like `:: (load...)`) too and if they are not optional, you’ll need to keep some IR anyway.</div><br class=""><blockquote type="cite" class=""><div class=""><div class=""><br class=""><br class="">CHANGES SINCE LAST ACTION<br class=""> <a href="https://reviews.llvm.org/D59201/new/" class="">https://reviews.llvm.org/D59201/new/</a><br class=""><br class=""><a href="https://reviews.llvm.org/D59201" class="">https://reviews.llvm.org/D59201</a><br class=""><br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class="">llvm-commits@lists.llvm.org<br class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></div></blockquote></div><br class=""></body></html>