<div dir="ltr">Thanks!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 6, 2019 at 5:48 AM George Rimar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: grimar<br>
Date: Wed Mar 6 05:49:41 2019<br>
New Revision: 355500<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=355500&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=355500&view=rev</a><br>
Log:<br>
[LLD][ELF] - Convert common-symbol-alignment.s test to yaml.<br>
<br>
This removes 2 precompiled binaries from the inputs.<br>
<br>
Added:<br>
lld/trunk/test/ELF/invalid/common-symbol-alignment.test<br>
- copied, changed from r355499, lld/trunk/test/ELF/invalid/common-symbol-alignment.s<br>
Removed:<br>
lld/trunk/test/ELF/invalid/Inputs/common-symbol-alignment.elf<br>
lld/trunk/test/ELF/invalid/Inputs/common-symbol-alignment2.elf<br>
lld/trunk/test/ELF/invalid/common-symbol-alignment.s<br>
<br>
Removed: lld/trunk/test/ELF/invalid/Inputs/common-symbol-alignment.elf<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/Inputs/common-symbol-alignment.elf?rev=355499&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/Inputs/common-symbol-alignment.elf?rev=355499&view=auto</a><br>
==============================================================================<br>
Binary file - no diff available.<br>
<br>
Removed: lld/trunk/test/ELF/invalid/Inputs/common-symbol-alignment2.elf<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/Inputs/common-symbol-alignment2.elf?rev=355499&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/Inputs/common-symbol-alignment2.elf?rev=355499&view=auto</a><br>
==============================================================================<br>
Binary file - no diff available.<br>
<br>
Removed: lld/trunk/test/ELF/invalid/common-symbol-alignment.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/common-symbol-alignment.s?rev=355499&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/common-symbol-alignment.s?rev=355499&view=auto</a><br>
==============================================================================<br>
--- lld/trunk/test/ELF/invalid/common-symbol-alignment.s (original)<br>
+++ lld/trunk/test/ELF/invalid/common-symbol-alignment.s (removed)<br>
@@ -1,12 +0,0 @@<br>
-# REQUIRES: x86<br>
-<br>
-## common-symbol-alignment.elf contains common symbol with zero alignment.<br>
-# RUN: not ld.lld %S/Inputs/common-symbol-alignment.elf \<br>
-# RUN: -o %t 2>&1 | FileCheck %s<br>
-# CHECK: common symbol 'bar' has invalid alignment: 0<br>
-<br>
-## common-symbol-alignment2.elf contains common symbol alignment greater<br>
-## than UINT32_MAX.<br>
-# RUN: not ld.lld %S/Inputs/common-symbol-alignment2.elf \<br>
-# RUN: -o %t 2>&1 | FileCheck %s --check-prefix=BIG<br>
-# BIG: common symbol 'bar' has invalid alignment: 271644049215<br>
<br>
Copied: lld/trunk/test/ELF/invalid/common-symbol-alignment.test (from r355499, lld/trunk/test/ELF/invalid/common-symbol-alignment.s)<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/common-symbol-alignment.test?p2=lld/trunk/test/ELF/invalid/common-symbol-alignment.test&p1=lld/trunk/test/ELF/invalid/common-symbol-alignment.s&r1=355499&r2=355500&rev=355500&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/common-symbol-alignment.test?p2=lld/trunk/test/ELF/invalid/common-symbol-alignment.test&p1=lld/trunk/test/ELF/invalid/common-symbol-alignment.s&r1=355499&r2=355500&rev=355500&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/test/ELF/invalid/common-symbol-alignment.s (original)<br>
+++ lld/trunk/test/ELF/invalid/common-symbol-alignment.test Wed Mar 6 05:49:41 2019<br>
@@ -1,12 +1,36 @@<br>
-# REQUIRES: x86<br>
-<br>
-## common-symbol-alignment.elf contains common symbol with zero alignment.<br>
-# RUN: not ld.lld %S/Inputs/common-symbol-alignment.elf \<br>
-# RUN: -o %t 2>&1 | FileCheck %s<br>
+## If an object contains a common symbol with zero alignment,<br>
+## check we report it.<br>
+# RUN: yaml2obj -docnum=1 %s -o %t1.o<br>
+# RUN: not ld.lld %t1.o -o %t 2>&1 | FileCheck %s<br>
# CHECK: common symbol 'bar' has invalid alignment: 0<br>
<br>
-## common-symbol-alignment2.elf contains common symbol alignment greater<br>
-## than UINT32_MAX.<br>
-# RUN: not ld.lld %S/Inputs/common-symbol-alignment2.elf \<br>
-# RUN: -o %t 2>&1 | FileCheck %s --check-prefix=BIG<br>
+--- !ELF<br>
+FileHeader:<br>
+ Class: ELFCLASS64<br>
+ Data: ELFDATA2LSB<br>
+ Type: ET_REL<br>
+ Machine: EM_X86_64<br>
+Symbols:<br>
+ Global:<br>
+ - Name: bar<br>
+ Type: STT_FUNC<br>
+ Index: SHN_COMMON<br>
+<br>
+## If an object contains a common symbol with alignment greater<br>
+## than UINT32_MAX, check we report it.<br>
+# RUN: yaml2obj -docnum=2 %s -o %t2.o<br>
+# RUN: not ld.lld %t2.o -o %t 2>&1 | FileCheck %s --check-prefix=BIG<br>
# BIG: common symbol 'bar' has invalid alignment: 271644049215<br>
+<br>
+--- !ELF<br>
+FileHeader: <br>
+ Class: ELFCLASS64<br>
+ Data: ELFDATA2LSB<br>
+ Type: ET_REL<br>
+ Machine: EM_X86_64<br>
+Symbols:<br>
+ Global:<br>
+ - Name: bar<br>
+ Type: STT_FUNC<br>
+ Index: SHN_COMMON<br>
+ Value: 0x0000003F3F3F3F3F<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>