<div dir="ltr">Why was this reverted? (handy to have that in the commit message for those following along, etc)</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 8, 2019 at 2:11 PM Adrian Prantl via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: adrian<br>
Date: Fri Mar 8 14:12:38 2019<br>
New Revision: 355744<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=355744&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=355744&view=rev</a><br>
Log:<br>
Revert "Build LLDB with local submodule visibility."<br>
<br>
This reverts commit 355641+355639.<br>
<br>
Modified:<br>
zorg/trunk/zorg/jenkins/build.py<br>
zorg/trunk/zorg/jenkins/jobs/jobs/lldb-cmake-standalone<br>
zorg/trunk/zorg/jenkins/lldb-cmake-matrix-dwarf.sh<br>
zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage1.sh<br>
zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage2.sh<br>
<br>
Modified: zorg/trunk/zorg/jenkins/build.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/build.py?rev=355744&r1=355743&r2=355744&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/build.py?rev=355744&r1=355743&r2=355744&view=diff</a><br>
==============================================================================<br>
--- zorg/trunk/zorg/jenkins/build.py (original)<br>
+++ zorg/trunk/zorg/jenkins/build.py Fri Mar 8 14:12:38 2019<br>
@@ -597,7 +597,6 @@ def lldb_cmake_builder():<br>
'-DCMAKE_MAKE_PROGRAM=' + NINJA,<br>
'-DLLVM_VERSION_PATCH=99',<br>
'-DLLVM_ENABLE_MODULES=On',<br>
- '-DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=On',<br>
'-DCMAKE_EXPORT_COMPILE_COMMANDS=ON',<br>
'-DCMAKE_INSTALL_PREFIX="%s"'%dest_dir,<br>
'-DLLDB_TEST_USER_ARGS='+';'.join(dotest_args),<br>
<br>
Modified: zorg/trunk/zorg/jenkins/jobs/jobs/lldb-cmake-standalone<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/jobs/jobs/lldb-cmake-standalone?rev=355744&r1=355743&r2=355744&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/jobs/jobs/lldb-cmake-standalone?rev=355744&r1=355743&r2=355744&view=diff</a><br>
==============================================================================<br>
--- zorg/trunk/zorg/jenkins/jobs/jobs/lldb-cmake-standalone (original)<br>
+++ zorg/trunk/zorg/jenkins/jobs/jobs/lldb-cmake-standalone Fri Mar 8 14:12:38 2019<br>
@@ -188,7 +188,6 @@ cmake -L $LLDB_SRC \<br>
-DCMAKE_BUILD_TYPE=Release \<br>
-DLLVM_ENABLE_ASSERTIONS=On \<br>
-DLLVM_ENABLE_MODULES=On \<br>
- -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=On \<br>
-DLLVM_VERSION_PATCH=99 \<br>
-DLLVM_TARGETS_TO_BUILD='X86;ARM;AArch64' \<br>
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON \<br>
<br>
Modified: zorg/trunk/zorg/jenkins/lldb-cmake-matrix-dwarf.sh<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/lldb-cmake-matrix-dwarf.sh?rev=355744&r1=355743&r2=355744&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/lldb-cmake-matrix-dwarf.sh?rev=355744&r1=355743&r2=355744&view=diff</a><br>
==============================================================================<br>
--- zorg/trunk/zorg/jenkins/lldb-cmake-matrix-dwarf.sh (original)<br>
+++ zorg/trunk/zorg/jenkins/lldb-cmake-matrix-dwarf.sh Fri Mar 8 14:12:38 2019<br>
@@ -89,7 +89,6 @@ cmake $WORKSPACE/llvm \<br>
-DCMAKE_BUILD_TYPE=Release \<br>
-DLLVM_ENABLE_ASSERTIONS=On \<br>
-DLLVM_ENABLE_MODULES=On \<br>
- -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=On \<br>
-DLLVM_VERSION_PATCH=99 \<br>
-DLLVM_TARGETS_TO_BUILD='X86' \<br>
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON \<br>
<br>
Modified: zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage1.sh<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage1.sh?rev=355744&r1=355743&r2=355744&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage1.sh?rev=355744&r1=355743&r2=355744&view=diff</a><br>
==============================================================================<br>
--- zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage1.sh (original)<br>
+++ zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage1.sh Fri Mar 8 14:12:38 2019<br>
@@ -74,7 +74,6 @@ cmake $LLVM_SRC \<br>
-DCMAKE_BUILD_TYPE=Release \<br>
-DLLVM_ENABLE_ASSERTIONS=On \<br>
-DLLVM_ENABLE_MODULES=On \<br>
- -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=On \<br>
-DLLVM_VERSION_PATCH=99 \<br>
-DLLVM_TARGETS_TO_BUILD='X86' \<br>
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON \<br>
<br>
Modified: zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage2.sh<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage2.sh?rev=355744&r1=355743&r2=355744&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage2.sh?rev=355744&r1=355743&r2=355744&view=diff</a><br>
==============================================================================<br>
--- zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage2.sh (original)<br>
+++ zorg/trunk/zorg/jenkins/lldb-cmake-matrix-stage2.sh Fri Mar 8 14:12:38 2019<br>
@@ -80,7 +80,6 @@ function build_clang() {<br>
-DCMAKE_BUILD_TYPE=Release \<br>
-DLLVM_ENABLE_ASSERTIONS=Off \<br>
-DLLVM_ENABLE_MODULES=On \<br>
- -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=On \<br>
-DLLVM_TARGETS_TO_BUILD='X86' \<br>
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON \<br>
-DCMAKE_INSTALL_PREFIX="$RESULTS/history/$CLANG_NAME" \<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>