<div dir="ltr"><div dir="ltr"><div dir="ltr">On Thu, Mar 7, 2019 at 2:19 PM Mitch Phillips via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: hctim<br>
Date: Thu Mar  7 14:20:36 2019<br>
New Revision: 355645<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=355645&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=355645&view=rev</a><br>
Log:<br>
[GN] Locate prebuilt binaries correctly.<br>
<br>
Use the system shell to see if we can find a 'gn' binary on $PATH. This solves the error wherein subprocess.call fails ungracefully if the binary doesn't exist.<br>
<br>
Modified:<br>
    llvm/trunk/utils/gn/gn.py<br>
<br>
Modified: llvm/trunk/utils/gn/gn.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/gn.py?rev=355645&r1=355644&r2=355645&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/gn.py?rev=355645&r1=355644&r2=355645&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/utils/gn/gn.py (original)<br>
+++ llvm/trunk/utils/gn/gn.py Thu Mar  7 14:20:36 2019<br>
@@ -38,7 +38,8 @@ def main():<br>
     # Find real gn executable.<br>
     gn = 'gn'<br>
     if subprocess.call([gn, '--version'], stdout=open(os.devnull, 'w'),<br></blockquote><div> </div><div>I think this needs to be 'gn --version' to avoid the platform dependent behaviour discussed in D59003.</div><div><br></div><div>Peter</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
-                                          stderr=subprocess.STDOUT) != 0:<br>
+                                          stderr=subprocess.STDOUT,<br>
+                                          shell=True) != 0:<br>
         # Not on path. See if get.py downloaded a prebuilt binary and run that<br>
         # if it's there, or suggest to run get.py if it isn't.<br>
         platform = get_platform()<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail-m_8874162779189716161gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div></div></div>