<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 1, 2019 at 12:09 PM Roman Lebedev <<a href="mailto:lebedev.ri@gmail.com">lebedev.ri@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Mar 1, 2019 at 9:35 PM Rong Xu via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: xur<br>
> Date: Fri Mar  1 10:36:24 2019<br>
> New Revision: 355216<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=355216&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=355216&view=rev</a><br>
> Log:<br>
> [PGO] Remove the default parameter in ProfileSummary API. NFC<br>
><br>
> Remove the default parameter in setProfileSummary() and getSummary().<br>
It reads as if the "extended" commit message is just the repetition of<br>
the title.<br>
It could be better for commit log to write a bit more wordy extended<br>
commit message,<br>
that explains the commit more. <br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> This is a follow-up of r355131.<br></blockquote><div>I thought the commit comment was quite clear...</div><div>I mentioned in committing msg of r355131 that the default </div><div>parameter was just temporal to break the dependency in clang.  </div><br class="gmail-Apple-interchange-newline"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
><br>
> Modified:<br>
>     llvm/trunk/include/llvm/IR/Module.h<br>
>     llvm/trunk/include/llvm/ProfileData/InstrProfReader.h<br>
><br>
> Modified: llvm/trunk/include/llvm/IR/Module.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/Module.h?rev=355216&r1=355215&r2=355216&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/Module.h?rev=355216&r1=355215&r2=355216&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/IR/Module.h (original)<br>
> +++ llvm/trunk/include/llvm/IR/Module.h Fri Mar  1 10:36:24 2019<br>
> @@ -869,9 +869,7 @@ public:<br>
>    /// @{<br>
><br>
>    /// Attach profile summary metadata to this module.<br>
> -  // TODO: Remove the default paramter.<br>
> -  void setProfileSummary(Metadata *M,<br>
> -                         ProfileSummary::Kind Kind = ProfileSummary::PSK_Instr);<br>
> +  void setProfileSummary(Metadata *M, ProfileSummary::Kind Kind);<br>
><br>
>    /// Returns profile summary metadata. When IsCS is true, use the context<br>
>    /// sensitive profile summary.<br>
><br>
> Modified: llvm/trunk/include/llvm/ProfileData/InstrProfReader.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ProfileData/InstrProfReader.h?rev=355216&r1=355215&r2=355216&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ProfileData/InstrProfReader.h?rev=355216&r1=355215&r2=355216&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/ProfileData/InstrProfReader.h (original)<br>
> +++ llvm/trunk/include/llvm/ProfileData/InstrProfReader.h Fri Mar  1 10:36:24 2019<br>
> @@ -501,8 +501,7 @@ public:<br>
><br>
>    /// Return the profile summary.<br>
>    /// \c UseCS indicates whether to use the context-sensitive summary.<br>
> -  // TODO: removed the defualt parameter.<br>
> -  ProfileSummary &getSummary(bool UseCS = false) {<br>
> +  ProfileSummary &getSummary(bool UseCS) {<br>
>      if (UseCS) {<br>
>        assert(CS_Summary && "No context sensitive summary");<br>
>        return *(CS_Summary.get());<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>