<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Attempted fix:<div class=""><a href="https://github.com/llvm/llvm-project/commit/52b751088b11547e0f4ef0589ebbe5e57752c68c" class="">https://github.com/llvm/llvm-project/commit/52b751088b11547e0f4ef0589ebbe5e57752c68c</a></div><div class=""><br class=""></div><div class="">I think the problem is that my previous patch made UBSan runtime dependent on a symbol from sanitizer_common.</div><div class="">UBSan is combined with other runtimes which may or may not provide the symbol, so I defined it with weak linkage in UBSan.</div><div class=""><br class=""></div><div class="">Please let me know if this is an appropriate fix.<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Feb 27, 2019, at 3:38 PM, Evgenii Stepanov via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">eugenis added a comment.<br class=""><br class="">This bot seems unhappy:<br class=""><a href="http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/6651" class="">http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/6651</a><br class=""><br class=""><br class="">Repository:<br class=""> rCRT Compiler Runtime<br class=""><br class="">CHANGES SINCE LAST ACTION<br class=""> https://reviews.llvm.org/D58557/new/<br class=""><br class="">https://reviews.llvm.org/D58557<br class=""><br class=""><br class=""><br class=""></div></div></blockquote></div><br class=""></div></body></html>