<div dir="ltr">What is the point to keep them commented?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 22, 2019 at 7:23 PM Julian Lettner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: yln<br>
Date: Fri Feb 22 19:24:10 2019<br>
New Revision: 354718<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=354718&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=354718&view=rev</a><br>
Log:<br>
[NFC][Sanitizer] Comment out argument checks<br>
<br>
These break clang-ppc64 bots.<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc?rev=354718&r1=354717&r2=354718&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc?rev=354718&r1=354717&r2=354718&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace.cc Fri Feb 22 19:24:10 2019<br>
@@ -70,8 +70,8 @@ static inline uhwptr *GetCanonicFrame(up<br>
<br>
 void BufferedStackTrace::UnwindFast(uptr pc, uptr bp, uptr stack_top,<br>
                                     uptr stack_bottom, u32 max_depth) {<br>
-  CHECK_NE(stack_bottom, 0);<br>
-  CHECK_GT(stack_top, stack_bottom);<br>
+  // CHECK_NE(stack_bottom, 0);<br>
+  // CHECK_GT(stack_top, stack_bottom);<br>
   CHECK_GE(max_depth, 2);<br>
   const uptr kPageSize = GetPageSizeCached();<br>
   trace_buffer[0] = pc;<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc?rev=354718&r1=354717&r2=354718&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc?rev=354718&r1=354717&r2=354718&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_stacktrace_sparc.cc Fri Feb 22 19:24:10 2019<br>
@@ -23,8 +23,8 @@ namespace __sanitizer {<br>
<br>
 void BufferedStackTrace::UnwindFast(uptr pc, uptr bp, uptr stack_top,<br>
                                     uptr stack_bottom, u32 max_depth) {<br>
-  CHECK_NE(stack_bottom, 0);<br>
-  CHECK_GT(stack_top, stack_bottom);<br>
+  // CHECK_NE(stack_bottom, 0);<br>
+  // CHECK_GT(stack_top, stack_bottom);<br>
   CHECK_GE(max_depth, 2);<br>
   const uptr kPageSize = GetPageSizeCached();<br>
   trace_buffer[0] = pc;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>