<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class=""><div></div><div><br class=""><blockquote type="cite" class=""><div class="">On Feb 20, 2019, at 10:12 PM, Alina Sbirlea <<a href="mailto:alina.sbirlea@gmail.com" class="">alina.sbirlea@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Are you sure your update is complete?<br class="">It should theoretically match the DT update, i.e. include insert edges not just the delete. All updates should be done together using the same list of updates used for DT, and an up to date DT (see MSSAU->applyUpdates(DTUpdates, DT)).<br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 20, 2019 at 9:53 PM Maxim Kazantsev via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="RU" class="">
<div class="gmail-m_-7826189020220271627WordSection1"><p class="MsoNormal"><span lang="EN-US" class="">Should be fixed by
<a href="https://reviews.llvm.org/rL354547" target="_blank" class="">https://reviews.llvm.org/rL354547</a>
<u class=""></u><u class=""></u></span></p><p class="MsoNormal"><span lang="EN-US" class=""><u class=""></u> <u class=""></u></span></p>
<div class="">
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0cm 0cm" class=""><p class="MsoNormal"><b class=""><span lang="EN-US" class="">From:</span></b><span lang="EN-US" class=""> Maxim Kazantsev
<br class="">
<b class="">Sent:</b> Thursday, February 21, 2019 11:49 AM<br class="">
<b class="">To:</b> '<a href="mailto:rtereshin@apple.com" target="_blank" class="">rtereshin@apple.com</a>' <<a href="mailto:rtereshin@apple.com" target="_blank" class="">rtereshin@apple.com</a>><br class="">
<b class="">Cc:</b> llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>>; <a href="mailto:dberlin@dberlin.org" target="_blank" class="">dberlin@dberlin.org</a>; <a href="mailto:asbirlea@google.com" target="_blank" class="">asbirlea@google.com</a><br class="">
<b class="">Subject:</b> RE: [llvm] r353911 - [LoopSimplifyCFG] Re-enable const branch folding by default<u class=""></u><u class=""></u></span></p>
</div>
</div><p class="MsoNormal"><u class=""></u> <u class=""></u></p><p class="MsoNormal"><span lang="EN-US" class="">Hi Roman,<u class=""></u><u class=""></u></span></p><p class="MsoNormal"><span lang="EN-US" class=""><u class=""></u> <u class=""></u></span></p><p class="MsoNormal"><span lang="EN-US" class="">Thanks for notification! I’ll fix it asap.<u class=""></u><u class=""></u></span></p><p class="MsoNormal"><span lang="EN-US" class=""><u class=""></u> <u class=""></u></span></p><p class="MsoNormal"><span lang="EN-US" class="">--Max<u class=""></u><u class=""></u></span></p><p class="MsoNormal"><span lang="EN-US" class=""><u class=""></u> <u class=""></u></span></p>
<div class="">
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0cm 0cm" class=""><p class="MsoNormal"><b class=""><span lang="EN-US" class="">From:</span></b><span lang="EN-US" class=""> <a href="mailto:rtereshin@apple.com" target="_blank" class="">
rtereshin@apple.com</a> <<a href="mailto:rtereshin@apple.com" target="_blank" class="">rtereshin@apple.com</a>>
<br class="">
<b class="">Sent:</b> Thursday, February 21, 2019 10:25 AM<br class="">
<b class="">To:</b> Maxim Kazantsev <<a href="mailto:max.kazantsev@azul.com" target="_blank" class="">max.kazantsev@azul.com</a>><br class="">
<b class="">Cc:</b> llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>>;
<a href="mailto:dberlin@dberlin.org" target="_blank" class="">dberlin@dberlin.org</a>; <a href="mailto:asbirlea@google.com" target="_blank" class="">
asbirlea@google.com</a><br class="">
<b class="">Subject:</b> Re: [llvm] r353911 - [LoopSimplifyCFG] Re-enable const branch folding by default<u class=""></u><u class=""></u></span></p>
</div>
</div><p class="MsoNormal"><u class=""></u> <u class=""></u></p>
<div class="">
<div class=""><p class="MsoNormal" style="margin-bottom:12pt"><span style="font-size:10pt" class="">Hi Max,<br class="">
<br class="">
Looks like this doesn’t collaborate with MemorySSA very well:<br class="">
<br class="">
./bin/opt -loop-simplifycfg loop-simplifycfg-term-folding-AND-mssa-loop-dependency.ll -enable-mssa-loop-dependency=true -verify-memoryssa=true -enable-loop-simplifycfg-term-folding=true -S -o -<br class="">
Assertion failed: (find(predecessors(&B), Phi->getIncomingBlock(I)) != pred_end(&B) && "Incoming phi block not a block predecessor"), function verifyDefUses, file ../lib/Analysis/MemorySSA.cpp, line 1947.<br class="">
<br class="">
The IR is:<br class="">
<br class="">
define void @main() {<br class="">
entry:<br class="">
br label %for.body<br class="">
<br class="">
for.body: ; preds = %exit, %entry<br class="">
br label %<a href="http://switch.bb/" target="_blank" class="">switch.bb</a><br class="">
<br class="">
<a href="http://switch.bb/" target="_blank" class="">switch.bb</a>: ; preds = %for.body<br class="">
switch i2 1, label %<a href="http://default.bb/" target="_blank" class="">default.bb</a> [<br class="">
i2 1, label %<a href="http://case.bb/" target="_blank" class="">case.bb</a><br class="">
]<br class="">
<br class="">
<a href="http://case.bb/" target="_blank" class="">case.bb</a>: ; preds = %switch<br class="">
br label %exit<br class="">
<br class="">
<a href="http://default.bb/" target="_blank" class="">default.bb</a>: ; preds = %switch<br class="">
unreachable<br class="">
<br class="">
exit: ; preds = %<a href="http://case.bb/" target="_blank" class="">case.bb</a><br class="">
call void @foo()<br class="">
br label %for.body<br class="">
}<br class="">
<br class="">
declare void @foo()<br class="">
<br class="">
<br class="">
Thanks,<br class="">
Roman<u class=""></u><u class=""></u></span></p>
</div>
</div>
<div class="">
<div class=""><p class="MsoNormal" style="margin-bottom:12pt"><span style="font-size:10pt" class=""><br class="">
<br class="">
> On Feb 12, 2019, at 10:12 PM, Max Kazantsev via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
> <br class="">
> Author: mkazantsev<br class="">
> Date: Tue Feb 12 22:12:48 2019<br class="">
> New Revision: 353911<br class="">
> <br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=353911&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=353911&view=rev</a><br class="">
> Log:<br class="">
> [LoopSimplifyCFG] Re-enable const branch folding by default<br class="">
> <br class="">
> Known underlying bugs have been fixed, intensive fuzz testing did not<br class="">
> find any new problems. Re-enabling by default. Feel free to revert if<br class="">
> it causes any functional failures.<br class="">
> <br class="">
> Modified:<br class="">
> llvm/trunk/lib/Transforms/Scalar/LoopSimplifyCFG.cpp<br class="">
> <br class="">
> Modified: llvm/trunk/lib/Transforms/Scalar/LoopSimplifyCFG.cpp<br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopSimplifyCFG.cpp?rev=353911&r1=353910&r2=353911&view=diff" target="_blank" class="">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopSimplifyCFG.cpp?rev=353911&r1=353910&r2=353911&view=diff</a><br class="">
> ==============================================================================<br class="">
> --- llvm/trunk/lib/Transforms/Scalar/LoopSimplifyCFG.cpp (original)<br class="">
> +++ llvm/trunk/lib/Transforms/Scalar/LoopSimplifyCFG.cpp Tue Feb 12 22:12:48 2019<br class="">
> @@ -41,7 +41,7 @@ using namespace llvm;<br class="">
> #define DEBUG_TYPE "loop-simplifycfg"<br class="">
> <br class="">
> static cl::opt<bool> EnableTermFolding("enable-loop-simplifycfg-term-folding",<br class="">
> - cl::init(false));<br class="">
> + cl::init(true));<br class="">
> <br class="">
> STATISTIC(NumTerminatorsFolded,<br class="">
> "Number of terminators folded to unconditional branches");<br class="">
> <br class="">
> <br class="">
> _______________________________________________<br class="">
> llvm-commits mailing list<br class="">
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><u class=""></u><u class=""></u></span></p>
</div>
</div>
</div>
</div>
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>