<div dir="ltr">Could this be tested?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jan 30, 2019 at 4:04 PM Craig Topper via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Wed Jan 30 16:04:48 2019<br>
New Revision: 352699<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=352699&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=352699&view=rev</a><br>
Log:<br>
[LegalizeTypes] Use report_fatal_error instead of llvm_unreachable in the default case of some type legalization handlers that can be reached with intrinsics with result or operands that aren't legal types.<br>
<br>
These can be triggered by mistakenly using a 64-bit mode only intrinsics with a -mtriple=i686. Using report_fatal_error gives a better experience for this mistake in release builds instead of probably crashing.<br>
<br>
We already do this for some of the vector type legalization handles.<br>
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp?rev=352699&r1=352698&r2=352699&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp?rev=352699&r1=352698&r2=352699&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp Wed Jan 30 16:04:48 2019<br>
@@ -1498,7 +1498,8 @@ void DAGTypeLegalizer::ExpandIntegerResu<br>
     dbgs() << "ExpandIntegerResult #" << ResNo << ": ";<br>
     N->dump(&DAG); dbgs() << "\n";<br>
 #endif<br>
-    llvm_unreachable("Do not know how to expand the result of this operator!");<br>
+    report_fatal_error("Do not know how to expand the result of this "<br>
+                       "operator!");<br>
<br>
   case ISD::MERGE_VALUES: SplitRes_MERGE_VALUES(N, ResNo, Lo, Hi); break;<br>
   case ISD::SELECT:       SplitRes_SELECT(N, Lo, Hi); break;<br>
@@ -3166,7 +3167,7 @@ bool DAGTypeLegalizer::ExpandIntegerOper<br>
     dbgs() << "ExpandIntegerOperand Op #" << OpNo << ": ";<br>
     N->dump(&DAG); dbgs() << "\n";<br>
   #endif<br>
-    llvm_unreachable("Do not know how to expand this operator's operand!");<br>
+    report_fatal_error("Do not know how to expand this operator's operand!");<br>
<br>
   case ISD::BITCAST:           Res = ExpandOp_BITCAST(N); break;<br>
   case ISD::BR_CC:             Res = ExpandIntOp_BR_CC(N); break;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>