<div dir="ltr">how is it breaking? (quote of a compile failure or the like might be handy)</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jan 25, 2019 at 7:25 AM Clement Courbet via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: courbet<br>
Date: Fri Jan 25 07:25:52 2019<br>
New Revision: 352206<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=352206&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=352206&view=rev</a><br>
Log:<br>
Revert r351954 "Add a value_type to ArrayRef."<br>
<br>
This breaks arm self-hosted buildbots.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ADT/ArrayRef.h<br>
    llvm/trunk/unittests/ADT/ArrayRefTest.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/ADT/ArrayRef.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ArrayRef.h?rev=352206&r1=352205&r2=352206&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ArrayRef.h?rev=352206&r1=352205&r2=352206&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/ADT/ArrayRef.h (original)<br>
+++ llvm/trunk/include/llvm/ADT/ArrayRef.h Fri Jan 25 07:25:52 2019<br>
@@ -44,7 +44,6 @@ namespace llvm {<br>
     using const_iterator = const T *;<br>
     using size_type = size_t;<br>
     using reverse_iterator = std::reverse_iterator<iterator>;<br>
-    using value_type = typename std::remove_cv<T>::type;<br>
<br>
   private:<br>
     /// The start of the array, in an external buffer.<br>
<br>
Modified: llvm/trunk/unittests/ADT/ArrayRefTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/ArrayRefTest.cpp?rev=352206&r1=352205&r2=352206&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/ArrayRefTest.cpp?rev=352206&r1=352205&r2=352206&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/unittests/ADT/ArrayRefTest.cpp (original)<br>
+++ llvm/trunk/unittests/ADT/ArrayRefTest.cpp Fri Jan 25 07:25:52 2019<br>
@@ -51,14 +51,6 @@ static_assert(<br>
     "Assigning from an initializer list");<br>
 #endif<br>
<br>
-// Check Typedefs.<br>
-static_assert(<br>
-    std::is_same<ArrayRef<int>::value_type, int>::value,<br>
-    "erroneous value_type");<br>
-static_assert(<br>
-    std::is_same<ArrayRef<const int>::value_type, int>::value,<br>
-    "erroneous value_type");<br>
-<br>
 namespace {<br>
<br>
 TEST(ArrayRefTest, AllocatorCopy) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>