<div dir="ltr">Hi Yvan,<div><br></div><div>I'll revert it, it looks like this is the culprit change indeed, but I'm surprised this completely static change can make a difference. The only thing I can see happening is some SFINAE code selecting another function because value_type was added to ArrayRef. Unfortunately I don't have a machine to debug this...</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jan 25, 2019 at 4:10 PM Yvan Roux <<a href="mailto:yvan.roux@linaro.org">yvan.roux@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Clement,<br>
<br>
This change broke ARMv7 and ARMv8 selfhosted bots, where second stage<br>
build fail with an LLVM out of memory error.<br>
<br>
logs of the first failure on ARMv8 are available here:<br>
<a href="http://lab.llvm.org:8011/builders/clang-cmake-armv8-selfhost-neon/builds/2013" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-armv8-selfhost-neon/builds/2013</a><br>
<br>
Cheers,<br>
Yvan<br>
<br>
On Wed, 23 Jan 2019 at 15:20, Clement Courbet via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: courbet<br>
> Date: Wed Jan 23 06:20:59 2019<br>
> New Revision: 351954<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=351954&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=351954&view=rev</a><br>
> Log:<br>
> Re-land rL322538 "Add a value_type to ArrayRef."<br>
><br>
> Modified:<br>
>     llvm/trunk/include/llvm/ADT/ArrayRef.h<br>
>     llvm/trunk/unittests/ADT/ArrayRefTest.cpp<br>
><br>
> Modified: llvm/trunk/include/llvm/ADT/ArrayRef.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ArrayRef.h?rev=351954&r1=351953&r2=351954&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ArrayRef.h?rev=351954&r1=351953&r2=351954&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/ADT/ArrayRef.h (original)<br>
> +++ llvm/trunk/include/llvm/ADT/ArrayRef.h Wed Jan 23 06:20:59 2019<br>
> @@ -44,6 +44,7 @@ namespace llvm {<br>
>      using const_iterator = const T *;<br>
>      using size_type = size_t;<br>
>      using reverse_iterator = std::reverse_iterator<iterator>;<br>
> +    using value_type = typename std::remove_cv<T>::type;<br>
><br>
>    private:<br>
>      /// The start of the array, in an external buffer.<br>
><br>
> Modified: llvm/trunk/unittests/ADT/ArrayRefTest.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/ArrayRefTest.cpp?rev=351954&r1=351953&r2=351954&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/ArrayRefTest.cpp?rev=351954&r1=351953&r2=351954&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/unittests/ADT/ArrayRefTest.cpp (original)<br>
> +++ llvm/trunk/unittests/ADT/ArrayRefTest.cpp Wed Jan 23 06:20:59 2019<br>
> @@ -51,6 +51,14 @@ static_assert(<br>
>      "Assigning from an initializer list");<br>
>  #endif<br>
><br>
> +// Check Typedefs.<br>
> +static_assert(<br>
> +    std::is_same<ArrayRef<int>::value_type, int>::value,<br>
> +    "erroneous value_type");<br>
> +static_assert(<br>
> +    std::is_same<ArrayRef<const int>::value_type, int>::value,<br>
> +    "erroneous value_type");<br>
> +<br>
>  namespace {<br>
><br>
>  TEST(ArrayRefTest, AllocatorCopy) {<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>