<div dir="ltr">Hi Martin,<div><br></div><div>Thanks for the heads up! I've reverted while I investigate.</div><div><br></div><div>Cheers,</div><div>Lang.</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 15, 2019 at 1:07 AM Martin Storsjö <<a href="mailto:martin@martin.st">martin@martin.st</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">This broke compilation with GCC 5.4.<br>
<br>
Compiling unittests/ExecutionEngine/Orc/CoreAPIsTest.cpp now fails with <br>
errors like these:<br>
<br>
../unittests/ExecutionEngine/Orc/CoreAPIsTest.cpp:268:271:   required from here<br>
../utils/unittest/googletest/include/gtest/internal/custom/raw-ostream.h:68:40:<br>
error: no match for ‘operator<<’ (operand types are ‘llvm::raw_ostream’ <br>
and ‘llvm_gtest::ConvertibleTo<const llvm::JITSymbolFlags&>’)<br>
                                         << ConvertibleTo<const T &>()))> {<br>
<br>
<br>
../include/llvm/Support/raw_ostream.h:147:16: note: candidate: <br>
llvm::raw_ostream& llvm::raw_ostream::operator<<(char)<br>
    raw_ostream &operator<<(char C) {<br>
                 ^<br>
../include/llvm/Support/raw_ostream.h:147:16: note:   no known conversion <br>
for argument 1 from ‘llvm_gtest::ConvertibleTo<const <br>
llvm::JITSymbolFlags&>’ to ‘char’<br>
../include/llvm/Support/raw_ostream.h:154:16: note: candidate: <br>
llvm::raw_ostream& llvm::raw_ostream::operator<<(unsigned char)<br>
    raw_ostream &operator<<(unsigned char C) {<br>
                 ^<br>
<br>
... and so on for lots of types, but none of the operators declared in <br>
CoreTypes.h are listed as candidates. However if I remove the declaration <br>
of "raw_ostream &operator<<(raw_ostream &OS, const JITSymbolFlags <br>
&Flags);" from there (which was added into the public header in this <br>
commit, before it was only present within Core.cpp) compiling the unit <br>
test works again.<br>
<br>
// Martin<br>
<br>
<br>
<br>
On Mon, 14 Jan 2019, Lang Hames via llvm-commits wrote:<br>
<br>
> Author: lhames<br>
> Date: Mon Jan 14 15:49:13 2019<br>
> New Revision: 351138<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=351138&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=351138&view=rev</a><br>
> Log:<br>
> [ORC] Move ORC Core symbol map and set types into their own header: CoreTypes.h.<br>
><br>
> This will allow other utilities (including a future RuntimeDyld replacement) to<br>
> use these types without pulling in the major Core types (JITDylib, etc.).</blockquote></div>