<div dir="ltr">Nothing more than what's on the internal bug report shared with you. The target triple seems to be not ptx, yet ptxas is being invoked somehow.</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 17, 2018 at 11:20 AM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Tue, Dec 11, 2018 at 1:29 PM Jordan Rupprecht via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: rupprecht<br>
Date: Tue Dec 11 13:26:52 2018<br>
New Revision: 348898<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=348898&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=348898&view=rev</a><br>
Log:<br>
Revert "debuginfo: Use symbol difference for CU length to simplify assembly reading/editing"<br>
<br>
Temporarily reverts commit r348806 due to strange asm compilation issues in certain modes (combination of asan+cuda+other things). Will provide repro soon.<br></blockquote><div><br>Jordan - did you happen to get any more info on this?<br><br>Art - given cuda+debug info is something you've some context on. Any idea why the "if !nvptx" logic in this code wouldn't be sufficient & what would be sufficient to workaround this issue?<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Modified:<br>
llvm/trunk/lib/CodeGen/AsmPrinter/DwarfFile.cpp<br>
llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp<br>
llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.h<br>
llvm/trunk/test/DebugInfo/X86/sections_as_references.ll<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfFile.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfFile.cpp?rev=348898&r1=348897&r2=348898&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfFile.cpp?rev=348898&r1=348897&r2=348898&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfFile.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfFile.cpp Tue Dec 11 13:26:52 2018<br>
@@ -46,8 +46,6 @@ void DwarfFile::emitUnit(DwarfUnit *TheU<br>
TheU->emitHeader(UseOffsets);<br>
<br>
Asm->emitDwarfDIE(Die);<br>
-<br>
- Asm->OutStreamer->EmitLabel(TheU->getEndLabel());<br>
}<br>
<br>
// Compute the size and offset for each DIE.<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=348898&r1=348897&r2=348898&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=348898&r1=348897&r2=348898&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp Tue Dec 11 13:26:52 2018<br>
@@ -38,7 +38,6 @@<br>
#include "llvm/Support/Casting.h"<br>
#include "llvm/Support/CommandLine.h"<br>
#include "llvm/Target/TargetLoweringObjectFile.h"<br>
-#include "llvm/Target/TargetMachine.h"<br>
#include <cassert><br>
#include <cstdint><br>
#include <string><br>
@@ -1554,17 +1553,7 @@ DIE *DwarfUnit::getOrCreateStaticMemberD<br>
void DwarfUnit::emitCommonHeader(bool UseOffsets, dwarf::UnitType UT) {<br>
// Emit size of content not including length itself<br>
Asm->OutStreamer->AddComment("Length of Unit");<br>
- StringRef Prefix = isDwoUnit() ? "debug_info_dwo_" : "debug_info_";<br>
- MCSymbol *BeginLabel = Asm->createTempSymbol(Prefix + "start");<br>
- EndLabel = Asm->createTempSymbol(Prefix + "end");<br>
-<br>
- // Use a label difference for the convenience of legible/easily modified<br>
- // assembly - except on NVPTX where label differences aren't supported.<br>
- if (Asm->TM.getTargetTriple().isNVPTX())<br>
- Asm->emitInt32(getHeaderSize() + getUnitDie().getSize());<br>
- else<br>
- Asm->EmitLabelDifference(EndLabel, BeginLabel, 4);<br>
- Asm->OutStreamer->EmitLabel(BeginLabel);<br>
+ Asm->emitInt32(getHeaderSize() + getUnitDie().getSize());<br>
<br>
Asm->OutStreamer->AddComment("DWARF version number");<br>
unsigned Version = DD->getDwarfVersion();<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.h?rev=348898&r1=348897&r2=348898&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.h?rev=348898&r1=348897&r2=348898&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.h (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.h Tue Dec 11 13:26:52 2018<br>
@@ -48,7 +48,6 @@ protected:<br>
<br>
/// Target of Dwarf emission.<br>
AsmPrinter *Asm;<br>
- MCSymbol *EndLabel;<br>
<br>
// Holders for some common dwarf information.<br>
DwarfDebug *DD;<br>
@@ -83,7 +82,6 @@ protected:<br>
public:<br>
// Accessors.<br>
AsmPrinter* getAsmPrinter() const { return Asm; }<br>
- MCSymbol *getEndLabel() const { return EndLabel; }<br>
uint16_t getLanguage() const { return CUNode->getSourceLanguage(); }<br>
const DICompileUnit *getCUNode() const { return CUNode; }<br>
<br>
<br>
Modified: llvm/trunk/test/DebugInfo/X86/sections_as_references.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/sections_as_references.ll?rev=348898&r1=348897&r2=348898&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/sections_as_references.ll?rev=348898&r1=348897&r2=348898&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/X86/sections_as_references.ll (original)<br>
+++ llvm/trunk/test/DebugInfo/X86/sections_as_references.ll Tue Dec 11 13:26:52 2018<br>
@@ -9,19 +9,13 @@<br>
; CHECK-NOT: .L<br>
<br>
; CHECK: .section .debug_info<br>
-; CHECK-NEXT: .long .Ldebug_info_end0-.Ldebug_info_start0 # Length of Unit<br>
-; CHECK-NEXT: .Ldebug_info_start0:<br>
-; CHECK-NEXT: .short 2 # DWARF version number<br>
+; CHECK-NOT: .L<br>
+; CHECK: .short 2 # DWARF version number<br>
; CHECK-NOT: .L<br>
; CHECK: .long .debug_abbrev # Offset Into Abbrev. Section<br>
; CHECK-NOT: .L<br>
; CHECK: .long .debug_line # DW_AT_stmt_list<br>
; CHECK-NOT: .L<br>
-; CHECK: .Ldebug_info_end0:<br>
-; CHECK-NOT: .L<br>
-; CHECK: .long .Ldebug_info_end1-.Ldebug_info_start1 # Length of Unit<br>
-; CHECK-NEXT: .Ldebug_info_start1:<br>
-; CHECK-NOT: .L<br>
; CHECK: .long .debug_abbrev # Offset Into Abbrev. Section<br>
; CHECK-NOT: .L<br>
; CHECK: .long .debug_line # DW_AT_stmt_list<br>
@@ -29,7 +23,6 @@<br>
; CHECK: .quad .debug_info+{{[0-9]+}} # DW_AT_type<br>
; CHECK-NOT: .L<br>
; CHECK: .byte 0 # End Of Children Mark<br>
-; CHECK-NEXT: .Ldebug_info_end1:<br>
; CHECK-NOT: .L<br>
<br>
source_filename = "test/DebugInfo/X86/sections_as_references.ll"<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>
</blockquote></div>