<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Ah ok. Thanks<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 14 Dec 2018, at 22:52, Eric Fiselier <<a href="mailto:eric@efcs.ca" class="">eric@efcs.ca</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I use modules for all my builds, so that caused them to break.<div class=""><br class=""></div><div class=""><br class=""></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Dec 14, 2018 at 4:58 PM Daniel Sanders <<a href="mailto:daniel_l_sanders@apple.com" class="">daniel_l_sanders@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Thanks. I just got a bug report about this from an out of tree target and went to fix it but you beat me to it.<br class="">
<br class="">
Out of curiosity, was it one of the LLVM bots that noticed this? I haven't seen it in any of the mail I got from the bots.<br class="">
<br class="">
> On 14 Dec 2018, at 21:04, Eric Fiselier via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
> <br class="">
> Author: ericwf<br class="">
> Date: Fri Dec 14 13:04:00 2018<br class="">
> New Revision: 349193<br class="">
> <br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=349193&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=349193&view=rev</a><br class="">
> Log:<br class="">
> Add missing includes and forward decls to unbreak build<br class="">
> <br class="">
> Modified:<br class="">
> llvm/trunk/include/llvm/CodeGen/GlobalISel/GISelWorkList.h<br class="">
> <br class="">
> Modified: llvm/trunk/include/llvm/CodeGen/GlobalISel/GISelWorkList.h<br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/GlobalISel/GISelWorkList.h?rev=349193&r1=349192&r2=349193&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/GlobalISel/GISelWorkList.h?rev=349193&r1=349192&r2=349193&view=diff</a><br class="">
> ==============================================================================<br class="">
> --- llvm/trunk/include/llvm/CodeGen/GlobalISel/GISelWorkList.h (original)<br class="">
> +++ llvm/trunk/include/llvm/CodeGen/GlobalISel/GISelWorkList.h Fri Dec 14 13:04:00 2018<br class="">
> @@ -12,11 +12,13 @@<br class="">
> <br class="">
> #include "llvm/ADT/DenseMap.h"<br class="">
> #include "llvm/ADT/SmallVector.h"<br class="">
> +#include "llvm/CodeGen/MachineBasicBlock.h"<br class="">
> +#include "llvm/CodeGen/MachineInstr.h"<br class="">
> #include "llvm/Support/Debug.h"<br class="">
> <br class="">
> namespace llvm {<br class="">
> <br class="">
> -class MachineInstr;<br class="">
> +class MachineFunction;<br class="">
> <br class="">
> // Worklist which mostly works similar to InstCombineWorkList, but on<br class="">
> // MachineInstrs. The main difference with something like a SetVector is that<br class="">
> <br class="">
> <br class="">
> _______________________________________________<br class="">
> llvm-commits mailing list<br class="">
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
<br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>