<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Dec 6, 2018 at 6:04 AM Simon Pilgrim via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rksimon<br>
Date: Thu Dec  6 06:02:02 2018<br>
New Revision: 348486<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=348486&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=348486&view=rev</a><br>
Log:<br>
Fix -Wcovered-switch-default warning. NFCI.<br>
<br>
Modified:<br>
    llvm/trunk/utils/benchmark/src/sysinfo.cc<br>
<br>
Modified: llvm/trunk/utils/benchmark/src/sysinfo.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/benchmark/src/sysinfo.cc?rev=348486&r1=348485&r2=348486&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/benchmark/src/sysinfo.cc?rev=348486&r1=348485&r2=348486&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/utils/benchmark/src/sysinfo.cc (original)<br>
+++ llvm/trunk/utils/benchmark/src/sysinfo.cc Thu Dec  6 06:02:02 2018<br>
@@ -333,6 +333,7 @@ std::vector<CPUInfo::CacheInfo> GetCache<br>
     C.num_sharing = static_cast<int>(B.count());<br>
     C.level = Cache->Level;<br>
     C.size = Cache->Size;<br>
+    C.type = "Unknown";<br></blockquote><div><br>Is this ^ necessary, given that all the cases assign a value to C.type in the end anyway? Looks like this assignment is a dead store, perhaps?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
     switch (Cache->Type) {<br>
       case CacheUnified:<br>
         C.type = "Unified";<br>
@@ -346,9 +347,6 @@ std::vector<CPUInfo::CacheInfo> GetCache<br>
       case CacheTrace:<br>
         C.type = "Trace";<br>
         break;<br>
-      default:<br>
-        C.type = "Unknown";<br>
-        break;<br>
     }<br>
     res.push_back(C);<br>
   }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>